[libcamera-ci,v1,2/2] Save `build.ninja` as artifact
diff mbox series

Message ID 20260119092617.3506559-2-barnabas.pocze@ideasonboard.com
State Accepted
Headers show
Series
  • [libcamera-ci,v1,1/2] Save `meson-logs` as artifact in `build-package:cros` job
Related show

Commit Message

Barnabás Pőcze Jan. 19, 2026, 9:26 a.m. UTC 
It is useful for debugging problems related to compilation or linking.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 gitlab-ci.yml | 4 ++++
 1 file changed, 4 insertions(+)

--
2.52.0

Comments

Laurent Pinchart Jan. 19, 2026, 12:18 p.m. UTC | #1 
On Mon, Jan 19, 2026 at 10:26:17AM +0100, Barnabás Pőcze wrote:
> It is useful for debugging problems related to compilation or linking.

Slightly less convinced by this one compared to 1/2, but I assume you
have found it useful, so I don't object.

> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> ---
>  gitlab-ci.yml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/gitlab-ci.yml b/gitlab-ci.yml
> index 4edb6a7..249e3ef 100644
> --- a/gitlab-ci.yml
> +++ b/gitlab-ci.yml
> @@ -142,6 +142,7 @@ container-debian:13:
>      expire_in: 1 week
>      paths:
>        - build/meson-logs/
> +      - build/build.ninja
>    variables:
>      BUILD_TYPE: debug
>      MESON_OPTIONS: ${MESON_ALL_OPTIONS}
> @@ -282,6 +283,7 @@ build-package:debug:
>      expire_in: 1 week
>      paths:
>        - build/meson-logs/
> +      - build/build.ninja
>        - libcamera-${CI_COMMIT_SHA}.tar.xz
>    variables:
>      BUILD_TYPE: debug
> @@ -316,6 +318,7 @@ build-package:cros:
>      name: libcamera-cros-${CI_COMMIT_SHA}
>      paths:
>        - build/meson-logs/
> +      - build/build.ninja
>        - libcamera-upstream-9999.tbz2
> 
>  # ------------------------------------------------------------------------------
> @@ -381,6 +384,7 @@ test-unit:
>      expire_in: 1 week
>      paths:
>        - build/meson-logs/
> +      - build/build.ninja

Is it needed here though ? If the goal is to debug compilation,
shouldn't we limit it to the build jobs ?

>      reports:
>        junit: build/meson-logs/testlog.junit.xml
>    variables:
Barnabás Pőcze Jan. 19, 2026, 12:35 p.m. UTC | #2 
2026. 01. 19. 13:18 keltezéssel, Laurent Pinchart írta:
> On Mon, Jan 19, 2026 at 10:26:17AM +0100, Barnabás Pőcze wrote:
>> It is useful for debugging problems related to compilation or linking.
> 
> Slightly less convinced by this one compared to 1/2, but I assume you
> have found it useful, so I don't object.
> 
>> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
>> ---
>>   gitlab-ci.yml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/gitlab-ci.yml b/gitlab-ci.yml
>> index 4edb6a7..249e3ef 100644
>> --- a/gitlab-ci.yml
>> +++ b/gitlab-ci.yml
>> @@ -142,6 +142,7 @@ container-debian:13:
>>       expire_in: 1 week
>>       paths:
>>         - build/meson-logs/
>> +      - build/build.ninja
>>     variables:
>>       BUILD_TYPE: debug
>>       MESON_OPTIONS: ${MESON_ALL_OPTIONS}
>> @@ -282,6 +283,7 @@ build-package:debug:
>>       expire_in: 1 week
>>       paths:
>>         - build/meson-logs/
>> +      - build/build.ninja
>>         - libcamera-${CI_COMMIT_SHA}.tar.xz
>>     variables:
>>       BUILD_TYPE: debug
>> @@ -316,6 +318,7 @@ build-package:cros:
>>       name: libcamera-cros-${CI_COMMIT_SHA}
>>       paths:
>>         - build/meson-logs/
>> +      - build/build.ninja
>>         - libcamera-upstream-9999.tbz2
>>
>>   # ------------------------------------------------------------------------------
>> @@ -381,6 +384,7 @@ test-unit:
>>       expire_in: 1 week
>>       paths:
>>         - build/meson-logs/
>> +      - build/build.ninja
> 
> Is it needed here though ? If the goal is to debug compilation,
> shouldn't we limit it to the build jobs ?

Maybe somewhat misleading, but `test-unit` builds libcamera.


> 
>>       reports:
>>         junit: build/meson-logs/testlog.junit.xml
>>     variables:
>
Laurent Pinchart Jan. 19, 2026, 5:26 p.m. UTC | #3 
On Mon, Jan 19, 2026 at 01:35:51PM +0100, Barnabás Pőcze wrote:
> 2026. 01. 19. 13:18 keltezéssel, Laurent Pinchart írta:
> > On Mon, Jan 19, 2026 at 10:26:17AM +0100, Barnabás Pőcze wrote:
> >> It is useful for debugging problems related to compilation or linking.
> > 
> > Slightly less convinced by this one compared to 1/2, but I assume you
> > have found it useful, so I don't object.
> > 
> >> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> >> ---
> >>   gitlab-ci.yml | 4 ++++
> >>   1 file changed, 4 insertions(+)
> >>
> >> diff --git a/gitlab-ci.yml b/gitlab-ci.yml
> >> index 4edb6a7..249e3ef 100644
> >> --- a/gitlab-ci.yml
> >> +++ b/gitlab-ci.yml
> >> @@ -142,6 +142,7 @@ container-debian:13:
> >>       expire_in: 1 week
> >>       paths:
> >>         - build/meson-logs/
> >> +      - build/build.ninja
> >>     variables:
> >>       BUILD_TYPE: debug
> >>       MESON_OPTIONS: ${MESON_ALL_OPTIONS}
> >> @@ -282,6 +283,7 @@ build-package:debug:
> >>       expire_in: 1 week
> >>       paths:
> >>         - build/meson-logs/
> >> +      - build/build.ninja
> >>         - libcamera-${CI_COMMIT_SHA}.tar.xz
> >>     variables:
> >>       BUILD_TYPE: debug
> >> @@ -316,6 +318,7 @@ build-package:cros:
> >>       name: libcamera-cros-${CI_COMMIT_SHA}
> >>       paths:
> >>         - build/meson-logs/
> >> +      - build/build.ninja
> >>         - libcamera-upstream-9999.tbz2
> >>
> >>   # ------------------------------------------------------------------------------
> >> @@ -381,6 +384,7 @@ test-unit:
> >>       expire_in: 1 week
> >>       paths:
> >>         - build/meson-logs/
> >> +      - build/build.ninja
> > 
> > Is it needed here though ? If the goal is to debug compilation,
> > shouldn't we limit it to the build jobs ?
> 
> Maybe somewhat misleading, but `test-unit` builds libcamera.

Ideally the job should reuse artifacts from a build job. I think the
main reason it's not happening at the moment is that we can't use meson
as a unit test runner without the source tree.

Let' not dwell on this for now,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> >>       reports:
> >>         junit: build/meson-logs/testlog.junit.xml
> >>     variables:

Patch
diff mbox series 

diff --git a/gitlab-ci.yml b/gitlab-ci.yml
index 4edb6a7..249e3ef 100644
--- a/gitlab-ci.yml
+++ b/gitlab-ci.yml
@@ -142,6 +142,7 @@  container-debian:13:
     expire_in: 1 week
     paths:
       - build/meson-logs/
+      - build/build.ninja
   variables:
     BUILD_TYPE: debug
     MESON_OPTIONS: ${MESON_ALL_OPTIONS}
@@ -282,6 +283,7 @@  build-package:debug:
     expire_in: 1 week
     paths:
       - build/meson-logs/
+      - build/build.ninja
       - libcamera-${CI_COMMIT_SHA}.tar.xz
   variables:
     BUILD_TYPE: debug
@@ -316,6 +318,7 @@  build-package:cros:
     name: libcamera-cros-${CI_COMMIT_SHA}
     paths:
       - build/meson-logs/
+      - build/build.ninja
       - libcamera-upstream-9999.tbz2

 # ------------------------------------------------------------------------------
@@ -381,6 +384,7 @@  test-unit:
     expire_in: 1 week
     paths:
       - build/meson-logs/
+      - build/build.ninja
     reports:
       junit: build/meson-logs/testlog.junit.xml
   variables: