| Message ID | 20260110170927.79918-4-robert.mader@collabora.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi, On 10-Jan-26 18:09, Robert Mader wrote: > The line above already prints it. > > Signed-off-by: Robert Mader <robert.mader@collabora.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com> Regards, Hans > --- > src/libcamera/egl.cpp | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp > index fcaf7c58f..0bd9a83be 100644 > --- a/src/libcamera/egl.cpp > +++ b/src/libcamera/egl.cpp > @@ -305,7 +305,6 @@ int eGL::initEGLContext(GBM *gbmContext) > } > > LOG(eGL, Info) << "EGL: version " << major << "." << minor; > - LOG(eGL, Info) << "EGL: EGL_VERSION: " << eglQueryString(display_, EGL_VERSION); > LOG(eGL, Info) << "EGL: EGL_VENDOR: " << eglQueryString(display_, EGL_VENDOR); > LOG(eGL, Info) << "EGL: EGL_CLIENT_APIS: " << eglQueryString(display_, EGL_CLIENT_APIS); > LOG(eGL, Info) << "EGL: EGL_EXTENSIONS: " << eglQueryString(display_, EGL_EXTENSIONS);
2026. 01. 10. 18:09 keltezéssel, Robert Mader írta: > The line above already prints it. > > Signed-off-by: Robert Mader <robert.mader@collabora.com> > --- > src/libcamera/egl.cpp | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp > index fcaf7c58f..0bd9a83be 100644 > --- a/src/libcamera/egl.cpp > +++ b/src/libcamera/egl.cpp > @@ -305,7 +305,6 @@ int eGL::initEGLContext(GBM *gbmContext) > } > > LOG(eGL, Info) << "EGL: version " << major << "." << minor; > - LOG(eGL, Info) << "EGL: EGL_VERSION: " << eglQueryString(display_, EGL_VERSION); Is it not possible that this string could contain more info that the major + minor version numbers? Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > LOG(eGL, Info) << "EGL: EGL_VENDOR: " << eglQueryString(display_, EGL_VENDOR); > LOG(eGL, Info) << "EGL: EGL_CLIENT_APIS: " << eglQueryString(display_, EGL_CLIENT_APIS); > LOG(eGL, Info) << "EGL: EGL_EXTENSIONS: " << eglQueryString(display_, EGL_EXTENSIONS); > -- > 2.52.0 >
Hi, thanks for the review. On 12.01.26 09:35, Barnabás Pőcze wrote: > 2026. 01. 10. 18:09 keltezéssel, Robert Mader írta: >> The line above already prints it. >> >> Signed-off-by: Robert Mader <robert.mader@collabora.com> >> --- >> src/libcamera/egl.cpp | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp >> index fcaf7c58f..0bd9a83be 100644 >> --- a/src/libcamera/egl.cpp >> +++ b/src/libcamera/egl.cpp >> @@ -305,7 +305,6 @@ int eGL::initEGLContext(GBM *gbmContext) >> } >> >> LOG(eGL, Info) << "EGL: version " << major << "." << minor; >> - LOG(eGL, Info) << "EGL: EGL_VERSION: " << >> eglQueryString(display_, EGL_VERSION); > > Is it not possible that this string could contain more info > that the major + minor version numbers? It's possible in theory, but has not been the case on Mesa drivers so far. What we could do, however, is remove the line above instead (so we print EGL_VERSION instead of major.minor) - but I'd only do that if somebody here shows a strong preference for that. > Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > > >> LOG(eGL, Info) << "EGL: EGL_VENDOR: " << >> eglQueryString(display_, EGL_VENDOR); >> LOG(eGL, Info) << "EGL: EGL_CLIENT_APIS: " << >> eglQueryString(display_, EGL_CLIENT_APIS); >> LOG(eGL, Info) << "EGL: EGL_EXTENSIONS: " << >> eglQueryString(display_, EGL_EXTENSIONS); >> -- >> 2.52.0 >> >
diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp index fcaf7c58f..0bd9a83be 100644 --- a/src/libcamera/egl.cpp +++ b/src/libcamera/egl.cpp @@ -305,7 +305,6 @@ int eGL::initEGLContext(GBM *gbmContext) } LOG(eGL, Info) << "EGL: version " << major << "." << minor; - LOG(eGL, Info) << "EGL: EGL_VERSION: " << eglQueryString(display_, EGL_VERSION); LOG(eGL, Info) << "EGL: EGL_VENDOR: " << eglQueryString(display_, EGL_VENDOR); LOG(eGL, Info) << "EGL: EGL_CLIENT_APIS: " << eglQueryString(display_, EGL_CLIENT_APIS); LOG(eGL, Info) << "EGL: EGL_EXTENSIONS: " << eglQueryString(display_, EGL_EXTENSIONS);
The line above already prints it. Signed-off-by: Robert Mader <robert.mader@collabora.com> --- src/libcamera/egl.cpp | 1 - 1 file changed, 1 deletion(-)