| Message ID | 20251227054042.3836430-1-johannes.schneider@leica-geosystems.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi Johannes, Thank you for the patch. On Sat, Dec 27, 2025 at 06:40:40AM +0100, Johannes Schneider wrote: > Building libcamera with clang raises some warnings-as-errors. None of those issues are present in the master branch. Are you by any chance working with out-of-tree changes ? > Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com> > --- > > Hoi, > > you could/should consider compiling with clang too ;-) We do :-) Our CI pipeline compiles with different versions of gcc and clang. See https://gitlab.freedesktop.org/camera/libcamera/-/jobs/89987029 for instance. > --- > include/libcamera/internal/camera_sensor_helper.h | 2 +- > src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +- > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 - > 3 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/include/libcamera/internal/camera_sensor_helper.h b/include/libcamera/internal/camera_sensor_helper.h > index 1e1e479..1b3217b 100644 > --- a/include/libcamera/internal/camera_sensor_helper.h > +++ b/include/libcamera/internal/camera_sensor_helper.h > @@ -61,7 +61,7 @@ public: > > static std::vector<CameraSensorHelperFactoryBase *> &factories(); > > - const std::string &name() const { return name_; }; > + const std::string &name() const { return name_; } > > private: > LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase) > diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp > index d6b95fb..368320f 100644 > --- a/src/libcamera/converter/converter_v4l2_m2m.cpp > +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp > @@ -258,7 +258,7 @@ int V4L2M2MConverter::V4L2M2MStream::applyControls(ControlList &ctrls, > const V4L2Request *request) > { > return m2m_->capture()->setControls(&ctrls, request); > -}; > +} > > /* ----------------------------------------------------------------------------- > * V4L2M2MConverter > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > index ca9e850..1437318 100644 > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > @@ -377,7 +377,6 @@ int RkISP1CameraData::loadTuningFile(const std::string &path) > const auto ¶ms = algo["Dewarp"]; > > canUseDewarper_ = true; > - Matrix<double, 3, 3> m; > DewarpParms dp; > if (params["cm"]) { > const auto &cm = params["cm"].get<Matrix<double, 3, 3>>();
Hoi, > > Hi Johannes, > > Thank you for the patch. > > On Sat, Dec 27, 2025 at 06:40:40AM +0100, Johannes Schneider wrote: > > Building libcamera with clang raises some warnings-as-errors. > > None of those issues are present in the master branch. Are you by any > chance working with out-of-tree changes ? > ups, that could be, i thought we where at (or even ahead of) master - i should have checked :-$ we're using a branch that stefan.klug last updated... so maybe those minor things snuck in there. > > > Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com> > > --- > > > > Hoi, > > > > you could/should consider compiling with clang too ;-) > > We do :-) Our CI pipeline compiles with different versions of gcc and > clang. See https://gitlab.freedesktop.org/camera/libcamera/-/jobs/89987029 > for instance. nice! btw: i stumbled over these complaints while building our meta-layer with meta-clang for an imx8mp = arm64 machine anyway: all bases are covered then -> sorry for the chatter (-: > > > --- > > include/libcamera/internal/camera_sensor_helper.h | 2 +- > > src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +- > > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 - > > 3 files changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/include/libcamera/internal/camera_sensor_helper.h b/include/libcamera/internal/camera_sensor_helper.h > > index 1e1e479..1b3217b 100644 > > --- a/include/libcamera/internal/camera_sensor_helper.h > > +++ b/include/libcamera/internal/camera_sensor_helper.h > > @@ -61,7 +61,7 @@ public: > > > > static std::vector<CameraSensorHelperFactoryBase *> &factories(); > > > > - const std::string &name() const { return name_; }; > > + const std::string &name() const { return name_; } > > > > private: > > LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase) > > diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp > > index d6b95fb..368320f 100644 > > --- a/src/libcamera/converter/converter_v4l2_m2m.cpp > > +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp > > @@ -258,7 +258,7 @@ int V4L2M2MConverter::V4L2M2MStream::applyControls(ControlList &ctrls, > > const V4L2Request *request) > > { > > return m2m_->capture()->setControls(&ctrls, request); > > -}; > > +} > > > > /* ----------------------------------------------------------------------------- > > * V4L2M2MConverter > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > index ca9e850..1437318 100644 > > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > @@ -377,7 +377,6 @@ int RkISP1CameraData::loadTuningFile(const std::string &path) > > const auto ¶ms = algo["Dewarp"]; > > > > canUseDewarper_ = true; > > - Matrix<double, 3, 3> m; > > DewarpParms dp; > > if (params["cm"]) { > > const auto &cm = params["cm"].get<Matrix<double, 3, 3>>(); > > -- > Regards, > > Laurent Pinchart > gruß Johannes
On Sat, Dec 27, 2025 at 10:57:36AM +0000, SCHNEIDER Johannes wrote: > > On Sat, Dec 27, 2025 at 06:40:40AM +0100, Johannes Schneider wrote: > > > Building libcamera with clang raises some warnings-as-errors. > > > > None of those issues are present in the master branch. Are you by any > > chance working with out-of-tree changes ? > > ups, that could be, i thought we where at (or even ahead of) master - i should > have checked :-$ > we're using a branch that stefan.klug last updated... so maybe those minor > things snuck in there. I'm sure Stefan will fix this before upstreaming the changes. Or he will be told off by CI :-) > > > Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com> > > > --- > > > > > > Hoi, > > > > > > you could/should consider compiling with clang too ;-) > > > > We do :-) Our CI pipeline compiles with different versions of gcc and > > clang. See https://gitlab.freedesktop.org/camera/libcamera/-/jobs/89987029 > > for instance. > > nice! > > btw: i stumbled over these complaints while building our meta-layer with > meta-clang for an imx8mp = arm64 machine > > anyway: all bases are covered then -> sorry for the chatter (-: No worries. > > > --- > > > include/libcamera/internal/camera_sensor_helper.h | 2 +- > > > src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +- > > > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 - > > > 3 files changed, 2 insertions(+), 3 deletions(-) > > > > > > diff --git a/include/libcamera/internal/camera_sensor_helper.h b/include/libcamera/internal/camera_sensor_helper.h > > > index 1e1e479..1b3217b 100644 > > > --- a/include/libcamera/internal/camera_sensor_helper.h > > > +++ b/include/libcamera/internal/camera_sensor_helper.h > > > @@ -61,7 +61,7 @@ public: > > > > > > static std::vector<CameraSensorHelperFactoryBase *> &factories(); > > > > > > - const std::string &name() const { return name_; }; > > > + const std::string &name() const { return name_; } > > > > > > private: > > > LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase) > > > diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp > > > index d6b95fb..368320f 100644 > > > --- a/src/libcamera/converter/converter_v4l2_m2m.cpp > > > +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp > > > @@ -258,7 +258,7 @@ int V4L2M2MConverter::V4L2M2MStream::applyControls(ControlList &ctrls, > > > const V4L2Request *request) > > > { > > > return m2m_->capture()->setControls(&ctrls, request); > > > -}; > > > +} > > > > > > /* ----------------------------------------------------------------------------- > > > * V4L2M2MConverter > > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > > index ca9e850..1437318 100644 > > > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > > @@ -377,7 +377,6 @@ int RkISP1CameraData::loadTuningFile(const std::string &path) > > > const auto ¶ms = algo["Dewarp"]; > > > > > > canUseDewarper_ = true; > > > - Matrix<double, 3, 3> m; > > > DewarpParms dp; > > > if (params["cm"]) { > > > const auto &cm = params["cm"].get<Matrix<double, 3, 3>>();
Hi 2025. 12. 27. 11:34 keltezéssel, Laurent Pinchart írta: > Hi Johannes, > > Thank you for the patch. > > On Sat, Dec 27, 2025 at 06:40:40AM +0100, Johannes Schneider wrote: >> Building libcamera with clang raises some warnings-as-errors. > > None of those issues are present in the master branch. Are you by any > chance working with out-of-tree changes ? > >> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com> >> --- >> >> Hoi, >> >> you could/should consider compiling with clang too ;-) > > We do :-) Our CI pipeline compiles with different versions of gcc and > clang. See https://gitlab.freedesktop.org/camera/libcamera/-/jobs/89987029 > for instance. There should probably be newer clang there. libcamera hasn't been compile-able with newer clang for a while now (I have clang 21.1.6) and I get: -Werror,-Winconsistent-missing-override in multiple places. > >> --- >> include/libcamera/internal/camera_sensor_helper.h | 2 +- >> src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +- >> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 - >> 3 files changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/include/libcamera/internal/camera_sensor_helper.h b/include/libcamera/internal/camera_sensor_helper.h >> index 1e1e479..1b3217b 100644 >> --- a/include/libcamera/internal/camera_sensor_helper.h >> +++ b/include/libcamera/internal/camera_sensor_helper.h >> @@ -61,7 +61,7 @@ public: >> >> static std::vector<CameraSensorHelperFactoryBase *> &factories(); >> >> - const std::string &name() const { return name_; }; >> + const std::string &name() const { return name_; } >> >> private: >> LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase) >> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp >> index d6b95fb..368320f 100644 >> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp >> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp >> @@ -258,7 +258,7 @@ int V4L2M2MConverter::V4L2M2MStream::applyControls(ControlList &ctrls, >> const V4L2Request *request) >> { >> return m2m_->capture()->setControls(&ctrls, request); >> -}; >> +} >> >> /* ----------------------------------------------------------------------------- >> * V4L2M2MConverter >> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp >> index ca9e850..1437318 100644 >> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp >> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp >> @@ -377,7 +377,6 @@ int RkISP1CameraData::loadTuningFile(const std::string &path) >> const auto ¶ms = algo["Dewarp"]; >> >> canUseDewarper_ = true; >> - Matrix<double, 3, 3> m; >> DewarpParms dp; >> if (params["cm"]) { >> const auto &cm = params["cm"].get<Matrix<double, 3, 3>>(); > > -- > Regards, > > Laurent Pinchart
On Sat, Dec 27, 2025 at 01:17:11PM +0000, Barnabás Pőcze wrote: > 2025. 12. 27. 11:34 keltezéssel, Laurent Pinchart írta: > > On Sat, Dec 27, 2025 at 06:40:40AM +0100, Johannes Schneider wrote: > >> Building libcamera with clang raises some warnings-as-errors. > > > > None of those issues are present in the master branch. Are you by any > > chance working with out-of-tree changes ? > > > >> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com> > >> --- > >> > >> Hoi, > >> > >> you could/should consider compiling with clang too ;-) > > > > We do :-) Our CI pipeline compiles with different versions of gcc and > > clang. See https://gitlab.freedesktop.org/camera/libcamera/-/jobs/89987029 > > for instance. > > There should probably be newer clang there. libcamera hasn't been compile-able > with newer clang for a while now (I have clang 21.1.6) and I get: > > -Werror,-Winconsistent-missing-override > > in multiple places. We could try to add a Debian Forky container, it ships clang 21. > >> --- > >> include/libcamera/internal/camera_sensor_helper.h | 2 +- > >> src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +- > >> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 - > >> 3 files changed, 2 insertions(+), 3 deletions(-) > >> > >> diff --git a/include/libcamera/internal/camera_sensor_helper.h b/include/libcamera/internal/camera_sensor_helper.h > >> index 1e1e479..1b3217b 100644 > >> --- a/include/libcamera/internal/camera_sensor_helper.h > >> +++ b/include/libcamera/internal/camera_sensor_helper.h > >> @@ -61,7 +61,7 @@ public: > >> > >> static std::vector<CameraSensorHelperFactoryBase *> &factories(); > >> > >> - const std::string &name() const { return name_; }; > >> + const std::string &name() const { return name_; } > >> > >> private: > >> LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase) > >> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp > >> index d6b95fb..368320f 100644 > >> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp > >> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp > >> @@ -258,7 +258,7 @@ int V4L2M2MConverter::V4L2M2MStream::applyControls(ControlList &ctrls, > >> const V4L2Request *request) > >> { > >> return m2m_->capture()->setControls(&ctrls, request); > >> -}; > >> +} > >> > >> /* ----------------------------------------------------------------------------- > >> * V4L2M2MConverter > >> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > >> index ca9e850..1437318 100644 > >> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > >> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > >> @@ -377,7 +377,6 @@ int RkISP1CameraData::loadTuningFile(const std::string &path) > >> const auto ¶ms = algo["Dewarp"]; > >> > >> canUseDewarper_ = true; > >> - Matrix<double, 3, 3> m; > >> DewarpParms dp; > >> if (params["cm"]) { > >> const auto &cm = params["cm"].get<Matrix<double, 3, 3>>();
2025. 12. 27. 14:47 keltezéssel, Laurent Pinchart írta: > On Sat, Dec 27, 2025 at 01:17:11PM +0000, Barnabás Pőcze wrote: >> 2025. 12. 27. 11:34 keltezéssel, Laurent Pinchart írta: >>> On Sat, Dec 27, 2025 at 06:40:40AM +0100, Johannes Schneider wrote: >>>> Building libcamera with clang raises some warnings-as-errors. >>> >>> None of those issues are present in the master branch. Are you by any >>> chance working with out-of-tree changes ? >>> >>>> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com> >>>> --- >>>> >>>> Hoi, >>>> >>>> you could/should consider compiling with clang too ;-) >>> >>> We do :-) Our CI pipeline compiles with different versions of gcc and >>> clang. See https://gitlab.freedesktop.org/camera/libcamera/-/jobs/89987029 >>> for instance. >> >> There should probably be newer clang there. libcamera hasn't been compile-able >> with newer clang for a while now (I have clang 21.1.6) and I get: >> >> -Werror,-Winconsistent-missing-override >> >> in multiple places. > > We could try to add a Debian Forky container, it ships clang 21. Ahh, never mind, false alarm. I had some local changes and ran into a somewhat peculiar behaviour of clang: if there are multiple overridden functions, and at least one of them is marked `override`, then it will warn about the ones without `override`, but if none of them are marked, then no warning will appear. > >>>> --- >>>> include/libcamera/internal/camera_sensor_helper.h | 2 +- >>>> src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +- >>>> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 - >>>> 3 files changed, 2 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/include/libcamera/internal/camera_sensor_helper.h b/include/libcamera/internal/camera_sensor_helper.h >>>> index 1e1e479..1b3217b 100644 >>>> --- a/include/libcamera/internal/camera_sensor_helper.h >>>> +++ b/include/libcamera/internal/camera_sensor_helper.h >>>> @@ -61,7 +61,7 @@ public: >>>> >>>> static std::vector<CameraSensorHelperFactoryBase *> &factories(); >>>> >>>> - const std::string &name() const { return name_; }; >>>> + const std::string &name() const { return name_; } >>>> >>>> private: >>>> LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase) >>>> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp >>>> index d6b95fb..368320f 100644 >>>> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp >>>> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp >>>> @@ -258,7 +258,7 @@ int V4L2M2MConverter::V4L2M2MStream::applyControls(ControlList &ctrls, >>>> const V4L2Request *request) >>>> { >>>> return m2m_->capture()->setControls(&ctrls, request); >>>> -}; >>>> +} >>>> >>>> /* ----------------------------------------------------------------------------- >>>> * V4L2M2MConverter >>>> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp >>>> index ca9e850..1437318 100644 >>>> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp >>>> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp >>>> @@ -377,7 +377,6 @@ int RkISP1CameraData::loadTuningFile(const std::string &path) >>>> const auto ¶ms = algo["Dewarp"]; >>>> >>>> canUseDewarper_ = true; >>>> - Matrix<double, 3, 3> m; >>>> DewarpParms dp; >>>> if (params["cm"]) { >>>> const auto &cm = params["cm"].get<Matrix<double, 3, 3>>(); > > -- > Regards, > > Laurent Pinchart
diff --git a/include/libcamera/internal/camera_sensor_helper.h b/include/libcamera/internal/camera_sensor_helper.h index 1e1e479..1b3217b 100644 --- a/include/libcamera/internal/camera_sensor_helper.h +++ b/include/libcamera/internal/camera_sensor_helper.h @@ -61,7 +61,7 @@ public: static std::vector<CameraSensorHelperFactoryBase *> &factories(); - const std::string &name() const { return name_; }; + const std::string &name() const { return name_; } private: LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase) diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp index d6b95fb..368320f 100644 --- a/src/libcamera/converter/converter_v4l2_m2m.cpp +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp @@ -258,7 +258,7 @@ int V4L2M2MConverter::V4L2M2MStream::applyControls(ControlList &ctrls, const V4L2Request *request) { return m2m_->capture()->setControls(&ctrls, request); -}; +} /* ----------------------------------------------------------------------------- * V4L2M2MConverter diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index ca9e850..1437318 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -377,7 +377,6 @@ int RkISP1CameraData::loadTuningFile(const std::string &path) const auto ¶ms = algo["Dewarp"]; canUseDewarper_ = true; - Matrix<double, 3, 3> m; DewarpParms dp; if (params["cm"]) { const auto &cm = params["cm"].get<Matrix<double, 3, 3>>();
Building libcamera with clang raises some warnings-as-errors. Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com> --- Hoi, you could/should consider compiling with clang too ;-) gruß Johannes --- include/libcamera/internal/camera_sensor_helper.h | 2 +- src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) -- 2.43.0