[v2,0/2] RPi: Internal buffer alloaction rework
mbox series

Message ID 20251218123524.130886-1-naush@raspberrypi.com
Headers show
Series
  • RPi: Internal buffer alloaction rework
Related show

Message

Naushir Patuck Dec. 18, 2025, 12:31 p.m. UTC 
Hi,

No code changes in v2, only tags added.

Jacopo, I thought it would be a trival change to address your comment regarding
calling importBuffers() unconditionally for disabled nodes. Turns out it's not,
and will need a bit of quite annoying plumbing since the base pipeline handler
class knows nothing about TDN and Sitch device nodes which are PiSP specific.
In the interest of getting this merged quickly I suggest we keep this as-is as
the unconditional call only does allocation of v4l2 slots, so is not a big deal.
If you are ok with that, we can go ahead and merge this.

Regards,
Naush

Naushir Patuck (2):
  pipeline: rpi: Rename Stream::prepareBuffers to
    Stream::allocateBuffers
  pipeline: rpi: Rework internal buffer allocations

 .../pipeline/rpi/common/pipeline_base.cpp     | 10 ++++++--
 .../pipeline/rpi/common/pipeline_base.h       |  2 +-
 .../pipeline/rpi/common/rpi_stream.cpp        | 25 ++++++-------------
 .../pipeline/rpi/common/rpi_stream.h          |  3 +--
 src/libcamera/pipeline/rpi/pisp/pisp.cpp      |  6 ++---
 src/libcamera/pipeline/rpi/vc4/vc4.cpp        |  6 ++---
 6 files changed, 24 insertions(+), 28 deletions(-)

Comments

Jacopo Mondi Dec. 18, 2025, 4:38 p.m. UTC | #1 
Hi Naush

On Thu, Dec 18, 2025 at 12:31:22PM +0000, Naushir Patuck wrote:
> Hi,
>
> No code changes in v2, only tags added.
>
> Jacopo, I thought it would be a trival change to address your comment regarding
> calling importBuffers() unconditionally for disabled nodes. Turns out it's not,
> and will need a bit of quite annoying plumbing since the base pipeline handler
> class knows nothing about TDN and Sitch device nodes which are PiSP specific.
> In the interest of getting this merged quickly I suggest we keep this as-is as
> the unconditional call only does allocation of v4l2 slots, so is not a big deal.
> If you are ok with that, we can go ahead and merge this.

Absolutely, I pointed it out just to check if it was intentional or
not, but if you're fine, I am as well!

>
> Regards,
> Naush
>
> Naushir Patuck (2):
>   pipeline: rpi: Rename Stream::prepareBuffers to
>     Stream::allocateBuffers
>   pipeline: rpi: Rework internal buffer allocations
>
>  .../pipeline/rpi/common/pipeline_base.cpp     | 10 ++++++--
>  .../pipeline/rpi/common/pipeline_base.h       |  2 +-
>  .../pipeline/rpi/common/rpi_stream.cpp        | 25 ++++++-------------
>  .../pipeline/rpi/common/rpi_stream.h          |  3 +--
>  src/libcamera/pipeline/rpi/pisp/pisp.cpp      |  6 ++---
>  src/libcamera/pipeline/rpi/vc4/vc4.cpp        |  6 ++---
>  6 files changed, 24 insertions(+), 28 deletions(-)
>
> --
> 2.51.0
>