| Message ID | 20251210-headers-update-v6-18-v2-0-3f726742a4c8@ideasonboard.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi Jacopo, Thank you for the patch. On Wed, Dec 10, 2025 at 09:19:11AM +0100, Jacopo Mondi wrote: > Update Linux headers to the Linux v6.18 LTS release using the > utils/update-kernel-headers.sh script. > > A few downstream symbols conflict with newly added ones in mainline. > > The symbols used from drm_fourcc have been kept even if they conflict > with newly added symbols in mainline. > > The only remaining ABI-breaking change is now in videodev2.h > -#define MEDIA_BUS_FMT_RGB202020_1X60 0x1026 > +#define MEDIA_BUS_FMT_RGB202020_1X60 0x1029 > > This is however justified, as we defined RGB202020_1X60 downstream > before it got mainlined. The symbols will land in v6.19 with the > Mali C55 ISP driver with a value of 0x1029, so this change actually > aligns the libcamera definition with the forthcoming ones in Linux. This won't break the libcamera ABI as media bus codes are not exposed to users. However, it may cause issues if someone uses libcamera with an older kernel (with the out-of-tree C55 ISP kernel driver), or the other way around. That's likely unavoidable, but I wonder if we could improve the user experience with a clear error message. Should we update the C55 pipeline handler to log an error for kernels older than v6.19 ? > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > Changes in v2: > - Do not change the definition of drm_fourcc downstream symbols > - Add tags > > --- > Jacopo Mondi (6): > include: linux: drm_fourcc.h: Update to v6.18 > include: linux: intel-ipu3.h: Update to v6.18 > include: linux: media-bus-format.h: Update to v6.18 > include: linux: v4l2-controls.h: Update to v6.18 > include: linux: videodev2.h: Update to v6.18 > include: linux: README: Update to Linux v6.18 > > include/linux/README | 2 +- > include/linux/drm_fourcc.h | 191 ++++++++++++++++++++++++++++++++++++--- > include/linux/intel-ipu3.h | 3 +- > include/linux/media-bus-format.h | 6 +- > include/linux/v4l2-controls.h | 128 +++++++++++++------------- > include/linux/videodev2.h | 64 +++++++++---- > 6 files changed, 300 insertions(+), 94 deletions(-) > --- > base-commit: 0a9cf7e0eb6aafcfaeda4c5774fb04db9186430d > change-id: 20251204-headers-update-v6-18-e7b7dc8375b2
Quoting Laurent Pinchart (2025-12-11 01:33:27) > Hi Jacopo, > > Thank you for the patch. > > On Wed, Dec 10, 2025 at 09:19:11AM +0100, Jacopo Mondi wrote: > > Update Linux headers to the Linux v6.18 LTS release using the > > utils/update-kernel-headers.sh script. > > > > A few downstream symbols conflict with newly added ones in mainline. > > > > The symbols used from drm_fourcc have been kept even if they conflict > > with newly added symbols in mainline. > > > > The only remaining ABI-breaking change is now in videodev2.h > > -#define MEDIA_BUS_FMT_RGB202020_1X60 0x1026 > > +#define MEDIA_BUS_FMT_RGB202020_1X60 0x1029 > > > > This is however justified, as we defined RGB202020_1X60 downstream > > before it got mainlined. The symbols will land in v6.19 with the > > Mali C55 ISP driver with a value of 0x1029, so this change actually > > aligns the libcamera definition with the forthcoming ones in Linux. > > This won't break the libcamera ABI as media bus codes are not exposed to > users. However, it may cause issues if someone uses libcamera with an > older kernel (with the out-of-tree C55 ISP kernel driver), or the other > way around. That's likely unavoidable, but I wonder if we could improve > the user experience with a clear error message. Should we update the C55 > pipeline handler to log an error for kernels older than v6.19 ? While we should definitely keep an eye on this, I don't think we need custom code adding - as the number of users on this platform are currently very low as support is not fully released yet, and the Mali-C55 driver itself only lands in v6.19. I don't think we need to support out-of-tree pre-releases here. > > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > --- > > Changes in v2: > > - Do not change the definition of drm_fourcc downstream symbols > > - Add tags > > > > --- > > Jacopo Mondi (6): > > include: linux: drm_fourcc.h: Update to v6.18 > > include: linux: intel-ipu3.h: Update to v6.18 > > include: linux: media-bus-format.h: Update to v6.18 > > include: linux: v4l2-controls.h: Update to v6.18 > > include: linux: videodev2.h: Update to v6.18 > > include: linux: README: Update to Linux v6.18 > > > > include/linux/README | 2 +- > > include/linux/drm_fourcc.h | 191 ++++++++++++++++++++++++++++++++++++--- > > include/linux/intel-ipu3.h | 3 +- > > include/linux/media-bus-format.h | 6 +- > > include/linux/v4l2-controls.h | 128 +++++++++++++------------- > > include/linux/videodev2.h | 64 +++++++++---- > > 6 files changed, 300 insertions(+), 94 deletions(-) > > --- > > base-commit: 0a9cf7e0eb6aafcfaeda4c5774fb04db9186430d > > change-id: 20251204-headers-update-v6-18-e7b7dc8375b2 > > -- > Regards, > > Laurent Pinchart
On Thu, Dec 11, 2025 at 09:08:39AM +0000, Kieran Bingham wrote: > Quoting Laurent Pinchart (2025-12-11 01:33:27) > > Hi Jacopo, > > > > Thank you for the patch. > > > > On Wed, Dec 10, 2025 at 09:19:11AM +0100, Jacopo Mondi wrote: > > > Update Linux headers to the Linux v6.18 LTS release using the > > > utils/update-kernel-headers.sh script. > > > > > > A few downstream symbols conflict with newly added ones in mainline. > > > > > > The symbols used from drm_fourcc have been kept even if they conflict > > > with newly added symbols in mainline. > > > > > > The only remaining ABI-breaking change is now in videodev2.h > > > -#define MEDIA_BUS_FMT_RGB202020_1X60 0x1026 > > > +#define MEDIA_BUS_FMT_RGB202020_1X60 0x1029 > > > > > > This is however justified, as we defined RGB202020_1X60 downstream > > > before it got mainlined. The symbols will land in v6.19 with the > > > Mali C55 ISP driver with a value of 0x1029, so this change actually > > > aligns the libcamera definition with the forthcoming ones in Linux. > > > > This won't break the libcamera ABI as media bus codes are not exposed to > > users. However, it may cause issues if someone uses libcamera with an > > older kernel (with the out-of-tree C55 ISP kernel driver), or the other > > way around. That's likely unavoidable, but I wonder if we could improve > > the user experience with a clear error message. Should we update the C55 > > pipeline handler to log an error for kernels older than v6.19 ? > > While we should definitely keep an eye on this, I don't think we need > custom code adding - as the number of users on this platform are > currently very low as support is not fully released yet, and the > Mali-C55 driver itself only lands in v6.19. I don't think we need to > support out-of-tree pre-releases here. > I share Kieran's opinion here. The Mali C55 support is not even complete upstream libcamera yet, so it really requires some effort and customization to be used. This doesn't mean we should intentionally make things complicated for users, but we can't guarantee compatibility between out-of-tree components of libcamera/linux. > > > > > > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > > --- > > > Changes in v2: > > > - Do not change the definition of drm_fourcc downstream symbols > > > - Add tags > > > > > > --- > > > Jacopo Mondi (6): > > > include: linux: drm_fourcc.h: Update to v6.18 > > > include: linux: intel-ipu3.h: Update to v6.18 > > > include: linux: media-bus-format.h: Update to v6.18 > > > include: linux: v4l2-controls.h: Update to v6.18 > > > include: linux: videodev2.h: Update to v6.18 > > > include: linux: README: Update to Linux v6.18 > > > > > > include/linux/README | 2 +- > > > include/linux/drm_fourcc.h | 191 ++++++++++++++++++++++++++++++++++++--- > > > include/linux/intel-ipu3.h | 3 +- > > > include/linux/media-bus-format.h | 6 +- > > > include/linux/v4l2-controls.h | 128 +++++++++++++------------- > > > include/linux/videodev2.h | 64 +++++++++---- > > > 6 files changed, 300 insertions(+), 94 deletions(-) > > > --- > > > base-commit: 0a9cf7e0eb6aafcfaeda4c5774fb04db9186430d > > > change-id: 20251204-headers-update-v6-18-e7b7dc8375b2 > > > > -- > > Regards, > > > > Laurent Pinchart
On Thu, Dec 11, 2025 at 10:17:38AM +0100, Jacopo Mondi wrote: > On Thu, Dec 11, 2025 at 09:08:39AM +0000, Kieran Bingham wrote: > > Quoting Laurent Pinchart (2025-12-11 01:33:27) > > > Hi Jacopo, > > > > > > Thank you for the patch. > > > > > > On Wed, Dec 10, 2025 at 09:19:11AM +0100, Jacopo Mondi wrote: > > > > Update Linux headers to the Linux v6.18 LTS release using the > > > > utils/update-kernel-headers.sh script. > > > > > > > > A few downstream symbols conflict with newly added ones in mainline. > > > > > > > > The symbols used from drm_fourcc have been kept even if they conflict > > > > with newly added symbols in mainline. > > > > > > > > The only remaining ABI-breaking change is now in videodev2.h > > > > -#define MEDIA_BUS_FMT_RGB202020_1X60 0x1026 > > > > +#define MEDIA_BUS_FMT_RGB202020_1X60 0x1029 > > > > > > > > This is however justified, as we defined RGB202020_1X60 downstream > > > > before it got mainlined. The symbols will land in v6.19 with the > > > > Mali C55 ISP driver with a value of 0x1029, so this change actually > > > > aligns the libcamera definition with the forthcoming ones in Linux. > > > > > > This won't break the libcamera ABI as media bus codes are not exposed to > > > users. However, it may cause issues if someone uses libcamera with an > > > older kernel (with the out-of-tree C55 ISP kernel driver), or the other > > > way around. That's likely unavoidable, but I wonder if we could improve > > > the user experience with a clear error message. Should we update the C55 > > > pipeline handler to log an error for kernels older than v6.19 ? > > > > While we should definitely keep an eye on this, I don't think we need > > custom code adding - as the number of users on this platform are > > currently very low as support is not fully released yet, and the > > Mali-C55 driver itself only lands in v6.19. I don't think we need to > > support out-of-tree pre-releases here. > > I share Kieran's opinion here. > > The Mali C55 support is not even complete upstream libcamera yet, so > it really requires some effort and customization to be used. This > doesn't mean we should intentionally make things complicated for > users, but we can't guarantee compatibility between out-of-tree > components of libcamera/linux. OK, I'm fine with that. > > > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > > > --- > > > > Changes in v2: > > > > - Do not change the definition of drm_fourcc downstream symbols > > > > - Add tags > > > > > > > > --- > > > > Jacopo Mondi (6): > > > > include: linux: drm_fourcc.h: Update to v6.18 > > > > include: linux: intel-ipu3.h: Update to v6.18 > > > > include: linux: media-bus-format.h: Update to v6.18 > > > > include: linux: v4l2-controls.h: Update to v6.18 > > > > include: linux: videodev2.h: Update to v6.18 > > > > include: linux: README: Update to Linux v6.18 > > > > > > > > include/linux/README | 2 +- > > > > include/linux/drm_fourcc.h | 191 ++++++++++++++++++++++++++++++++++++--- > > > > include/linux/intel-ipu3.h | 3 +- > > > > include/linux/media-bus-format.h | 6 +- > > > > include/linux/v4l2-controls.h | 128 +++++++++++++------------- > > > > include/linux/videodev2.h | 64 +++++++++---- > > > > 6 files changed, 300 insertions(+), 94 deletions(-) > > > > --- > > > > base-commit: 0a9cf7e0eb6aafcfaeda4c5774fb04db9186430d > > > > change-id: 20251204-headers-update-v6-18-e7b7dc8375b2
Update Linux headers to the Linux v6.18 LTS release using the utils/update-kernel-headers.sh script. A few downstream symbols conflict with newly added ones in mainline. The symbols used from drm_fourcc have been kept even if they conflict with newly added symbols in mainline. The only remaining ABI-breaking change is now in videodev2.h -#define MEDIA_BUS_FMT_RGB202020_1X60 0x1026 +#define MEDIA_BUS_FMT_RGB202020_1X60 0x1029 This is however justified, as we defined RGB202020_1X60 downstream before it got mainlined. The symbols will land in v6.19 with the Mali C55 ISP driver with a value of 0x1029, so this change actually aligns the libcamera definition with the forthcoming ones in Linux. Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> --- Changes in v2: - Do not change the definition of drm_fourcc downstream symbols - Add tags --- Jacopo Mondi (6): include: linux: drm_fourcc.h: Update to v6.18 include: linux: intel-ipu3.h: Update to v6.18 include: linux: media-bus-format.h: Update to v6.18 include: linux: v4l2-controls.h: Update to v6.18 include: linux: videodev2.h: Update to v6.18 include: linux: README: Update to Linux v6.18 include/linux/README | 2 +- include/linux/drm_fourcc.h | 191 ++++++++++++++++++++++++++++++++++++--- include/linux/intel-ipu3.h | 3 +- include/linux/media-bus-format.h | 6 +- include/linux/v4l2-controls.h | 128 +++++++++++++------------- include/linux/videodev2.h | 64 +++++++++---- 6 files changed, 300 insertions(+), 94 deletions(-) --- base-commit: 0a9cf7e0eb6aafcfaeda4c5774fb04db9186430d change-id: 20251204-headers-update-v6-18-e7b7dc8375b2 Best regards,