| Message ID | 20251210005354.44726-14-bryan.odonoghue@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes: > We will be initialising eGL from Debayer::start(). We need a copy of the > size data passed in configure() to tell the fragment shaders the right > output size. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> I'm not sure these patches are worth to be standalone instead of squashed to the places where the variables are used but anyway: Reviewed-by: Milan Zamazal <mzamazal@redhat.com> > --- > src/libcamera/software_isp/debayer.cpp | 5 +++++ > src/libcamera/software_isp/debayer.h | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp > index ebd3e3a8b..4e7b61d6b 100644 > --- a/src/libcamera/software_isp/debayer.cpp > +++ b/src/libcamera/software_isp/debayer.cpp > @@ -300,6 +300,11 @@ Debayer::~Debayer() > * \brief The output pixel format. > */ > > +/** > + * \var Debayer::outputSize_ > + * \brief Output size object > + */ > + > /** > * \var Debayer::red_ > * \brief Lookup table for red channel gain and correction values. > diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h > index 4a2ec3e53..189b32930 100644 > --- a/src/libcamera/software_isp/debayer.h > +++ b/src/libcamera/software_isp/debayer.h > @@ -75,6 +75,7 @@ public: > > DebayerInputConfig inputConfig_; > DebayerOutputConfig outputConfig_; > + Size outputSize_; > PixelFormat inputPixelFormat_; > PixelFormat outputPixelFormat_; > DebayerParams::LookupTable red_;
diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp index ebd3e3a8b..4e7b61d6b 100644 --- a/src/libcamera/software_isp/debayer.cpp +++ b/src/libcamera/software_isp/debayer.cpp @@ -300,6 +300,11 @@ Debayer::~Debayer() * \brief The output pixel format. */ +/** + * \var Debayer::outputSize_ + * \brief Output size object + */ + /** * \var Debayer::red_ * \brief Lookup table for red channel gain and correction values. diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h index 4a2ec3e53..189b32930 100644 --- a/src/libcamera/software_isp/debayer.h +++ b/src/libcamera/software_isp/debayer.h @@ -75,6 +75,7 @@ public: DebayerInputConfig inputConfig_; DebayerOutputConfig outputConfig_; + Size outputSize_; PixelFormat inputPixelFormat_; PixelFormat outputPixelFormat_; DebayerParams::LookupTable red_;
We will be initialising eGL from Debayer::start(). We need a copy of the size data passed in configure() to tell the fragment shaders the right output size. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- src/libcamera/software_isp/debayer.cpp | 5 +++++ src/libcamera/software_isp/debayer.h | 1 + 2 files changed, 6 insertions(+)