| Message ID | 20251128154832.176864-1-jacopo.mondi@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Quoting Jacopo Mondi (2025-11-28 15:48:30) > The Wdr controls have been added without an empty line between them and the > existing ones. Also, a line has a space at the end. > > Fix it. > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > src/libcamera/control_ids_core.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml > index 3bcb475fd102..8e99bd84825f 100644 > --- a/src/libcamera/control_ids_core.yaml > +++ b/src/libcamera/control_ids_core.yaml > @@ -677,7 +677,7 @@ controls: > stored in conventional reading order in an array of 9 floating point > values. > > - ColourCorrectionMatrix can only be applied in a Request when the AWB is > + ColourCorrectionMatrix can only be applied in a Request when the AWB is > disabled. Maybe it's just my email client but I can't see any change in the hunk above. But anyway, Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > \sa AwbEnable > @@ -1283,6 +1283,7 @@ controls: > \sa SensorTimestamp > > The FrameWallClock control can only be returned in metadata. > + > - WdrMode: > type: int32_t > direction: inout > @@ -1329,6 +1330,7 @@ controls: > This curve preserves most of the information of the image at the > expense of a very artificial look. It is therefore best suited for > technical analysis. > + > - WdrStrength: > type: float > direction: in > @@ -1338,6 +1340,7 @@ controls: > global tone mapping is applied. A values of 1 is the default value and > the correct value for most scenes. A value above 1 increases the global > tone mapping effect and can lead to unrealistic image effects. > + > - WdrMaxBrightPixels: > type: float > direction: in > -- > 2.51.1 >
Hi Kieran On Sat, Nov 29, 2025 at 01:35:40PM +0000, Kieran Bingham wrote: > Quoting Jacopo Mondi (2025-11-28 15:48:30) > > The Wdr controls have been added without an empty line between them and the > > existing ones. Also, a line has a space at the end. > > > > Fix it. > > > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > --- > > src/libcamera/control_ids_core.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml > > index 3bcb475fd102..8e99bd84825f 100644 > > --- a/src/libcamera/control_ids_core.yaml > > +++ b/src/libcamera/control_ids_core.yaml > > @@ -677,7 +677,7 @@ controls: > > stored in conventional reading order in an array of 9 floating point > > values. > > > > - ColourCorrectionMatrix can only be applied in a Request when the AWB is > > + ColourCorrectionMatrix can only be applied in a Request when the AWB is > > disabled. > > Maybe it's just my email client but I can't see any change in the hunk > above. As reported in the commit message "a line has a space at the end". My editor removes them automatically, but they don't show up in the changelog, you're right! > > But anyway, > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > > \sa AwbEnable > > @@ -1283,6 +1283,7 @@ controls: > > \sa SensorTimestamp > > > > The FrameWallClock control can only be returned in metadata. > > + > > - WdrMode: > > type: int32_t > > direction: inout > > @@ -1329,6 +1330,7 @@ controls: > > This curve preserves most of the information of the image at the > > expense of a very artificial look. It is therefore best suited for > > technical analysis. > > + > > - WdrStrength: > > type: float > > direction: in > > @@ -1338,6 +1340,7 @@ controls: > > global tone mapping is applied. A values of 1 is the default value and > > the correct value for most scenes. A value above 1 increases the global > > tone mapping effect and can lead to unrealistic image effects. > > + > > - WdrMaxBrightPixels: > > type: float > > direction: in > > -- > > 2.51.1 > >
2025. 11. 28. 16:48 keltezéssel, Jacopo Mondi írta: > The Wdr controls have been added without an empty line between them and the > existing ones. Also, a line has a space at the end. > > Fix it. > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > src/libcamera/control_ids_core.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml > index 3bcb475fd102..8e99bd84825f 100644 > --- a/src/libcamera/control_ids_core.yaml > +++ b/src/libcamera/control_ids_core.yaml > @@ -677,7 +677,7 @@ controls: > stored in conventional reading order in an array of 9 floating point > values. > > - ColourCorrectionMatrix can only be applied in a Request when the AWB is > + ColourCorrectionMatrix can only be applied in a Request when the AWB is > disabled. > > \sa AwbEnable > @@ -1283,6 +1283,7 @@ controls: > \sa SensorTimestamp > > The FrameWallClock control can only be returned in metadata. > + > - WdrMode: > type: int32_t > direction: inout > @@ -1329,6 +1330,7 @@ controls: > This curve preserves most of the information of the image at the > expense of a very artificial look. It is therefore best suited for > technical analysis. > + > - WdrStrength: > type: float > direction: in > @@ -1338,6 +1340,7 @@ controls: > global tone mapping is applied. A values of 1 is the default value and > the correct value for most scenes. A value above 1 increases the global > tone mapping effect and can lead to unrealistic image effects. > + > - WdrMaxBrightPixels: > type: float > direction: in > -- > 2.51.1 >
diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml index 3bcb475fd102..8e99bd84825f 100644 --- a/src/libcamera/control_ids_core.yaml +++ b/src/libcamera/control_ids_core.yaml @@ -677,7 +677,7 @@ controls: stored in conventional reading order in an array of 9 floating point values. - ColourCorrectionMatrix can only be applied in a Request when the AWB is + ColourCorrectionMatrix can only be applied in a Request when the AWB is disabled. \sa AwbEnable @@ -1283,6 +1283,7 @@ controls: \sa SensorTimestamp The FrameWallClock control can only be returned in metadata. + - WdrMode: type: int32_t direction: inout @@ -1329,6 +1330,7 @@ controls: This curve preserves most of the information of the image at the expense of a very artificial look. It is therefore best suited for technical analysis. + - WdrStrength: type: float direction: in @@ -1338,6 +1340,7 @@ controls: global tone mapping is applied. A values of 1 is the default value and the correct value for most scenes. A value above 1 increases the global tone mapping effect and can lead to unrealistic image effects. + - WdrMaxBrightPixels: type: float direction: in
The Wdr controls have been added without an empty line between them and the existing ones. Also, a line has a space at the end. Fix it. Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> --- src/libcamera/control_ids_core.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.51.1