[v3,08/19] ipa: libipa: agc: Remove unused accessors

25060 diff mbox series

Remove unused accessors. They're not only unused but it is not even
clear what the purpose of accessing the fields is.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 src/ipa/libipa/exposure_mode_helper.cpp | 25 -------------------------
 src/ipa/libipa/exposure_mode_helper.h   |  5 -----
 2 files changed, 30 deletions(-)

2025. 11. 14. 15:17 keltezéssel, Jacopo Mondi írta:
> Remove unused accessors. They're not only unused but it is not even
> clear what the purpose of accessing the fields is.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>


>   src/ipa/libipa/exposure_mode_helper.cpp | 25 -------------------------
>   src/ipa/libipa/exposure_mode_helper.h   |  5 -----
>   2 files changed, 30 deletions(-)
> 
> diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp
> index 29e316d9d09181cd65cb08f26babb1a680bee62a..962ce1b1b7503e0f86f3857b484b249cb6383fde 100644
> --- a/src/ipa/libipa/exposure_mode_helper.cpp
> +++ b/src/ipa/libipa/exposure_mode_helper.cpp
> @@ -266,31 +266,6 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const
>   		 exposure / (exposureTime * gain * quantGain) };
>   }
>   
> -/**
> - * \fn ExposureModeHelper::minExposureTime()
> - * \brief Retrieve the configured minimum exposure time limit set through
> - * setLimits()
> - * \return The minExposureTime_ value
> - */
> -
> -/**
> - * \fn ExposureModeHelper::maxExposureTime()
> - * \brief Retrieve the configured maximum exposure time set through setLimits()
> - * \return The maxExposureTime_ value
> - */
> -
> -/**
> - * \fn ExposureModeHelper::minGain()
> - * \brief Retrieve the configured minimum gain set through setLimits()
> - * \return The minGain_ value
> - */
> -
> -/**
> - * \fn ExposureModeHelper::maxGain()
> - * \brief Retrieve the configured maximum gain set through setLimits()
> - * \return The maxGain_ value
> - */
> -
>   } /* namespace ipa */
>   
>   } /* namespace libcamera */
> diff --git a/src/ipa/libipa/exposure_mode_helper.h b/src/ipa/libipa/exposure_mode_helper.h
> index 968192ddc5af768ae0de58aca6c7230c7b3bd507..f8b7a4aa4800b59459f8fc80f502b83647547f51 100644
> --- a/src/ipa/libipa/exposure_mode_helper.h
> +++ b/src/ipa/libipa/exposure_mode_helper.h
> @@ -33,11 +33,6 @@ public:
>   	std::tuple<utils::Duration, double, double, double>
>   	splitExposure(utils::Duration exposure) const;
>   
> -	utils::Duration minExposureTime() const { return minExposureTime_; }
> -	utils::Duration maxExposureTime() const { return maxExposureTime_; }
> -	double minGain() const { return minGain_; }
> -	double maxGain() const { return maxGain_; }
> -
>   private:
>   	utils::Duration clampExposureTime(utils::Duration exposureTime,
>   					  double *quantizationGain = nullptr) const;
>

On Fri, Nov 14, 2025 at 03:17:03PM +0100, Jacopo Mondi wrote:
> Remove unused accessors. They're not only unused but it is not even
> clear what the purpose of accessing the fields is.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/ipa/libipa/exposure_mode_helper.cpp | 25 -------------------------
>  src/ipa/libipa/exposure_mode_helper.h   |  5 -----
>  2 files changed, 30 deletions(-)
> 
> diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp
> index 29e316d9d09181cd65cb08f26babb1a680bee62a..962ce1b1b7503e0f86f3857b484b249cb6383fde 100644
> --- a/src/ipa/libipa/exposure_mode_helper.cpp
> +++ b/src/ipa/libipa/exposure_mode_helper.cpp
> @@ -266,31 +266,6 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const
>  		 exposure / (exposureTime * gain * quantGain) };
>  }
>  
> -/**
> - * \fn ExposureModeHelper::minExposureTime()
> - * \brief Retrieve the configured minimum exposure time limit set through
> - * setLimits()
> - * \return The minExposureTime_ value
> - */
> -
> -/**
> - * \fn ExposureModeHelper::maxExposureTime()
> - * \brief Retrieve the configured maximum exposure time set through setLimits()
> - * \return The maxExposureTime_ value
> - */
> -
> -/**
> - * \fn ExposureModeHelper::minGain()
> - * \brief Retrieve the configured minimum gain set through setLimits()
> - * \return The minGain_ value
> - */
> -
> -/**
> - * \fn ExposureModeHelper::maxGain()
> - * \brief Retrieve the configured maximum gain set through setLimits()
> - * \return The maxGain_ value
> - */
> -
>  } /* namespace ipa */
>  
>  } /* namespace libcamera */
> diff --git a/src/ipa/libipa/exposure_mode_helper.h b/src/ipa/libipa/exposure_mode_helper.h
> index 968192ddc5af768ae0de58aca6c7230c7b3bd507..f8b7a4aa4800b59459f8fc80f502b83647547f51 100644
> --- a/src/ipa/libipa/exposure_mode_helper.h
> +++ b/src/ipa/libipa/exposure_mode_helper.h
> @@ -33,11 +33,6 @@ public:
>  	std::tuple<utils::Duration, double, double, double>
>  	splitExposure(utils::Duration exposure) const;
>  
> -	utils::Duration minExposureTime() const { return minExposureTime_; }
> -	utils::Duration maxExposureTime() const { return maxExposureTime_; }
> -	double minGain() const { return minGain_; }
> -	double maxGain() const { return maxGain_; }
> -
>  private:
>  	utils::Duration clampExposureTime(utils::Duration exposureTime,
>  					  double *quantizationGain = nullptr) const;