| Message ID | 20251023144841.403689-17-stefan.klug@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Quoting Stefan Klug (2025-10-23 23:48:17) > When the dewarper is present, there is no need to forbid upscaling of > the image data. > > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > --- > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > index 46bc81f2483c..77442b25b809 100644 > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > @@ -614,6 +614,11 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate() > return false; > > if (useDewarper) { > + /* > + * The dewarper output is independent of the ISP path. > + * Reset to the originally requested size. > + */ > + tryCfg.size = cfg.size; > bool adjusted; > > pipe->dewarper_->validateOutput(&tryCfg, &adjusted, > -- > 2.48.1 >
diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 46bc81f2483c..77442b25b809 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -614,6 +614,11 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate() return false; if (useDewarper) { + /* + * The dewarper output is independent of the ISP path. + * Reset to the originally requested size. + */ + tryCfg.size = cfg.size; bool adjusted; pipe->dewarper_->validateOutput(&tryCfg, &adjusted,
When the dewarper is present, there is no need to forbid upscaling of the image data. Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++ 1 file changed, 5 insertions(+)