[1/5] ipa: rpi: Fix the set function for floating statistics regions
diff mbox series

Message ID 20251017102704.3887-2-david.plowman@raspberrypi.com
State Accepted
Headers show
Series
  • Fix and improve full image Y statistics
Related show

Commit Message

David Plowman Oct. 17, 2025, 10:05 a.m. UTC 
Previously it was calling the wrong internal function which would do
nothing.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
---
 src/ipa/rpi/controller/region_stats.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Klug Oct. 20, 2025, 9:41 a.m. UTC | #1 
Hi David,

Quoting David Plowman (2025-10-17 12:05:37)
> Previously it was calling the wrong internal function which would do
> nothing.
> 
> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>

Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>

Cheers,
Stefan

> ---
>  src/ipa/rpi/controller/region_stats.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/rpi/controller/region_stats.h b/src/ipa/rpi/controller/region_stats.h
> index c60f7d9a..0f8c276a 100644
> --- a/src/ipa/rpi/controller/region_stats.h
> +++ b/src/ipa/rpi/controller/region_stats.h
> @@ -76,7 +76,7 @@ public:
>         {
>                 if (index >= numFloatingRegions())
>                         return;
> -               set(numRegions() + index, region);
> +               set_(numRegions() + index, region);
>         }
>  
>         const Region &get(unsigned int index) const
> -- 
> 2.47.3
>
Naushir Patuck Oct. 23, 2025, 7:24 a.m. UTC | #2 
Hi David,


On Fri, 17 Oct 2025 at 11:27, David Plowman <david.plowman@raspberrypi.com>
wrote:

> Previously it was calling the wrong internal function which would do
> nothing.
>
> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
>

Reviewed-by: Naushir Patuck <naush@raspberrypi.com>


> ---
>  src/ipa/rpi/controller/region_stats.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ipa/rpi/controller/region_stats.h
> b/src/ipa/rpi/controller/region_stats.h
> index c60f7d9a..0f8c276a 100644
> --- a/src/ipa/rpi/controller/region_stats.h
> +++ b/src/ipa/rpi/controller/region_stats.h
> @@ -76,7 +76,7 @@ public:
>         {
>                 if (index >= numFloatingRegions())
>                         return;
> -               set(numRegions() + index, region);
> +               set_(numRegions() + index, region);
>         }
>
>         const Region &get(unsigned int index) const
> --
> 2.47.3
>
>

Patch
diff mbox series 

diff --git a/src/ipa/rpi/controller/region_stats.h b/src/ipa/rpi/controller/region_stats.h
index c60f7d9a..0f8c276a 100644
--- a/src/ipa/rpi/controller/region_stats.h
+++ b/src/ipa/rpi/controller/region_stats.h
@@ -76,7 +76,7 @@  public:
 	{
 		if (index >= numFloatingRegions())
 			return;
-		set(numRegions() + index, region);
+		set_(numRegions() + index, region);
 	}
 
 	const Region &get(unsigned int index) const