| Message ID | 20251015012251.17508-39-bryan.odonoghue@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Quoting Bryan O'Donoghue (2025-10-15 02:22:50) > As a validation step switch on uncalibrated CCM. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> I think we've discussed that this one would get dropped and GPU ISP will always default to an identity matrix for CCM. > --- > src/ipa/simple/data/uncalibrated.yaml | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml > index 5508e668..8b6df9af 100644 > --- a/src/ipa/simple/data/uncalibrated.yaml > +++ b/src/ipa/simple/data/uncalibrated.yaml > @@ -8,12 +8,12 @@ algorithms: > # Color correction matrices can be defined here. The CCM algorithm > # has a significant performance impact, and should only be enabled > # if tuned. > - # - Ccm: > - # ccms: > - # - ct: 6500 > - # ccm: [ 1, 0, 0, > - # 0, 1, 0, > - # 0, 0, 1] > + - Ccm: > + ccms: > + - ct: 6500 > + ccm: [ 1, 0, 0, > + 0, 1, 0, > + 0, 0, 1] > - Lut: > - Agc: > ... > -- > 2.51.0 >
Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes: > As a validation step switch on uncalibrated CCM. With this, I can reproduce the problem with darker output, as discussed yesterday at the sync. I'll look at it. I'm done with reviewing the v3 for now. > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > src/ipa/simple/data/uncalibrated.yaml | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml > index 5508e668..8b6df9af 100644 > --- a/src/ipa/simple/data/uncalibrated.yaml > +++ b/src/ipa/simple/data/uncalibrated.yaml > @@ -8,12 +8,12 @@ algorithms: > # Color correction matrices can be defined here. The CCM algorithm > # has a significant performance impact, and should only be enabled > # if tuned. > - # - Ccm: > - # ccms: > - # - ct: 6500 > - # ccm: [ 1, 0, 0, > - # 0, 1, 0, > - # 0, 0, 1] > + - Ccm: > + ccms: > + - ct: 6500 > + ccm: [ 1, 0, 0, > + 0, 1, 0, > + 0, 0, 1] > - Lut: > - Agc: > ...
diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml index 5508e668..8b6df9af 100644 --- a/src/ipa/simple/data/uncalibrated.yaml +++ b/src/ipa/simple/data/uncalibrated.yaml @@ -8,12 +8,12 @@ algorithms: # Color correction matrices can be defined here. The CCM algorithm # has a significant performance impact, and should only be enabled # if tuned. - # - Ccm: - # ccms: - # - ct: 6500 - # ccm: [ 1, 0, 0, - # 0, 1, 0, - # 0, 0, 1] + - Ccm: + ccms: + - ct: 6500 + ccm: [ 1, 0, 0, + 0, 1, 0, + 0, 0, 1] - Lut: - Agc: ...
As a validation step switch on uncalibrated CCM. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- src/ipa/simple/data/uncalibrated.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)