[v3,19/39] libcamera: software_isp: debayer: Extend DebayerParams to hold a copy of per-frame AWB values
diff mbox series

Message ID 20251015012251.17508-20-bryan.odonoghue@linaro.org
State New
Headers show
Series
  • Add GLES 2.0 GPUISP to libcamera
Related show

Commit Message

Bryan O'Donoghue Oct. 15, 2025, 1:22 a.m. UTC 
Add a vector to allow the AWB gains calculated in the IPA to be fed back into
the Debayer shaders.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 include/libcamera/internal/software_isp/debayer_params.h | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Milan Zamazal Oct. 16, 2025, 9:14 a.m. UTC | #1 
Hi Bryan,

Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes:

> Add a vector to allow the AWB gains calculated in the IPA to be fed back into
> the Debayer shaders.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  include/libcamera/internal/software_isp/debayer_params.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h
> index 56803195..9d0a852d 100644
> --- a/include/libcamera/internal/software_isp/debayer_params.h
> +++ b/include/libcamera/internal/software_isp/debayer_params.h
> @@ -14,6 +14,7 @@
>  #include <stdint.h>
>  
>  #include "libcamera/internal/matrix.h"
> +#include "libcamera/internal/vector.h"
>  
>  namespace libcamera {
>  
> @@ -56,6 +57,11 @@ struct DebayerParams {
>  	 * Per frame CCM values as calcualted by the IPA
>  	 */
>  	Matrix<float, 3, 3> ccm;
> +
> +	/*
> +	 * Per frame awb gains calculated by the IPA
> +	 */

I think this can be on a single line:

  /* ... */

Reviewed-by: Milan Zamazal <mzamazal@redhat.com>

> +	RGB<float> gains;
>  };
>  
>  } /* namespace libcamera */

Patch
diff mbox series 

diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h
index 56803195..9d0a852d 100644
--- a/include/libcamera/internal/software_isp/debayer_params.h
+++ b/include/libcamera/internal/software_isp/debayer_params.h
@@ -14,6 +14,7 @@ 
 #include <stdint.h>
 
 #include "libcamera/internal/matrix.h"
+#include "libcamera/internal/vector.h"
 
 namespace libcamera {
 
@@ -56,6 +57,11 @@  struct DebayerParams {
 	 * Per frame CCM values as calcualted by the IPA
 	 */
 	Matrix<float, 3, 3> ccm;
+
+	/*
+	 * Per frame awb gains calculated by the IPA
+	 */
+	RGB<float> gains;
 };
 
 } /* namespace libcamera */