[v3,18/39] libcamera: software_isp: debayer: Extend DebayerParams struct to hold a copy of per-frame CCM values
diff mbox series

Message ID 20251015012251.17508-19-bryan.odonoghue@linaro.org
State New
Headers show
Series
  • Add GLES 2.0 GPUISP to libcamera
Related show

Commit Message

Bryan O'Donoghue Oct. 15, 2025, 1:22 a.m. UTC 
Add an element to the DebayerParams structure to capture the calculated
CCM. This allows us to pass the CCM into the eGL Debayer shader later on.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 include/libcamera/internal/software_isp/debayer_params.h | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Milan Zamazal Oct. 16, 2025, 9:08 a.m. UTC | #1 
Hi Bryan,

see
https://lists.libcamera.org/pipermail/libcamera-devel/2025-June/050886.html

Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes:

> Add an element to the DebayerParams structure to capture the calculated
> CCM. This allows us to pass the CCM into the eGL Debayer shader later on.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  include/libcamera/internal/software_isp/debayer_params.h | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h
> index 217cd5d9..56803195 100644
> --- a/include/libcamera/internal/software_isp/debayer_params.h
> +++ b/include/libcamera/internal/software_isp/debayer_params.h
> @@ -13,6 +13,8 @@
>  #include <array>
>  #include <stdint.h>
>  
> +#include "libcamera/internal/matrix.h"
> +
>  namespace libcamera {
>  
>  struct DebayerParams {
> @@ -49,6 +51,11 @@ struct DebayerParams {
>  	CcmLookupTable greenCcm;
>  	CcmLookupTable blueCcm;
>  	LookupTable gammaLut;
> +
> +	/*
> +	 * Per frame CCM values as calcualted by the IPA
> +	 */
> +	Matrix<float, 3, 3> ccm;
>  };
>  
>  } /* namespace libcamera */

Patch
diff mbox series 

diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h
index 217cd5d9..56803195 100644
--- a/include/libcamera/internal/software_isp/debayer_params.h
+++ b/include/libcamera/internal/software_isp/debayer_params.h
@@ -13,6 +13,8 @@ 
 #include <array>
 #include <stdint.h>
 
+#include "libcamera/internal/matrix.h"
+
 namespace libcamera {
 
 struct DebayerParams {
@@ -49,6 +51,11 @@  struct DebayerParams {
 	CcmLookupTable greenCcm;
 	CcmLookupTable blueCcm;
 	LookupTable gammaLut;
+
+	/*
+	 * Per frame CCM values as calcualted by the IPA
+	 */
+	Matrix<float, 3, 3> ccm;
 };
 
 } /* namespace libcamera */