[v3,25/39] libcamera: software_isp: Make isStandardBayerOrder static
diff mbox series

Message ID 20251015012251.17508-26-bryan.odonoghue@linaro.org
State New
Headers show
Series
  • Add GLES 2.0 GPUISP to libcamera
Related show

Commit Message

Bryan O'Donoghue Oct. 15, 2025, 1:22 a.m. UTC 
Make this member function static so that it may be called from static
members of derived classes.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 src/libcamera/software_isp/debayer.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kieran Bingham Oct. 15, 2025, 10:52 p.m. UTC | #1 
Quoting Bryan O'Donoghue (2025-10-15 02:22:37)
> Make this member function static so that it may be called from static
> members of derived classes.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  src/libcamera/software_isp/debayer.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h
> index 8fa281c7..a88f352b 100644
> --- a/src/libcamera/software_isp/debayer.h
> +++ b/src/libcamera/software_isp/debayer.h
> @@ -100,7 +100,7 @@ private:
>  protected:
>         void setParams(DebayerParams &params);
>         void dmaSyncBegin(std::vector<DmaSyncer> &dmaSyncers, FrameBuffer *input, FrameBuffer *output);
> -       bool isStandardBayerOrder(BayerFormat::Order order);
> +       static bool isStandardBayerOrder(BayerFormat::Order order);

Please squash this directly into 
[PATCH v3 14/39] libcamera: software_isp: Move isStandardBayerOrder to base class


>  };
>  
>  } /* namespace libcamera */
> -- 
> 2.51.0
>

Patch
diff mbox series 

diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h
index 8fa281c7..a88f352b 100644
--- a/src/libcamera/software_isp/debayer.h
+++ b/src/libcamera/software_isp/debayer.h
@@ -100,7 +100,7 @@  private:
 protected:
 	void setParams(DebayerParams &params);
 	void dmaSyncBegin(std::vector<DmaSyncer> &dmaSyncers, FrameBuffer *input, FrameBuffer *output);
-	bool isStandardBayerOrder(BayerFormat::Order order);
+	static bool isStandardBayerOrder(BayerFormat::Order order);
 };
 
 } /* namespace libcamera */