| Message ID | 20251015012251.17508-18-bryan.odonoghue@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Quoting Bryan O'Donoghue (2025-10-15 02:22:29) > Make the type of object Debayer not DebayerCpu thus allowing us to assign > the object to either DebayerCpu or DebayerEGL. > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > include/libcamera/internal/software_isp/software_isp.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h > index 78624659..ad89c9b3 100644 > --- a/include/libcamera/internal/software_isp/software_isp.h > +++ b/include/libcamera/internal/software_isp/software_isp.h > @@ -37,7 +37,7 @@ > > namespace libcamera { > > -class DebayerCpu; > +class Debayer; > class FrameBuffer; > class PixelFormat; > class Stream; > @@ -94,8 +94,7 @@ private: > void statsReady(uint32_t frame, uint32_t bufferId); > void inputReady(FrameBuffer *input); > void outputReady(FrameBuffer *output); > - > - std::unique_ptr<DebayerCpu> debayer_; > + std::unique_ptr<Debayer> debayer_; > Thread ispWorkerThread_; > SharedMemObject<DebayerParams> sharedParams_; > DebayerParams debayerParams_; > -- > 2.51.0 >
Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes: > Make the type of object Debayer not DebayerCpu thus allowing us to assign > the object to either DebayerCpu or DebayerEGL. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Looks like my already provided tag was lost, so once again: Reviewed-by: Milan Zamazal <mzamazal@redhat.com> > --- > include/libcamera/internal/software_isp/software_isp.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h > index 78624659..ad89c9b3 100644 > --- a/include/libcamera/internal/software_isp/software_isp.h > +++ b/include/libcamera/internal/software_isp/software_isp.h > @@ -37,7 +37,7 @@ > > namespace libcamera { > > -class DebayerCpu; > +class Debayer; > class FrameBuffer; > class PixelFormat; > class Stream; > @@ -94,8 +94,7 @@ private: > void statsReady(uint32_t frame, uint32_t bufferId); > void inputReady(FrameBuffer *input); > void outputReady(FrameBuffer *output); > - > - std::unique_ptr<DebayerCpu> debayer_; > + std::unique_ptr<Debayer> debayer_; > Thread ispWorkerThread_; > SharedMemObject<DebayerParams> sharedParams_; > DebayerParams debayerParams_;
diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h index 78624659..ad89c9b3 100644 --- a/include/libcamera/internal/software_isp/software_isp.h +++ b/include/libcamera/internal/software_isp/software_isp.h @@ -37,7 +37,7 @@ namespace libcamera { -class DebayerCpu; +class Debayer; class FrameBuffer; class PixelFormat; class Stream; @@ -94,8 +94,7 @@ private: void statsReady(uint32_t frame, uint32_t bufferId); void inputReady(FrameBuffer *input); void outputReady(FrameBuffer *output); - - std::unique_ptr<DebayerCpu> debayer_; + std::unique_ptr<Debayer> debayer_; Thread ispWorkerThread_; SharedMemObject<DebayerParams> sharedParams_; DebayerParams debayerParams_;
Make the type of object Debayer not DebayerCpu thus allowing us to assign the object to either DebayerCpu or DebayerEGL. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- include/libcamera/internal/software_isp/software_isp.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)