[v1,02/12] ipa: rkisp1: lsc: Drop unused function declaration
diff mbox series

Message ID 20251014075252.2876485-3-stefan.klug@ideasonboard.com
State New
Headers show
Series
  • Add resampling support for polynomial LSC data
Related show

Commit Message

Stefan Klug Oct. 14, 2025, 7:52 a.m. UTC 
The interpolateTable() function is not implemented anywhere. Drop the
declaration.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
---
 src/ipa/rkisp1/algorithms/lsc.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Barnabás Pőcze Oct. 14, 2025, 8:12 a.m. UTC | #1 
2025. 10. 14. 9:52 keltezéssel, Stefan Klug írta:
> The interpolateTable() function is not implemented anywhere. Drop the
> declaration.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> ---

It seems removed by you in a6adaa7283ce2ca22692a1d28b404a9ab15b59f0.

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>


>   src/ipa/rkisp1/algorithms/lsc.h | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h
> index 0e3745d5589c..7b68dda1a0d4 100644
> --- a/src/ipa/rkisp1/algorithms/lsc.h
> +++ b/src/ipa/rkisp1/algorithms/lsc.h
> @@ -39,9 +39,6 @@ public:
>   private:
>   	void setParameters(rkisp1_cif_isp_lsc_config &config);
>   	void copyTable(rkisp1_cif_isp_lsc_config &config, const Components &set0);
> -	void interpolateTable(rkisp1_cif_isp_lsc_config &config,
> -			      const Components &set0, const Components &set1,
> -			      const uint32_t ct);
>   
>   	ipa::Interpolator<Components> sets_;
>   	std::vector<double> xSize_;
Stefan Klug Oct. 14, 2025, 10:15 a.m. UTC | #2 
Hi,

Thank you for the review.

Quoting Barnabás Pőcze (2025-10-14 10:12:51)
> 2025. 10. 14. 9:52 keltezéssel, Stefan Klug írta:
> > The interpolateTable() function is not implemented anywhere. Drop the
> > declaration.
> > 
> > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> > ---
> 
> It seems removed by you in a6adaa7283ce2ca22692a1d28b404a9ab15b59f0.

I feared so :-)

> 
> Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Thanks,
Stefan

> 
> 
> >   src/ipa/rkisp1/algorithms/lsc.h | 3 ---
> >   1 file changed, 3 deletions(-)
> > 
> > diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h
> > index 0e3745d5589c..7b68dda1a0d4 100644
> > --- a/src/ipa/rkisp1/algorithms/lsc.h
> > +++ b/src/ipa/rkisp1/algorithms/lsc.h
> > @@ -39,9 +39,6 @@ public:
> >   private:
> >       void setParameters(rkisp1_cif_isp_lsc_config &config);
> >       void copyTable(rkisp1_cif_isp_lsc_config &config, const Components &set0);
> > -     void interpolateTable(rkisp1_cif_isp_lsc_config &config,
> > -                           const Components &set0, const Components &set1,
> > -                           const uint32_t ct);
> >   
> >       ipa::Interpolator<Components> sets_;
> >       std::vector<double> xSize_;
>
Rui Wang Oct. 24, 2025, 9:25 p.m. UTC | #3 
On 2025-10-14 03:52, Stefan Klug wrote:
> The interpolateTable() function is not implemented anywhere. Drop the 
> declaration. Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> 
> --- src/ipa/rkisp1/algorithms/lsc.h | 3 --- 1 file changed, 3 
> deletions(-) diff --git a/src/ipa/rkisp1/algorithms/lsc.h 
> b/src/ipa/rkisp1/algorithms/lsc.h index 0e3745d5589c..7b68dda1a0d4 
> 100644 --- a/src/ipa/rkisp1/algorithms/lsc.h +++ 
> b/src/ipa/rkisp1/algorithms/lsc.h @@ -39,9 +39,6 @@ public: private: 
> void setParameters(rkisp1_cif_isp_lsc_config &config); void 
> copyTable(rkisp1_cif_isp_lsc_config &config, const Components &set0); 
> - void interpolateTable(rkisp1_cif_isp_lsc_config &config, - const 
> Components &set0, const Components &set1, - const uint32_t ct); 
> ipa::Interpolator<Components> sets_; std::vector<double> xSize_;


Reviewed by Rui.
Laurent Pinchart Oct. 24, 2025, 10:21 p.m. UTC | #4 
Hi Rui,

Mails to the list should be in plain text, please disable HTML in your
mail client for the libcamera-devel mailing list.

On Fri, Oct 24, 2025 at 05:25:47PM -0400, Rui Wang wrote:
> 
> On 2025-10-14 03:52, Stefan Klug wrote:
> 
>     The interpolateTable() function is not implemented anywhere. Drop the
>     declaration.
> 
>     Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
>     ---
>      src/ipa/rkisp1/algorithms/lsc.h | 3 ---
>      1 file changed, 3 deletions(-)
> 
>     diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h
>     index 0e3745d5589c..7b68dda1a0d4 100644
>     --- a/src/ipa/rkisp1/algorithms/lsc.h
>     +++ b/src/ipa/rkisp1/algorithms/lsc.h
>     @@ -39,9 +39,6 @@ public:
>      private:
>             void setParameters(rkisp1_cif_isp_lsc_config &config);
>             void copyTable(rkisp1_cif_isp_lsc_config &config, const Components &set0);
>     -       void interpolateTable(rkisp1_cif_isp_lsc_config &config,
>     -                             const Components &set0, const Components &set1,
>     -                             const uint32_t ct);
> 
>             ipa::Interpolator<Components> sets_;
>             std::vector<double> xSize_;
> 
> 
> Reviewed by Rui.

The right syntax is

Reviewed-by: Name <email address>

to let tools such as 'git am', b4 or patchwork parse the tags correctly.
We broadly follow the Linux kernel process, you can find more
information at https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst.
Laurent Pinchart Oct. 28, 2025, 9:27 a.m. UTC | #5 
On Tue, Oct 14, 2025 at 09:52:24AM +0200, Stefan Klug wrote:
> The interpolateTable() function is not implemented anywhere. Drop the
> declaration.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/ipa/rkisp1/algorithms/lsc.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h
> index 0e3745d5589c..7b68dda1a0d4 100644
> --- a/src/ipa/rkisp1/algorithms/lsc.h
> +++ b/src/ipa/rkisp1/algorithms/lsc.h
> @@ -39,9 +39,6 @@ public:
>  private:
>  	void setParameters(rkisp1_cif_isp_lsc_config &config);
>  	void copyTable(rkisp1_cif_isp_lsc_config &config, const Components &set0);
> -	void interpolateTable(rkisp1_cif_isp_lsc_config &config,
> -			      const Components &set0, const Components &set1,
> -			      const uint32_t ct);
>  
>  	ipa::Interpolator<Components> sets_;
>  	std::vector<double> xSize_;

Patch
diff mbox series 

diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h
index 0e3745d5589c..7b68dda1a0d4 100644
--- a/src/ipa/rkisp1/algorithms/lsc.h
+++ b/src/ipa/rkisp1/algorithms/lsc.h
@@ -39,9 +39,6 @@  public:
 private:
 	void setParameters(rkisp1_cif_isp_lsc_config &config);
 	void copyTable(rkisp1_cif_isp_lsc_config &config, const Components &set0);
-	void interpolateTable(rkisp1_cif_isp_lsc_config &config,
-			      const Components &set0, const Components &set1,
-			      const uint32_t ct);
 
 	ipa::Interpolator<Components> sets_;
 	std::vector<double> xSize_;