[v1,01/12] ipa: rkisp1: lsc: Drop unused member variable
diff mbox series

Message ID 20251014075252.2876485-2-stefan.klug@ideasonboard.com
State New
Headers show
Series
  • Add resampling support for polynomial LSC data
Related show

Commit Message

Stefan Klug Oct. 14, 2025, 7:52 a.m. UTC 
The Components::ct member is not used anywhere. Drop it.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
---
 src/ipa/rkisp1/algorithms/lsc.cpp | 2 --
 src/ipa/rkisp1/algorithms/lsc.h   | 1 -
 2 files changed, 3 deletions(-)

Comments

Barnabás Pőcze Oct. 14, 2025, 8:12 a.m. UTC | #1 
2025. 10. 14. 9:52 keltezéssel, Stefan Klug írta:
> The Components::ct member is not used anywhere. Drop it.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> ---

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>


>   src/ipa/rkisp1/algorithms/lsc.cpp | 2 --
>   src/ipa/rkisp1/algorithms/lsc.h   | 1 -
>   2 files changed, 3 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp
> index e7301bfec863..ab0ada4eed46 100644
> --- a/src/ipa/rkisp1/algorithms/lsc.cpp
> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp
> @@ -113,7 +113,6 @@ public:
>   				return -EINVAL;
>   			}
>   
> -			set.ct = ct;
>   			pr->setReferenceImageSize(sensorSize_);
>   			pgr->setReferenceImageSize(sensorSize_);
>   			pgb->setReferenceImageSize(sensorSize_);
> @@ -221,7 +220,6 @@ public:
>   
>   			LensShadingCorrection::Components &set = lscData[ct];
>   
> -			set.ct = ct;
>   			set.r = parseTable(yamlSet, "r");
>   			set.gr = parseTable(yamlSet, "gr");
>   			set.gb = parseTable(yamlSet, "gb");
> diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h
> index 5a0824e36dd5..0e3745d5589c 100644
> --- a/src/ipa/rkisp1/algorithms/lsc.h
> +++ b/src/ipa/rkisp1/algorithms/lsc.h
> @@ -30,7 +30,6 @@ public:
>   		     RkISP1Params *params) override;
>   
>   	struct Components {
> -		uint32_t ct;
>   		std::vector<uint16_t> r;
>   		std::vector<uint16_t> gr;
>   		std::vector<uint16_t> gb;
Rui Wang Oct. 24, 2025, 9:19 p.m. UTC | #2 
On 2025-10-14 03:52, Stefan Klug wrote:
> The Components::ct member is not used anywhere. Drop it. 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> --- 
> src/ipa/rkisp1/algorithms/lsc.cpp | 2 -- 
> src/ipa/rkisp1/algorithms/lsc.h | 1 - 2 files changed, 3 deletions(-) 
> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp 
> b/src/ipa/rkisp1/algorithms/lsc.cpp index e7301bfec863..ab0ada4eed46 
> 100644 --- a/src/ipa/rkisp1/algorithms/lsc.cpp +++ 
> b/src/ipa/rkisp1/algorithms/lsc.cpp @@ -113,7 +113,6 @@ public: return 
> -EINVAL; } - set.ct = ct; pr->setReferenceImageSize(sensorSize_); 
> pgr->setReferenceImageSize(sensorSize_); 
> pgb->setReferenceImageSize(sensorSize_); @@ -221,7 +220,6 @@ public: 
> LensShadingCorrection::Components &set = lscData[ct]; - set.ct = ct; 
> set.r = parseTable(yamlSet, "r"); set.gr = parseTable(yamlSet, "gr"); 
> set.gb = parseTable(yamlSet, "gb"); diff --git 
> a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h 
> index 5a0824e36dd5..0e3745d5589c 100644 --- 
> a/src/ipa/rkisp1/algorithms/lsc.h +++ 
> b/src/ipa/rkisp1/algorithms/lsc.h @@ -30,7 +30,6 @@ public: 
> RkISP1Params *params) override; struct Components { - uint32_t ct; 
> std::vector<uint16_t> r; std::vector<uint16_t> gr; 
> std::vector<uint16_t> gb;


Reviewd by Rui Wang
Rui Wang Oct. 27, 2025, 8:53 p.m. UTC | #3 
On 2025-10-14 03:52, Stefan Klug wrote:
> The Components::ct member is not used anywhere. Drop it.
>
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> ---
>   src/ipa/rkisp1/algorithms/lsc.cpp | 2 --
>   src/ipa/rkisp1/algorithms/lsc.h   | 1 -
>   2 files changed, 3 deletions(-)
>
> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp
> index e7301bfec863..ab0ada4eed46 100644
> --- a/src/ipa/rkisp1/algorithms/lsc.cpp
> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp
> @@ -113,7 +113,6 @@ public:
>   				return -EINVAL;
>   			}
>   
> -			set.ct = ct;
>   			pr->setReferenceImageSize(sensorSize_);
>   			pgr->setReferenceImageSize(sensorSize_);
>   			pgb->setReferenceImageSize(sensorSize_);
> @@ -221,7 +220,6 @@ public:
>   
>   			LensShadingCorrection::Components &set = lscData[ct];
>   
> -			set.ct = ct;
>   			set.r = parseTable(yamlSet, "r");
>   			set.gr = parseTable(yamlSet, "gr");
>   			set.gb = parseTable(yamlSet, "gb");
> diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h
> index 5a0824e36dd5..0e3745d5589c 100644
> --- a/src/ipa/rkisp1/algorithms/lsc.h
> +++ b/src/ipa/rkisp1/algorithms/lsc.h
> @@ -30,7 +30,6 @@ public:
>   		     RkISP1Params *params) override;
>   
>   	struct Components {
> -		uint32_t ct;
>   		std::vector<uint16_t> r;
>   		std::vector<uint16_t> gr;
>   		std::vector<uint16_t> gb;
>
> Reviewed-by: Rui Wang <rui.wang@ideasonboard.com>
Rui Wang Oct. 27, 2025, 8:56 p.m. UTC | #4 
On 2025-10-14 03:52, Stefan Klug wrote:
> The Components::ct member is not used anywhere. Drop it.
>
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> ---
>   src/ipa/rkisp1/algorithms/lsc.cpp | 2 --
>   src/ipa/rkisp1/algorithms/lsc.h   | 1 -
>   2 files changed, 3 deletions(-)
>
> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp
> index e7301bfec863..ab0ada4eed46 100644
> --- a/src/ipa/rkisp1/algorithms/lsc.cpp
> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp
> @@ -113,7 +113,6 @@ public:
>   				return -EINVAL;
>   			}
>   
> -			set.ct = ct;
>   			pr->setReferenceImageSize(sensorSize_);
>   			pgr->setReferenceImageSize(sensorSize_);
>   			pgb->setReferenceImageSize(sensorSize_);
> @@ -221,7 +220,6 @@ public:
>   
>   			LensShadingCorrection::Components &set = lscData[ct];
>   
> -			set.ct = ct;
>   			set.r = parseTable(yamlSet, "r");
>   			set.gr = parseTable(yamlSet, "gr");
>   			set.gb = parseTable(yamlSet, "gb");
> diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h
> index 5a0824e36dd5..0e3745d5589c 100644
> --- a/src/ipa/rkisp1/algorithms/lsc.h
> +++ b/src/ipa/rkisp1/algorithms/lsc.h
> @@ -30,7 +30,6 @@ public:
>   		     RkISP1Params *params) override;
>   
>   	struct Components {
> -		uint32_t ct;
>   		std::vector<uint16_t> r;
>   		std::vector<uint16_t> gr;
>   		std::vector<uint16_t> gb;

Reviewed-by: Rui Wang <rui.wang@ideasonboard.com>

Patch
diff mbox series 

diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp
index e7301bfec863..ab0ada4eed46 100644
--- a/src/ipa/rkisp1/algorithms/lsc.cpp
+++ b/src/ipa/rkisp1/algorithms/lsc.cpp
@@ -113,7 +113,6 @@  public:
 				return -EINVAL;
 			}
 
-			set.ct = ct;
 			pr->setReferenceImageSize(sensorSize_);
 			pgr->setReferenceImageSize(sensorSize_);
 			pgb->setReferenceImageSize(sensorSize_);
@@ -221,7 +220,6 @@  public:
 
 			LensShadingCorrection::Components &set = lscData[ct];
 
-			set.ct = ct;
 			set.r = parseTable(yamlSet, "r");
 			set.gr = parseTable(yamlSet, "gr");
 			set.gb = parseTable(yamlSet, "gb");
diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h
index 5a0824e36dd5..0e3745d5589c 100644
--- a/src/ipa/rkisp1/algorithms/lsc.h
+++ b/src/ipa/rkisp1/algorithms/lsc.h
@@ -30,7 +30,6 @@  public:
 		     RkISP1Params *params) override;
 
 	struct Components {
-		uint32_t ct;
 		std::vector<uint16_t> r;
 		std::vector<uint16_t> gr;
 		std::vector<uint16_t> gb;