[v2,1/4] libcamera: camera_sensor_properties: Add vd55g1 camera sensor
diff mbox series

Message ID 20250917-vd55g1_support-v2-1-101b53b66add@foss.st.com
State Accepted
Commit 57ca25b61e0d28b1fd08cf46de6e6d4746b55eb4
Headers show
Series
  • Add vd55g1 support for rpi and libipa
Related show

Commit Message

Benjamin Mugnier Sept. 17, 2025, 1:42 p.m. UTC 
Add unit cell size from the 'pixel size' element in the datasheet.
Controls are buffered within the sensor and are always applied at frame
N+2.

Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
---
 src/libcamera/sensor/camera_sensor_properties.cpp | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Kieran Bingham Sept. 17, 2025, 2:01 p.m. UTC | #1 
Quoting Benjamin Mugnier (2025-09-17 14:42:11)
> Add unit cell size from the 'pixel size' element in the datasheet.
> Controls are buffered within the sensor and are always applied at frame
> N+2.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> ---
>  src/libcamera/sensor/camera_sensor_properties.cpp | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp
> index f2da8205372baabca58416e2c0f9da64e722fe02..09f60391fddba1738a5e2409703f023c9ba1655c 100644
> --- a/src/libcamera/sensor/camera_sensor_properties.cpp
> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp
> @@ -461,6 +461,23 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>                         },
>                         .sensorDelays = { },
>                 } },
> +               { "vd55g1", {
> +                       .unitCellSize = { 2160, 2160 },
> +                       .testPatternModes = {
> +                               { controls::draft::TestPatternModeOff, 0 },
> +                               { controls::draft::TestPatternModePn9, 2},
> +                               /*
> +                                * No corresponding test pattern mode for:
> +                                * 1: "Diagonal Gray Scale"
> +                                */
> +                       },
> +                       .sensorDelays = {
> +                               .exposureDelay = 2,
> +                               .gainDelay = 2,
> +                               .vblankDelay = 2,
> +                               .hblankDelay = 2
> +                       },
> +               } },
>                 { "vd56g3", {
>                         .unitCellSize = { 2610, 2610 },
>                         .testPatternModes = {
> 
> -- 
> 2.25.1
>

Patch
diff mbox series 

diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp
index f2da8205372baabca58416e2c0f9da64e722fe02..09f60391fddba1738a5e2409703f023c9ba1655c 100644
--- a/src/libcamera/sensor/camera_sensor_properties.cpp
+++ b/src/libcamera/sensor/camera_sensor_properties.cpp
@@ -461,6 +461,23 @@  const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
 			},
 			.sensorDelays = { },
 		} },
+		{ "vd55g1", {
+			.unitCellSize = { 2160, 2160 },
+			.testPatternModes = {
+				{ controls::draft::TestPatternModeOff, 0 },
+				{ controls::draft::TestPatternModePn9, 2},
+				/*
+				 * No corresponding test pattern mode for:
+				 * 1: "Diagonal Gray Scale"
+				 */
+			},
+			.sensorDelays = {
+				.exposureDelay = 2,
+				.gainDelay = 2,
+				.vblankDelay = 2,
+				.hblankDelay = 2
+			},
+		} },
 		{ "vd56g3", {
 			.unitCellSize = { 2610, 2610 },
 			.testPatternModes = {