Documentation: Fix grammar and typo in meson.build comment

24303 diff mbox series

No functional change, this is only cosmetic.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 Documentation/meson.build | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


base-commit: b8d332cdcc130c27232f61369e7bab2d954e7ac6
--
Regards,

Laurent Pinchart

Quoting Laurent Pinchart (2025-09-10 23:26:33)
> No functional change, this is only cosmetic.
> 

I see:

/Doxyfile public/Doxyfile-public/
/cdata cdata, as/cdata, as/
/Using/Use/

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  Documentation/meson.build | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/meson.build b/Documentation/meson.build
> index a8d4afc01dd1..90133c4da938 100644
> --- a/Documentation/meson.build
> +++ b/Documentation/meson.build
> @@ -64,9 +64,9 @@ if doxygen.found() and dot.found()
>                                     configuration : cdata)
> 
>      # The set of public input files stored in the doxygen_public_input array
> -    # needs to be set in Doxyfile public. We can't pass them through cdata
> -    # cdata, as some of the array members are custom_tgt instances, which
> -    # configuration_data.set() doesn't support. Using a separate script invoked
> +    # needs to be set in Doxyfile-public. We can't pass them through cdata, as
> +    # some of the array members are custom_tgt instances, which
> +    # configuration_data.set() doesn't support. Use a separate script invoked
>      # through custom_target(), which supports custom_tgt instances as inputs.
> 
>      doxyfile = custom_target('doxyfile-public',
> 
> base-commit: b8d332cdcc130c27232f61369e7bab2d954e7ac6
> --
> Regards,
> 
> Laurent Pinchart
>

Hi

2025. 09. 11. 0:26 keltezéssel, Laurent Pinchart írta:
> No functional change, this is only cosmetic.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>   Documentation/meson.build | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/meson.build b/Documentation/meson.build
> index a8d4afc01dd1..90133c4da938 100644
> --- a/Documentation/meson.build
> +++ b/Documentation/meson.build
> @@ -64,9 +64,9 @@ if doxygen.found() and dot.found()
>                                      configuration : cdata)
> 
>       # The set of public input files stored in the doxygen_public_input array
> -    # needs to be set in Doxyfile public. We can't pass them through cdata
> -    # cdata, as some of the array members are custom_tgt instances, which
> -    # configuration_data.set() doesn't support. Using a separate script invoked
> +    # needs to be set in Doxyfile-public. We can't pass them through cdata, as
> +    # some of the array members are custom_tgt instances, which
> +    # configuration_data.set() doesn't support. Use a separate script invoked
>       # through custom_target(), which supports custom_tgt instances as inputs.

Isn't the core of the issue that cfg_data.set() does not support arrays as values?
In any case, that's not related to the change.

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>



> 
>       doxyfile = custom_target('doxyfile-public',
> 
> base-commit: b8d332cdcc130c27232f61369e7bab2d954e7ac6
> --
> Regards,
> 
> Laurent Pinchart
>