| Message ID | 20250620-add_b4_config-v1-1-bc183e48e886@foss.st.com |
|---|---|
| State | Accepted |
| Commit | 9c082483f435421fe9ae8f899cdef55c81c35ca8 |
| Headers | show |
| Series |
|
| Related | show |
Quoting Benjamin Mugnier (2025-06-20 16:32:52) > Per the b4 documentation: B4 is a tool created to make it easier for > project developers and maintainers to use a distributed development > workflow that relies on patches and distribution lists for code > contributions and review. > > B4 is now a common tool used by developers for Linux kernel workflows. I haven't actually used b4 much yet, but I'm told repeatedly that it's very helpful, and I'm sure others have already used it with libcamera too. > While the Linux kernel support is handled inside b4, other projects can > rely on a .b4-config file to achieve the same thing. > > Add a .b4-config file to instruct b4 to send patches to the > libcamera-devel mailing list. This allows the command b4 prep > --auto-to-cc to automatically add the mailing to its To: list. I handle this by adding a default to in my [sendemail] key of the .git/config ... but that's a pain as it has to be added to each clone of libcamera separatly. And I have lots of copies of libcamera for some reason ;-) Anyway, all that to say I would approve of something like this to make life easier for developers to contribute directly to the project! Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Command output without .b4-config : > > $ b4 prep --auto-to-cc > Collecting To/Cc addresses > No new addresses to add. > > With .b4-config : > > $ b4 prep --auto-to-cc > Collecting To/Cc addresses > + To: libcamera-devel@lists.libcamera.org > > --- ^ these three lines stop your SoB and the text below being picked up from git-am while applying - so your SoB will need to be added back manually when applying. I'll wait to see if there's any other feedback first though. > Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> > --- > You can trim/expand this list with: b4 prep --edit-cover > Invoking git-filter-repo to update the cover letter. > New history written in 0.02 seconds... > Completely finished after 0.04 seconds. I assume this block of text isn't destined for the commit message. > > Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> > --- > .b4-config | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/.b4-config b/.b4-config > new file mode 100644 > index 0000000000000000000000000000000000000000..371e3e9c2485a4e2cb0ff48ccbfa5f4b246f29ee > --- /dev/null > +++ b/.b4-config > @@ -0,0 +1,2 @@ > +[b4] > + send-series-to = libcamera-devel@lists.libcamera.org > Adding the patchwork integration will be interesting here too ... https://b4.docs.kernel.org/en/latest/config.html#patchwork-integration-settings But that can be on top. Thanks Kieran > --- > base-commit: b3ff75d7589a263412ad63008b3c8518d40e6316 > change-id: 20250620-add_b4_config-965740f529f8 > > Best regards, > -- > Benjamin Mugnier <benjamin.mugnier@foss.st.com> >
On Sat, Jun 21, 2025 at 10:30:10AM +0100, Kieran Bingham wrote: > Quoting Benjamin Mugnier (2025-06-20 16:32:52) > > Per the b4 documentation: B4 is a tool created to make it easier for > > project developers and maintainers to use a distributed development > > workflow that relies on patches and distribution lists for code > > contributions and review. > > > > B4 is now a common tool used by developers for Linux kernel workflows. > > I haven't actually used b4 much yet, but I'm told repeatedly that it's > very helpful, and I'm sure others have already used it with libcamera > too. > > > While the Linux kernel support is handled inside b4, other projects can > > rely on a .b4-config file to achieve the same thing. > > > > Add a .b4-config file to instruct b4 to send patches to the > > libcamera-devel mailing list. This allows the command b4 prep > > --auto-to-cc to automatically add the mailing to its To: list. > > I handle this by adding a default to in my [sendemail] key of the > .git/config ... but that's a pain as it has to be added to each clone of > libcamera separatly. And I have lots of copies of libcamera for some > reason ;-) > > Anyway, all that to say I would approve of something like this to make > life easier for developers to contribute directly to the project! > > Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > Command output without .b4-config : > > > > $ b4 prep --auto-to-cc > > Collecting To/Cc addresses > > No new addresses to add. > > > > With .b4-config : > > > > $ b4 prep --auto-to-cc > > Collecting To/Cc addresses > > + To: libcamera-devel@lists.libcamera.org > > > > --- > > ^ these three lines stop your SoB and the text below being picked up > from git-am while applying - so your SoB will need to be added back > manually when applying. This should be fixed by indenting the whole block with spaces. Just adding the SoB line will confuse tools. Command output without .b4-config : $ b4 prep --auto-to-cc Collecting To/Cc addresses No new addresses to add. With .b4-config : $ b4 prep --auto-to-cc Collecting To/Cc addresses + To: libcamera-devel@lists.libcamera.org --- Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> --- You can trim/expand this list with: b4 prep --edit-cover Invoking git-filter-repo to update the cover letter. New history written in 0.02 seconds... Completely finished after 0.04 seconds. > I'll wait to see if there's any other feedback first though. > > > Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> > > --- > > You can trim/expand this list with: b4 prep --edit-cover > > Invoking git-filter-repo to update the cover letter. > > New history written in 0.02 seconds... > > Completely finished after 0.04 seconds. > > I assume this block of text isn't destined for the commit message. I think that's the b4 output. > > > > Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> > > --- > > .b4-config | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/.b4-config b/.b4-config > > new file mode 100644 > > index 0000000000000000000000000000000000000000..371e3e9c2485a4e2cb0ff48ccbfa5f4b246f29ee > > --- /dev/null > > +++ b/.b4-config > > @@ -0,0 +1,2 @@ > > +[b4] > > + send-series-to = libcamera-devel@lists.libcamera.org > > Adding the patchwork integration will be interesting here too ... > > https://b4.docs.kernel.org/en/latest/config.html#patchwork-integration-settings > > But that can be on top. That, and public-inbox :-) Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > base-commit: b3ff75d7589a263412ad63008b3c8518d40e6316 > > change-id: 20250620-add_b4_config-965740f529f8
On 6/23/25 01:22, Laurent Pinchart wrote: > On Sat, Jun 21, 2025 at 10:30:10AM +0100, Kieran Bingham wrote: >> Quoting Benjamin Mugnier (2025-06-20 16:32:52) >>> Per the b4 documentation: B4 is a tool created to make it easier for >>> project developers and maintainers to use a distributed development >>> workflow that relies on patches and distribution lists for code >>> contributions and review. >>> >>> B4 is now a common tool used by developers for Linux kernel workflows. >> >> I haven't actually used b4 much yet, but I'm told repeatedly that it's >> very helpful, and I'm sure others have already used it with libcamera >> too. >> >>> While the Linux kernel support is handled inside b4, other projects can >>> rely on a .b4-config file to achieve the same thing. >>> >>> Add a .b4-config file to instruct b4 to send patches to the >>> libcamera-devel mailing list. This allows the command b4 prep >>> --auto-to-cc to automatically add the mailing to its To: list. >> >> I handle this by adding a default to in my [sendemail] key of the >> .git/config ... but that's a pain as it has to be added to each clone of >> libcamera separatly. And I have lots of copies of libcamera for some >> reason ;-) So I'm not the only one doing this ;) >> >> Anyway, all that to say I would approve of something like this to make >> life easier for developers to contribute directly to the project! >> >> Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com> >> >>> Command output without .b4-config : >>> >>> $ b4 prep --auto-to-cc >>> Collecting To/Cc addresses >>> No new addresses to add. >>> >>> With .b4-config : >>> >>> $ b4 prep --auto-to-cc >>> Collecting To/Cc addresses >>> + To: libcamera-devel@lists.libcamera.org >>> >>> --- >> >> ^ these three lines stop your SoB and the text below being picked up >> from git-am while applying - so your SoB will need to be added back >> manually when applying. > > This should be fixed by indenting the whole block with spaces. Just > adding the SoB line will confuse tools. > > > Command output without .b4-config : > > $ b4 prep --auto-to-cc > Collecting To/Cc addresses > No new addresses to add. > > With .b4-config : > > $ b4 prep --auto-to-cc > Collecting To/Cc addresses > + To: libcamera-devel@lists.libcamera.org > > --- > Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> > --- > You can trim/expand this list with: b4 prep --edit-cover > Invoking git-filter-repo to update the cover letter. > New history written in 0.02 seconds... > Completely finished after 0.04 seconds. > > >> I'll wait to see if there's any other feedback first though. >> >>> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> >>> --- >>> You can trim/expand this list with: b4 prep --edit-cover >>> Invoking git-filter-repo to update the cover letter. >>> New history written in 0.02 seconds... >>> Completely finished after 0.04 seconds. >> >> I assume this block of text isn't destined for the commit message. > > I think that's the b4 output. > Exactly, the indentation makes it way easier to read. The real SoB is just below. >>> >>> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> >>> --- >>> .b4-config | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/.b4-config b/.b4-config >>> new file mode 100644 >>> index 0000000000000000000000000000000000000000..371e3e9c2485a4e2cb0ff48ccbfa5f4b246f29ee >>> --- /dev/null >>> +++ b/.b4-config >>> @@ -0,0 +1,2 @@ >>> +[b4] >>> + send-series-to = libcamera-devel@lists.libcamera.org >> >> Adding the patchwork integration will be interesting here too ... >> >> https://b4.docs.kernel.org/en/latest/config.html#patchwork-integration-settings >> >> But that can be on top. > > That, and public-inbox :-) > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >>> --- >>> base-commit: b3ff75d7589a263412ad63008b3c8518d40e6316 >>> change-id: 20250620-add_b4_config-965740f529f8 >
Quoting Benjamin Mugnier (2025-06-23 09:13:19) > On 6/23/25 01:22, Laurent Pinchart wrote: > > On Sat, Jun 21, 2025 at 10:30:10AM +0100, Kieran Bingham wrote: > >> Quoting Benjamin Mugnier (2025-06-20 16:32:52) > >>> Per the b4 documentation: B4 is a tool created to make it easier for > >>> project developers and maintainers to use a distributed development > >>> workflow that relies on patches and distribution lists for code > >>> contributions and review. > >>> > >>> B4 is now a common tool used by developers for Linux kernel workflows. > >> > >> I haven't actually used b4 much yet, but I'm told repeatedly that it's > >> very helpful, and I'm sure others have already used it with libcamera > >> too. > >> > >>> While the Linux kernel support is handled inside b4, other projects can > >>> rely on a .b4-config file to achieve the same thing. > >>> > >>> Add a .b4-config file to instruct b4 to send patches to the > >>> libcamera-devel mailing list. This allows the command b4 prep > >>> --auto-to-cc to automatically add the mailing to its To: list. > >> > >> I handle this by adding a default to in my [sendemail] key of the > >> .git/config ... but that's a pain as it has to be added to each clone of > >> libcamera separatly. And I have lots of copies of libcamera for some > >> reason ;-) > > So I'm not the only one doing this ;) > > >> > >> Anyway, all that to say I would approve of something like this to make > >> life easier for developers to contribute directly to the project! > >> > >> Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > >> > >>> Command output without .b4-config : > >>> > >>> $ b4 prep --auto-to-cc > >>> Collecting To/Cc addresses > >>> No new addresses to add. > >>> > >>> With .b4-config : > >>> > >>> $ b4 prep --auto-to-cc > >>> Collecting To/Cc addresses > >>> + To: libcamera-devel@lists.libcamera.org > >>> > >>> --- > >> > >> ^ these three lines stop your SoB and the text below being picked up > >> from git-am while applying - so your SoB will need to be added back > >> manually when applying. > > > > This should be fixed by indenting the whole block with spaces. Just > > adding the SoB line will confuse tools. > > > > > > Command output without .b4-config : > > > > $ b4 prep --auto-to-cc > > Collecting To/Cc addresses > > No new addresses to add. > > > > With .b4-config : > > > > $ b4 prep --auto-to-cc > > Collecting To/Cc addresses > > + To: libcamera-devel@lists.libcamera.org > > > > --- > > Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> > > --- > > You can trim/expand this list with: b4 prep --edit-cover > > Invoking git-filter-repo to update the cover letter. > > New history written in 0.02 seconds... > > Completely finished after 0.04 seconds. > > > > > >> I'll wait to see if there's any other feedback first though. > >> > >>> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> > >>> --- > >>> You can trim/expand this list with: b4 prep --edit-cover > >>> Invoking git-filter-repo to update the cover letter. > >>> New history written in 0.02 seconds... > >>> Completely finished after 0.04 seconds. > >> > >> I assume this block of text isn't destined for the commit message. > > > > I think that's the b4 output. > > > > Exactly, the indentation makes it way easier to read. The real SoB is > just below. > > >>> > >>> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> Benjamin, could you post a v2 with this formatted correctly please? Then I can merge it. -- Kieran > >>> --- > >>> .b4-config | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/.b4-config b/.b4-config > >>> new file mode 100644 > >>> index 0000000000000000000000000000000000000000..371e3e9c2485a4e2cb0ff48ccbfa5f4b246f29ee > >>> --- /dev/null > >>> +++ b/.b4-config > >>> @@ -0,0 +1,2 @@ > >>> +[b4] > >>> + send-series-to = libcamera-devel@lists.libcamera.org > >> > >> Adding the patchwork integration will be interesting here too ... > >> > >> https://b4.docs.kernel.org/en/latest/config.html#patchwork-integration-settings > >> > >> But that can be on top. > > > > That, and public-inbox :-) > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > >>> --- > >>> base-commit: b3ff75d7589a263412ad63008b3c8518d40e6316 > >>> change-id: 20250620-add_b4_config-965740f529f8 > > > > -- > Regards, > Benjamin
Hi, On 7/18/25 15:33, Kieran Bingham wrote: [...] >>>>> --- >>>>> .b4-config | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/.b4-config b/.b4-config >>>>> new file mode 100644 >>>>> index 0000000000000000000000000000000000000000..371e3e9c2485a4e2cb0ff48ccbfa5f4b246f29ee >>>>> --- /dev/null >>>>> +++ b/.b4-config >>>>> @@ -0,0 +1,2 @@ >>>>> +[b4] >>>>> + send-series-to = libcamera-devel@lists.libcamera.org >>>> >>>> Adding the patchwork integration will be interesting here too ... >>>> >>>> https://b4.docs.kernel.org/en/latest/config.html#patchwork-integration-settings >>>> >>>> But that can be on top. >>> >>> That, and public-inbox :-) I'd like this feature, I looked a bit at it. Patchwork seems simple enough to do, but since I'm not using patchwork I can't test it. The public-inbox part is doable using core options [1], but the libcamera-devel archives [2] does not follow the same URL patterns as lore.kernel.org [3] and it looks incompatible. I'm not sure but I guess this is because libcamera-devel archives are using pipermail instead of public-inbox, right ? Here is an URL example on linux-media mailing list : https://lore.kernel.org/linux-media/20250818-vd55g1_fix_duster-v1-1-1b9d115dee87@foss.st.com/ And one on the libcamera-devel mailing list : https://lists.libcamera.org/pipermail/libcamera-devel/2025-June/050990.html 1: https://b4.docs.kernel.org/en/latest/config.html#core-options 2: https://lists.libcamera.org/pipermail/libcamera-devel/ 3: https://lore.kernel.org/
On Tue, Sep 02, 2025 at 09:48:55AM +0200, Benjamin Mugnier wrote: > On 7/18/25 15:33, Kieran Bingham wrote: > [...] > >>>>> --- > >>>>> .b4-config | 2 ++ > >>>>> 1 file changed, 2 insertions(+) > >>>>> > >>>>> diff --git a/.b4-config b/.b4-config > >>>>> new file mode 100644 > >>>>> index 0000000000000000000000000000000000000000..371e3e9c2485a4e2cb0ff48ccbfa5f4b246f29ee > >>>>> --- /dev/null > >>>>> +++ b/.b4-config > >>>>> @@ -0,0 +1,2 @@ > >>>>> +[b4] > >>>>> + send-series-to = libcamera-devel@lists.libcamera.org > >>>> > >>>> Adding the patchwork integration will be interesting here too ... > >>>> > >>>> https://b4.docs.kernel.org/en/latest/config.html#patchwork-integration-settings > >>>> > >>>> But that can be on top. > >>> > >>> That, and public-inbox :-) > > I'd like this feature, I looked a bit at it. > > Patchwork seems simple enough to do, but since I'm not using patchwork I > can't test it. > > The public-inbox part is doable using core options [1], but the > libcamera-devel archives [2] does not follow the same URL patterns as > lore.kernel.org [3] and it looks incompatible. I'm not sure but I guess > this is because libcamera-devel archives are using pipermail instead of > public-inbox, right ? Yes. We need a public-inbox archive for the libcamera-devel mailing list. That's on my long todo list, along with updating the server running the mailing list. I expect to get to that in about a month. > Here is an URL example on linux-media mailing list : > > https://lore.kernel.org/linux-media/20250818-vd55g1_fix_duster-v1-1-1b9d115dee87@foss.st.com/ > > And one on the libcamera-devel mailing list : > > https://lists.libcamera.org/pipermail/libcamera-devel/2025-June/050990.html > > 1: https://b4.docs.kernel.org/en/latest/config.html#core-options > 2: https://lists.libcamera.org/pipermail/libcamera-devel/ > 3: https://lore.kernel.org/
On 9/2/25 11:09, Laurent Pinchart wrote: > On Tue, Sep 02, 2025 at 09:48:55AM +0200, Benjamin Mugnier wrote: >> On 7/18/25 15:33, Kieran Bingham wrote: >> [...] >>>>>>> --- >>>>>>> .b4-config | 2 ++ >>>>>>> 1 file changed, 2 insertions(+) >>>>>>> >>>>>>> diff --git a/.b4-config b/.b4-config >>>>>>> new file mode 100644 >>>>>>> index 0000000000000000000000000000000000000000..371e3e9c2485a4e2cb0ff48ccbfa5f4b246f29ee >>>>>>> --- /dev/null >>>>>>> +++ b/.b4-config >>>>>>> @@ -0,0 +1,2 @@ >>>>>>> +[b4] >>>>>>> + send-series-to = libcamera-devel@lists.libcamera.org >>>>>> >>>>>> Adding the patchwork integration will be interesting here too ... >>>>>> >>>>>> https://b4.docs.kernel.org/en/latest/config.html#patchwork-integration-settings >>>>>> >>>>>> But that can be on top. >>>>> >>>>> That, and public-inbox :-) >> >> I'd like this feature, I looked a bit at it. >> >> Patchwork seems simple enough to do, but since I'm not using patchwork I >> can't test it. >> >> The public-inbox part is doable using core options [1], but the >> libcamera-devel archives [2] does not follow the same URL patterns as >> lore.kernel.org [3] and it looks incompatible. I'm not sure but I guess >> this is because libcamera-devel archives are using pipermail instead of >> public-inbox, right ? > > Yes. We need a public-inbox archive for the libcamera-devel mailing > list. That's on my long todo list, along with updating the server > running the mailing list. I expect to get to that in about a month. > Sweet. I'll take another look once public-inbox is ready then. >> Here is an URL example on linux-media mailing list : >> >> https://lore.kernel.org/linux-media/20250818-vd55g1_fix_duster-v1-1-1b9d115dee87@foss.st.com/ >> >> And one on the libcamera-devel mailing list : >> >> https://lists.libcamera.org/pipermail/libcamera-devel/2025-June/050990.html >> >> 1: https://b4.docs.kernel.org/en/latest/config.html#core-options >> 2: https://lists.libcamera.org/pipermail/libcamera-devel/ >> 3: https://lore.kernel.org/ >
diff --git a/.b4-config b/.b4-config new file mode 100644 index 0000000000000000000000000000000000000000..371e3e9c2485a4e2cb0ff48ccbfa5f4b246f29ee --- /dev/null +++ b/.b4-config @@ -0,0 +1,2 @@ +[b4] + send-series-to = libcamera-devel@lists.libcamera.org
Per the b4 documentation: B4 is a tool created to make it easier for project developers and maintainers to use a distributed development workflow that relies on patches and distribution lists for code contributions and review. B4 is now a common tool used by developers for Linux kernel workflows. While the Linux kernel support is handled inside b4, other projects can rely on a .b4-config file to achieve the same thing. Add a .b4-config file to instruct b4 to send patches to the libcamera-devel mailing list. This allows the command b4 prep --auto-to-cc to automatically add the mailing to its To: list. Command output without .b4-config : $ b4 prep --auto-to-cc Collecting To/Cc addresses No new addresses to add. With .b4-config : $ b4 prep --auto-to-cc Collecting To/Cc addresses + To: libcamera-devel@lists.libcamera.org --- Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> --- You can trim/expand this list with: b4 prep --edit-cover Invoking git-filter-repo to update the cover letter. New history written in 0.02 seconds... Completely finished after 0.04 seconds. Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> --- .b4-config | 2 ++ 1 file changed, 2 insertions(+) --- base-commit: b3ff75d7589a263412ad63008b3c8518d40e6316 change-id: 20250620-add_b4_config-965740f529f8 Best regards,