| Message ID | 20250815142334.662183-1-kieran.bingham@ideasonboard.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi Kieran On Fri, 15 Aug 2025 at 15:23, Kieran Bingham <kieran.bingham@ideasonboard.com> wrote: > > This series introduces the IMX335 and IMX415 tuning files for Raspberry > Pi platforms. > > Note there is an interesting collision in this as the the VC4 platform > has an existing IMX415 tuning file. FWIW, that original tuning file was created for the Luckfox IMX415 module, supposedly for RK3576 https://www.luckfox.com/IMX415-98-IR-CUT-Camera Although that looks identical to the Waveshare module, so they may well have got Waveshare to make it on their behalf. Waveshare's wiki links to Luckfox, and both reference using the module on a Pi. https://www.waveshare.com/imx415-98-ir-cut-camera.htm Dave > We don't presently have a way to match tuning files to specific modules > - so in this series I have pre-emptively proposed adding a vendor and > sku tag to the tuning files for at least documentation purposes, but > the identifiers are not used. > > i.e. > > + "version": 2.0, > + "target": "pisp", > + "vendor": "Arducam", > + "sku": "B0568", > + "algorithms": [ > > We need to coordinate a way with upstream linux kernel to > match/represent/identify sensor modules to elect a specific tuning file. > > I have added the sku identifier to the imx415.json file to make it > explicitly clear which one is the Arducam file. > > Thoughts and comments or suggestions very much welcome on how we > progress this topic - but I'd like to get at least the data files in so > they can be used/referenced. > > Kieran Bingham (2): > ipa: rpi: Add Arducam B0568 IMX335 tuning files > ipa: rpi: Add Arducam B0569 IMX415 tuning files > > src/ipa/rpi/pisp/data/imx335.json | 1475 +++++++++++++++++++++++ > src/ipa/rpi/pisp/data/imx415_b0569.json | 1475 +++++++++++++++++++++++ > src/ipa/rpi/pisp/data/meson.build | 2 + > src/ipa/rpi/vc4/data/imx335.json | 569 +++++++++ > src/ipa/rpi/vc4/data/imx415_b0569.json | 569 +++++++++ > src/ipa/rpi/vc4/data/meson.build | 2 + > 6 files changed, 4092 insertions(+) > create mode 100644 src/ipa/rpi/pisp/data/imx335.json > create mode 100644 src/ipa/rpi/pisp/data/imx415_b0569.json > create mode 100644 src/ipa/rpi/vc4/data/imx335.json > create mode 100644 src/ipa/rpi/vc4/data/imx415_b0569.json > > -- > 2.50.1 >
Quoting Dave Stevenson (2025-08-20 16:18:35) > Hi Kieran > > On Fri, 15 Aug 2025 at 15:23, Kieran Bingham > <kieran.bingham@ideasonboard.com> wrote: > > > > This series introduces the IMX335 and IMX415 tuning files for Raspberry > > Pi platforms. > > > > Note there is an interesting collision in this as the the VC4 platform > > has an existing IMX415 tuning file. > > FWIW, that original tuning file was created for the Luckfox IMX415 > module, supposedly for RK3576 > https://www.luckfox.com/IMX415-98-IR-CUT-Camera > > Although that looks identical to the Waveshare module, so they may > well have got Waveshare to make it on their behalf. Waveshare's wiki > links to Luckfox, and both reference using the module on a Pi. > https://www.waveshare.com/imx415-98-ir-cut-camera.htm Thanks, I guess we could add that to the file in a corresponding vendor/sku update there to help maintain the files. Naush, David, any thoughts on this or concerns about merging more tuning files? -- Regards Kieran > > Dave > > > We don't presently have a way to match tuning files to specific modules > > - so in this series I have pre-emptively proposed adding a vendor and > > sku tag to the tuning files for at least documentation purposes, but > > the identifiers are not used. > > > > i.e. > > > > + "version": 2.0, > > + "target": "pisp", > > + "vendor": "Arducam", > > + "sku": "B0568", > > + "algorithms": [ > > > > We need to coordinate a way with upstream linux kernel to > > match/represent/identify sensor modules to elect a specific tuning file. > > > > I have added the sku identifier to the imx415.json file to make it > > explicitly clear which one is the Arducam file. > > > > Thoughts and comments or suggestions very much welcome on how we > > progress this topic - but I'd like to get at least the data files in so > > they can be used/referenced. > > > > Kieran Bingham (2): > > ipa: rpi: Add Arducam B0568 IMX335 tuning files > > ipa: rpi: Add Arducam B0569 IMX415 tuning files > > > > src/ipa/rpi/pisp/data/imx335.json | 1475 +++++++++++++++++++++++ > > src/ipa/rpi/pisp/data/imx415_b0569.json | 1475 +++++++++++++++++++++++ > > src/ipa/rpi/pisp/data/meson.build | 2 + > > src/ipa/rpi/vc4/data/imx335.json | 569 +++++++++ > > src/ipa/rpi/vc4/data/imx415_b0569.json | 569 +++++++++ > > src/ipa/rpi/vc4/data/meson.build | 2 + > > 6 files changed, 4092 insertions(+) > > create mode 100644 src/ipa/rpi/pisp/data/imx335.json > > create mode 100644 src/ipa/rpi/pisp/data/imx415_b0569.json > > create mode 100644 src/ipa/rpi/vc4/data/imx335.json > > create mode 100644 src/ipa/rpi/vc4/data/imx415_b0569.json > > > > -- > > 2.50.1 > >
Hi Kieran, On Fri, 29 Aug 2025, 4:34 pm Kieran Bingham, < kieran.bingham@ideasonboard.com> wrote: > Quoting Dave Stevenson (2025-08-20 16:18:35) > > Hi Kieran > > > > On Fri, 15 Aug 2025 at 15:23, Kieran Bingham > > <kieran.bingham@ideasonboard.com> wrote: > > > > > > This series introduces the IMX335 and IMX415 tuning files for Raspberry > > > Pi platforms. > > > > > > Note there is an interesting collision in this as the the VC4 platform > > > has an existing IMX415 tuning file. > > > > FWIW, that original tuning file was created for the Luckfox IMX415 > > module, supposedly for RK3576 > > https://www.luckfox.com/IMX415-98-IR-CUT-Camera > > > > Although that looks identical to the Waveshare module, so they may > > well have got Waveshare to make it on their behalf. Waveshare's wiki > > links to Luckfox, and both reference using the module on a Pi. > > https://www.waveshare.com/imx415-98-ir-cut-camera.htm > > Thanks, I guess we could add that to the file in a corresponding > vendor/sku update there to help maintain the files. > > Naush, David, any thoughts on this or concerns about merging more tuning > files? No objections from me. Acked-by: Naushir Patuck <naush@raspberrypi.com> > -- > Regards > > Kieran > > > > > Dave > > > > > We don't presently have a way to match tuning files to specific modules > > > - so in this series I have pre-emptively proposed adding a vendor and > > > sku tag to the tuning files for at least documentation purposes, but > > > the identifiers are not used. > > > > > > i.e. > > > > > > + "version": 2.0, > > > + "target": "pisp", > > > + "vendor": "Arducam", > > > + "sku": "B0568", > > > + "algorithms": [ > > > > > > We need to coordinate a way with upstream linux kernel to > > > match/represent/identify sensor modules to elect a specific tuning > file. > > > > > > I have added the sku identifier to the imx415.json file to make it > > > explicitly clear which one is the Arducam file. > > > > > > Thoughts and comments or suggestions very much welcome on how we > > > progress this topic - but I'd like to get at least the data files in so > > > they can be used/referenced. > > > > > > Kieran Bingham (2): > > > ipa: rpi: Add Arducam B0568 IMX335 tuning files > > > ipa: rpi: Add Arducam B0569 IMX415 tuning files > > > > > > src/ipa/rpi/pisp/data/imx335.json | 1475 +++++++++++++++++++++++ > > > src/ipa/rpi/pisp/data/imx415_b0569.json | 1475 +++++++++++++++++++++++ > > > src/ipa/rpi/pisp/data/meson.build | 2 + > > > src/ipa/rpi/vc4/data/imx335.json | 569 +++++++++ > > > src/ipa/rpi/vc4/data/imx415_b0569.json | 569 +++++++++ > > > src/ipa/rpi/vc4/data/meson.build | 2 + > > > 6 files changed, 4092 insertions(+) > > > create mode 100644 src/ipa/rpi/pisp/data/imx335.json > > > create mode 100644 src/ipa/rpi/pisp/data/imx415_b0569.json > > > create mode 100644 src/ipa/rpi/vc4/data/imx335.json > > > create mode 100644 src/ipa/rpi/vc4/data/imx415_b0569.json > > > > > > -- > > > 2.50.1 > > > >
Quoting Kieran Bingham (2025-08-15 23:23:32) > This series introduces the IMX335 and IMX415 tuning files for Raspberry > Pi platforms. > > Note there is an interesting collision in this as the the VC4 platform > has an existing IMX415 tuning file. > > We don't presently have a way to match tuning files to specific modules > - so in this series I have pre-emptively proposed adding a vendor and > sku tag to the tuning files for at least documentation purposes, but > the identifiers are not used. > > i.e. > > + "version": 2.0, > + "target": "pisp", > + "vendor": "Arducam", > + "sku": "B0568", > + "algorithms": [ > > We need to coordinate a way with upstream linux kernel to > match/represent/identify sensor modules to elect a specific tuning file. I suppose we could also use the config file in the meantime, which means it needs to be reviewed. > > I have added the sku identifier to the imx415.json file to make it > explicitly clear which one is the Arducam file. > > Thoughts and comments or suggestions very much welcome on how we > progress this topic - but I'd like to get at least the data files in so > they can be used/referenced. I feel you. Acked-by: Paul Elder <paul.elder@ideasonboard.com> > > Kieran Bingham (2): > ipa: rpi: Add Arducam B0568 IMX335 tuning files > ipa: rpi: Add Arducam B0569 IMX415 tuning files > > src/ipa/rpi/pisp/data/imx335.json | 1475 +++++++++++++++++++++++ > src/ipa/rpi/pisp/data/imx415_b0569.json | 1475 +++++++++++++++++++++++ > src/ipa/rpi/pisp/data/meson.build | 2 + > src/ipa/rpi/vc4/data/imx335.json | 569 +++++++++ > src/ipa/rpi/vc4/data/imx415_b0569.json | 569 +++++++++ > src/ipa/rpi/vc4/data/meson.build | 2 + > 6 files changed, 4092 insertions(+) > create mode 100644 src/ipa/rpi/pisp/data/imx335.json > create mode 100644 src/ipa/rpi/pisp/data/imx415_b0569.json > create mode 100644 src/ipa/rpi/vc4/data/imx335.json > create mode 100644 src/ipa/rpi/vc4/data/imx415_b0569.json > > -- > 2.50.1 >