[v2,0/2] libcamera: simple: Support RPi's unicam CSI-2 receiver

23847 mbox series

Couple of patches to stream RPi+IMX219 setup with simple pipeline
handler and SoftISP.

Patch 1/2 fixes up bayer pattern changes on the sensor due to transforms
being applied, which then configures the video node correctly.

Patch 2/2 enables the unicam driver in simple pipeline handler with
SoftISP.

Changes in v2:
- Pass the updated format(Bayer applied with transforms) to the
  converter/SoftISP input configuration as well to configure them
  correctly.


Umang Jain (2):
  libcamera: simple: Detect Bayer pattern change during configure()
  libcamera: simple: Support RPi's unicam CSI-2 receiver

 src/libcamera/pipeline/simple/simple.cpp | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

Quoting Umang Jain (2025-07-18 10:40:46)
> Couple of patches to stream RPi+IMX219 setup with simple pipeline
> handler and SoftISP.
> 
> Patch 1/2 fixes up bayer pattern changes on the sensor due to transforms
> being applied, which then configures the video node correctly.
> 
> Patch 2/2 enables the unicam driver in simple pipeline handler with
> SoftISP.
> 
> Changes in v2:
> - Pass the updated format(Bayer applied with transforms) to the
>   converter/SoftISP input configuration as well to configure them
>   correctly.

I /really/ like the fact we're able to use unicam through the simple
pipeline handler.

But we can't merge this until the configuration file series lands.

Could you support testing / reviewing that series and build this series
on top of that please?

If we were to merge this - then out of the box Raspberry Pi users are
too likely to hit issues regarding which pipeline gets used.

--
Kieran



> Umang Jain (2):
>   libcamera: simple: Detect Bayer pattern change during configure()
>   libcamera: simple: Support RPi's unicam CSI-2 receiver
> 
>  src/libcamera/pipeline/simple/simple.cpp | 19 ++++++++++++++++---
>  1 file changed, 16 insertions(+), 3 deletions(-)
> 
> -- 
> 2.50.0
>

On Fri, Jul 18, 2025 at 12:36:36PM +0100, Kieran Bingham wrote:
> Quoting Umang Jain (2025-07-18 10:40:46)
> > Couple of patches to stream RPi+IMX219 setup with simple pipeline
> > handler and SoftISP.
> > 
> > Patch 1/2 fixes up bayer pattern changes on the sensor due to transforms
> > being applied, which then configures the video node correctly.
> > 
> > Patch 2/2 enables the unicam driver in simple pipeline handler with
> > SoftISP.
> > 
> > Changes in v2:
> > - Pass the updated format(Bayer applied with transforms) to the
> >   converter/SoftISP input configuration as well to configure them
> >   correctly.
> 
> I /really/ like the fact we're able to use unicam through the simple
> pipeline handler.
> 
> But we can't merge this until the configuration file series lands.
> 
> Could you support testing / reviewing that series and build this series
> on top of that please?
> 

The argument only applies to 2/2. I can drop it , given it can be enabled
in the configuration file when that work lands.

Patch 1/2 is independent - it detects Bayer patterns changes due to
transforms - and I am sure it has nothing to do with RPi. Any of
supported_devices[] where transform != Transform::Identity, will face
the issue. 

> If we were to merge this - then out of the box Raspberry Pi users are
> too likely to hit issues regarding which pipeline gets used.

Make sense.
> 
> --
> Kieran
> 
> 
> 
> > Umang Jain (2):
> >   libcamera: simple: Detect Bayer pattern change during configure()
> >   libcamera: simple: Support RPi's unicam CSI-2 receiver
> > 
> >  src/libcamera/pipeline/simple/simple.cpp | 19 ++++++++++++++++---
> >  1 file changed, 16 insertions(+), 3 deletions(-)
> > 
> > -- 
> > 2.50.0
> >