[v2,0/2] lc-compliance: Ensure stream's colorspace is set after validate()
mbox series

Message ID 20250701112922.62285-1-uajain@igalia.com
Headers show
Series
  • lc-compliance: Ensure stream's colorspace is set after validate()
Related show

Message

Umang Jain July 1, 2025, 11:29 a.m. UTC 
Patch 1/2 stems from a test result given by 2/2; virtual pipeline
handler now sets a colorspace.
See https://gitlab.freedesktop.org/camera/libcamera/-/jobs/79412875

Patch 2/2 is the lc-compliance check to ensure pipeline handlers
set colorspace after validate().

Umang Jain (2):
  pipeline: virtual: Provide and validate colorspace
  lc-compliance: Ensure stream's colorspace is set after validate()

 src/apps/lc-compliance/helpers/capture.cpp |  3 +++
 src/libcamera/pipeline/virtual/virtual.cpp | 12 ++++++++++++
 2 files changed, 15 insertions(+)

Comments

Umang Jain July 8, 2025, 6:08 a.m. UTC | #1 
Hi,

On Tue, Jul 01, 2025 at 04:59:20PM +0530, Umang Jain wrote:
> Patch 1/2 stems from a test result given by 2/2; virtual pipeline
> handler now sets a colorspace.
> See https://gitlab.freedesktop.org/camera/libcamera/-/jobs/79412875

Can this be kicked on CI once again, to ensure we don't face any errors?

Thanks!
> 
> Patch 2/2 is the lc-compliance check to ensure pipeline handlers
> set colorspace after validate().

> 
> Umang Jain (2):
>   pipeline: virtual: Provide and validate colorspace
>   lc-compliance: Ensure stream's colorspace is set after validate()
> 
>  src/apps/lc-compliance/helpers/capture.cpp |  3 +++
>  src/libcamera/pipeline/virtual/virtual.cpp | 12 ++++++++++++
>  2 files changed, 15 insertions(+)
> 
> -- 
> 2.50.0
>
Kieran Bingham July 8, 2025, 3:18 p.m. UTC | #2 
Quoting Umang Jain (2025-07-08 07:08:09)
> Hi,
> 
> On Tue, Jul 01, 2025 at 04:59:20PM +0530, Umang Jain wrote:
> > Patch 1/2 stems from a test result given by 2/2; virtual pipeline
> > handler now sets a colorspace.
> > See https://gitlab.freedesktop.org/camera/libcamera/-/jobs/79412875
> 
> Can this be kicked on CI once again, to ensure we don't face any errors?
> 

That already ran successfully -
https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1461603 so
this just needs RB tags.



> Thanks!
> > 
> > Patch 2/2 is the lc-compliance check to ensure pipeline handlers
> > set colorspace after validate().
> 
> > 
> > Umang Jain (2):
> >   pipeline: virtual: Provide and validate colorspace
> >   lc-compliance: Ensure stream's colorspace is set after validate()
> > 
> >  src/apps/lc-compliance/helpers/capture.cpp |  3 +++
> >  src/libcamera/pipeline/virtual/virtual.cpp | 12 ++++++++++++
> >  2 files changed, 15 insertions(+)
> > 
> > -- 
> > 2.50.0
> >
Robert Mader July 9, 2025, 7:52 p.m. UTC | #3 
On 08.07.25 17:18, Kieran Bingham wrote:
> That already ran successfully -
> https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1461603 so
> this just needs RB tags.

I just used this to implement colorspace support in the Pipewire plugin 
(https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/2448) 
- thus:

Tested-by: Robert Mader <robert.mader@collabora.com>