[v1,2/2] libcameara: sensor: Fix the gain delay for IMX283
diff mbox series

Message ID 20250521102208.989701-3-naush@raspberrypi.com
State New
Headers show
Series
  • RPi: Add IMX283 tunings
Related show

Commit Message

Naushir Patuck May 21, 2025, 10:19 a.m. UTC 
The IMX283 uses a gain delay of 1 instead of the current value of 2 as
defined in the sensor properties. Fix it.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
---
 src/libcamera/sensor/camera_sensor_properties.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Klug May 22, 2025, 9:54 a.m. UTC | #1 
Hi Naush,

Thank you for the patch. 

Quoting Naushir Patuck (2025-05-21 12:19:52)
> The IMX283 uses a gain delay of 1 instead of the current value of 2 as
> defined in the sensor properties. Fix it.

I had that fix locally due to my PFC measurements and wasn't yet sure if
I introduced an error on my side somewhere. Glad you confirmed my
measurements now.

Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>

> 
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
> ---
>  src/libcamera/sensor/camera_sensor_properties.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp
> index e2f518f9ea62..c9e9e148a1f0 100644
> --- a/src/libcamera/sensor/camera_sensor_properties.cpp
> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp
> @@ -194,7 +194,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>                         .testPatternModes = {},
>                         .sensorDelays = {
>                                 .exposureDelay = 2,
> -                               .gainDelay = 2,
> +                               .gainDelay = 1,
>                                 .vblankDelay = 2,
>                                 .hblankDelay = 2
>                         },
> -- 
> 2.43.0
>
Kieran Bingham May 22, 2025, 10:31 a.m. UTC | #2 
Quoting Naushir Patuck (2025-05-21 11:19:52)
> The IMX283 uses a gain delay of 1 instead of the current value of 2 as
> defined in the sensor properties. Fix it.
> 
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>

Great, I hadn't noticed any oscillations here - but I didn't check as
closely as Stefan had.


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

And pulling in Pauls ack for Patchwork state:

Acked-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/libcamera/sensor/camera_sensor_properties.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp
> index e2f518f9ea62..c9e9e148a1f0 100644
> --- a/src/libcamera/sensor/camera_sensor_properties.cpp
> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp
> @@ -194,7 +194,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>                         .testPatternModes = {},
>                         .sensorDelays = {
>                                 .exposureDelay = 2,
> -                               .gainDelay = 2,
> +                               .gainDelay = 1,
>                                 .vblankDelay = 2,
>                                 .hblankDelay = 2
>                         },
> -- 
> 2.43.0
>

Patch
diff mbox series 

diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp
index e2f518f9ea62..c9e9e148a1f0 100644
--- a/src/libcamera/sensor/camera_sensor_properties.cpp
+++ b/src/libcamera/sensor/camera_sensor_properties.cpp
@@ -194,7 +194,7 @@  const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
 			.testPatternModes = {},
 			.sensorDelays = {
 				.exposureDelay = 2,
-				.gainDelay = 2,
+				.gainDelay = 1,
 				.vblankDelay = 2,
 				.hblankDelay = 2
 			},