[v2,1/9] utils: gen-debug-controls: Remove line number from control description
diff mbox series

Message ID 20250411123641.2144530-2-stefan.klug@ideasonboard.com
State New
Headers show
Series
  • Wdr preparations
Related show

Commit Message

Stefan Klug April 11, 2025, 12:36 p.m. UTC 
The line numbers change so often that including them in the description
creates too much noise in control_ids_debug.yaml. Output the path only.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

---

Changes in v2:
- Collected tag
---
 utils/gen-debug-controls.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul Elder May 7, 2025, 6:24 p.m. UTC | #1 
On Fri, Apr 11, 2025 at 02:36:29PM +0200, Stefan Klug wrote:
> The line numbers change so often that including them in the description
> creates too much noise in control_ids_debug.yaml. Output the path only.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> 
> ---
> 
> Changes in v2:
> - Collected tag
> ---
>  utils/gen-debug-controls.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/gen-debug-controls.py b/utils/gen-debug-controls.py
> index 272597f4874f..53c8fa70d76d 100755
> --- a/utils/gen-debug-controls.py
> +++ b/utils/gen-debug-controls.py
> @@ -107,7 +107,7 @@ def main(argv):
>          p = m.file.relative_to(root_dir)
>          desc = {'type': m.type,
>                  'direction': 'out',
> -                'description': f'Debug control {m.name} found in {p}:{m.line}'}
> +                'description': f'Debug control {m.name} found in {p}'}
>          if m.size is not None:
>              desc['size'] = m.size
>  
> -- 
> 2.43.0
>
Isaac Scott May 15, 2025, 1:08 p.m. UTC | #2 
Hi Stefan,
Thank you for the patch.

Quoting Stefan Klug (2025-04-11 13:36:29)
> The line numbers change so often that including them in the description
> creates too much noise in control_ids_debug.yaml. Output the path only.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 

Reviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>

> ---
> 
> Changes in v2:
> - Collected tag
> ---
>  utils/gen-debug-controls.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/gen-debug-controls.py b/utils/gen-debug-controls.py
> index 272597f4874f..53c8fa70d76d 100755
> --- a/utils/gen-debug-controls.py
> +++ b/utils/gen-debug-controls.py
> @@ -107,7 +107,7 @@ def main(argv):
>          p = m.file.relative_to(root_dir)
>          desc = {'type': m.type,
>                  'direction': 'out',
> -                'description': f'Debug control {m.name} found in {p}:{m.line}'}
> +                'description': f'Debug control {m.name} found in {p}'}
>          if m.size is not None:
>              desc['size'] = m.size
>  
> -- 
> 2.43.0
>

Patch
diff mbox series 

diff --git a/utils/gen-debug-controls.py b/utils/gen-debug-controls.py
index 272597f4874f..53c8fa70d76d 100755
--- a/utils/gen-debug-controls.py
+++ b/utils/gen-debug-controls.py
@@ -107,7 +107,7 @@  def main(argv):
         p = m.file.relative_to(root_dir)
         desc = {'type': m.type,
                 'direction': 'out',
-                'description': f'Debug control {m.name} found in {p}:{m.line}'}
+                'description': f'Debug control {m.name} found in {p}'}
         if m.size is not None:
             desc['size'] = m.size