doc: document libtiff dependency for cam
diff mbox series

Message ID Z/oZIiLtzrTqJts9@duo.ucw.cz
State Accepted
Headers show
Series
  • doc: document libtiff dependency for cam
Related show

Commit Message

Pavel Machek April 12, 2025, 7:41 a.m. UTC 
DNG writing is useful when working with bayer data, but libtiff is
needed for that.
    
Signed-off-by: Pavel Machek <pavel@ucw.cz>

Comments

Kieran Bingham April 13, 2025, 5:44 p.m. UTC | #1 
Quoting Pavel Machek (2025-04-12 08:41:22)
> DNG writing is useful when working with bayer data, but libtiff is
> needed for that.
>     
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> diff --git a/README.rst b/README.rst
> index ae5126e2..31c27c87 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -83,6 +83,7 @@ for cam: [optional]
>          - libdrm-dev: Enables the KMS sink
>          - libjpeg-dev: Enables MJPEG on the SDL sink
>          - libsdl2-dev: Enables the SDL sink
> +        - libtiff-dev: For dng writing

I think DNG could be capitalised, but we can handle that while applying.


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

>  
>  for qcam: [optional]
>          libtiff-dev qt6-base-dev qt6-tools-dev-tools
> 
> -- 
> I don't work for Nazis and criminals, and neither should you.
> Boycott Putin, Trump, and Musk!
Laurent Pinchart April 13, 2025, 11:55 p.m. UTC | #2 
On Sun, Apr 13, 2025 at 06:44:43PM +0100, Kieran Bingham wrote:
> Quoting Pavel Machek (2025-04-12 08:41:22)
> > DNG writing is useful when working with bayer data, but libtiff is
> > needed for that.
> >     
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > 
> > diff --git a/README.rst b/README.rst
> > index ae5126e2..31c27c87 100644
> > --- a/README.rst
> > +++ b/README.rst
> > @@ -83,6 +83,7 @@ for cam: [optional]
> >          - libdrm-dev: Enables the KMS sink
> >          - libjpeg-dev: Enables MJPEG on the SDL sink
> >          - libsdl2-dev: Enables the SDL sink
> > +        - libtiff-dev: For dng writing
> 
> I think DNG could be capitalised, but we can handle that while applying.

I'd write

        - libtiff-dev: Enables writing DNG

to match the other entries.

> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> >  
> >  for qcam: [optional]
> >          libtiff-dev qt6-base-dev qt6-tools-dev-tools
> >

Patch
diff mbox series 

diff --git a/README.rst b/README.rst
index ae5126e2..31c27c87 100644
--- a/README.rst
+++ b/README.rst
@@ -83,6 +83,7 @@  for cam: [optional]
         - libdrm-dev: Enables the KMS sink
         - libjpeg-dev: Enables MJPEG on the SDL sink
         - libsdl2-dev: Enables the SDL sink
+        - libtiff-dev: For dng writing
 
 for qcam: [optional]
         libtiff-dev qt6-base-dev qt6-tools-dev-tools