[v2,7/9] pipeline: rkisp1: Add color space information to debug log

23164 diff mbox series

The 6.13 kernel driver has a bug the the JPEG/sYCC color space is not
applied correctly. Add the color space to the debug log output to be
able to detect that now and later.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

---

Changes in v2:
- Collected tag
---
 src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Quoting Stefan Klug (2025-04-11 13:36:35)
> The 6.13 kernel driver has a bug the the JPEG/sYCC color space is not

Was the bug introduced in 6.13? Or exists only in versions before 6.13 ?
or only since?

Would probably be helpful/useful to clarify when applying.

--
Kieran


> applied correctly. Add the color space to the debug log output to be
> able to detect that now and later.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
> ---
> 
> Changes in v2:
> - Collected tag
> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 9d7a3bd57ada..2708cecca0b0 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -891,7 +891,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)
>  
>         LOG(RkISP1, Debug)
>                 << "ISP output pad configured with " << format
> -               << " crop " << outputCrop;
> +               << " crop " << outputCrop
> +               << " color space " << ColorSpace::toString(format.colorSpace);
>  
>         IPACameraSensorInfo sensorInfo;
>         ret = data->sensor_->sensorInfo(&sensorInfo);
> -- 
> 2.43.0
>

Quoting Kieran Bingham (2025-04-12 13:50:50)
> Quoting Stefan Klug (2025-04-11 13:36:35)
> > The 6.13 kernel driver has a bug the the JPEG/sYCC color space is not
> 
> Was the bug introduced in 6.13? Or exists only in versions before 6.13 ?
> or only since?
> 
> Would probably be helpful/useful to clarify when applying.
> 
> --
> Kieran
> 
> 
> > applied correctly. Add the color space to the debug log output to be
> > able to detect that now and later.
> > 
> > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> > 
> > ---
> > 
> > Changes in v2:
> > - Collected tag
> > ---
> >  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > index 9d7a3bd57ada..2708cecca0b0 100644
> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > @@ -891,7 +891,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)
> >  
> >         LOG(RkISP1, Debug)
> >                 << "ISP output pad configured with " << format
> > -               << " crop " << outputCrop;
> > +               << " crop " << outputCrop
> > +               << " color space " << ColorSpace::toString(format.colorSpace);

Perhaps in fact we should change the format type here to report the
colorspace as part of it's string as we now do at:

 - https://git.libcamera.org/libcamera/libcamera.git/commit/?id=9b50d3c23dea1bc2882cd3e6566a3d4cb9f7296f

which produces
	1920x1080-YUYV/sYCC

style strings ?

--
Kieran


> >  
> >         IPACameraSensorInfo sensorInfo;
> >         ret = data->sensor_->sensorInfo(&sensorInfo);
> > -- 
> > 2.43.0
> >