| Message ID | 20250326075129.1705736-2-paul.elder@ideasonboard.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series |
|
| Related | show |
Hi, Le mercredi 26 mars 2025 à 16:51 +0900, Paul Elder a écrit : > Add an offset field to the frame metadata so that it can be reported > to > the application. > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > --- > include/libcamera/framebuffer.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/libcamera/framebuffer.h > b/include/libcamera/framebuffer.h > index ff83924300ac..f6fa1fd510a7 100644 > --- a/include/libcamera/framebuffer.h > +++ b/include/libcamera/framebuffer.h > @@ -30,6 +30,7 @@ struct FrameMetadata { > > struct Plane { > unsigned int bytesused; > + unsigned int offset; > }; Similar to what we did for "bytesused", documentation is needed in src/libcamera/buffer.cpp. Nicolas > > Status status;
Hi Paul, Thank you for the patch. On Wed, Mar 26, 2025 at 04:51:25PM +0900, Paul Elder wrote: > Add an offset field to the frame metadata so that it can be reported to > the application. We need documentation here. In particular, you'll need to explain how this differs from FrameBuffer::Plane::offset. > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > --- > include/libcamera/framebuffer.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h > index ff83924300ac..f6fa1fd510a7 100644 > --- a/include/libcamera/framebuffer.h > +++ b/include/libcamera/framebuffer.h > @@ -30,6 +30,7 @@ struct FrameMetadata { > > struct Plane { > unsigned int bytesused; > + unsigned int offset; > }; > > Status status;
diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h index ff83924300ac..f6fa1fd510a7 100644 --- a/include/libcamera/framebuffer.h +++ b/include/libcamera/framebuffer.h @@ -30,6 +30,7 @@ struct FrameMetadata { struct Plane { unsigned int bytesused; + unsigned int offset; }; Status status;
Add an offset field to the frame metadata so that it can be reported to the application. Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- include/libcamera/framebuffer.h | 1 + 1 file changed, 1 insertion(+)