[libcamera-devel,v2,0/1] rkisp1 pipeline test tool
mbox series

Message ID 20191024064008.25077-1-show.liu@linaro.org
Headers show
Series
  • rkisp1 pipeline test tool
Related show

Message

Show Liu Oct. 24, 2019, 6:40 a.m. UTC 
Hi Laurent,

Thanks for the review.
This is a patch v2 I modified according to your comments.

Show Liu (1):
  rkisp1: add pipeline test for rkisp1

 test/pipeline/meson.build                     |   1 +
 test/pipeline/rkisp1/meson.build              |  12 ++
 test/pipeline/rkisp1/rkisp1_pipeline_test.cpp | 112 ++++++++++++++++++
 3 files changed, 125 insertions(+)
 create mode 100644 test/pipeline/rkisp1/meson.build
 create mode 100644 test/pipeline/rkisp1/rkisp1_pipeline_test.cpp

Comments

Show Liu Jan. 7, 2020, 9:25 a.m. UTC | #1 
Hi Laurent,

The  v2 patch that I modified is according to your comments.
Would you please have a review and give me some suggestions?
Thank you.


Best Regards,
Show Liu


On Thu, Oct 24, 2019 at 2:40 PM Show Liu <show.liu@linaro.org> wrote:

> Hi Laurent,
>
> Thanks for the review.
> This is a patch v2 I modified according to your comments.
>
> Show Liu (1):
>   rkisp1: add pipeline test for rkisp1
>
>  test/pipeline/meson.build                     |   1 +
>  test/pipeline/rkisp1/meson.build              |  12 ++
>  test/pipeline/rkisp1/rkisp1_pipeline_test.cpp | 112 ++++++++++++++++++
>  3 files changed, 125 insertions(+)
>  create mode 100644 test/pipeline/rkisp1/meson.build
>  create mode 100644 test/pipeline/rkisp1/rkisp1_pipeline_test.cpp
>
> --
> 2.17.1
>
>
Laurent Pinchart Jan. 7, 2020, 4:03 p.m. UTC | #2 
Hi Show,

On Tue, Jan 07, 2020 at 05:25:47PM +0800, Show Liu wrote:
> Hi Laurent,
> 
> The  v2 patch that I modified is according to your comments.
> Would you please have a review and give me some suggestions?
> Thank you.

Sorry for the delay, your v2 felt through the cracks :-S Thank you for
pinging us, Kieran has now handled the review.

> On Thu, Oct 24, 2019 at 2:40 PM Show Liu <show.liu@linaro.org> wrote:
> 
>     Hi Laurent,
> 
>     Thanks for the review.
>     This is a patch v2 I modified according to your comments.
> 
>     Show Liu (1):
>       rkisp1: add pipeline test for rkisp1
> 
>      test/pipeline/meson.build                     |   1 +
>      test/pipeline/rkisp1/meson.build              |  12 ++
>      test/pipeline/rkisp1/rkisp1_pipeline_test.cpp | 112 ++++++++++++++++++
>      3 files changed, 125 insertions(+)
>      create mode 100644 test/pipeline/rkisp1/meson.build
>      create mode 100644 test/pipeline/rkisp1/rkisp1_pipeline_test.cpp