| Message ID | 20250109000942.1616565-12-paul.elder@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi Paul, Thank you for the patch. On Wed, Jan 08, 2025 at 06:09:41PM -0600, Paul Elder wrote: > Even though the new AeEnable control internally switches on and off the > sub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to > be declared as available. Report this control as available in the > rkisp1 IPA. > > Support for the control does not need to be added as it is handled by > the Camera class. It does not need to be handled in metadata either as > the new version of AeEnable is not returned in metadata. > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > New in v6 > --- > src/ipa/rkisp1/algorithms/agc.cpp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp > index 49c107c99..3c0cb01c7 100644 > --- a/src/ipa/rkisp1/algorithms/agc.cpp > +++ b/src/ipa/rkisp1/algorithms/agc.cpp > @@ -156,6 +156,8 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData) > ControlInfo(static_cast<int32_t>(controls::AnalogueGainModeAuto), > static_cast<int32_t>(controls::AnalogueGainModeManual), > static_cast<int32_t>(controls::AnalogueGainModeAuto)); > + /* \todo Move this to the Camera class */ > + context.ctrlMap[&controls::AeEnable] = ControlInfo(false, true); > context.ctrlMap.merge(controls()); > > return 0;
diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp index 49c107c99..3c0cb01c7 100644 --- a/src/ipa/rkisp1/algorithms/agc.cpp +++ b/src/ipa/rkisp1/algorithms/agc.cpp @@ -156,6 +156,8 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData) ControlInfo(static_cast<int32_t>(controls::AnalogueGainModeAuto), static_cast<int32_t>(controls::AnalogueGainModeManual), static_cast<int32_t>(controls::AnalogueGainModeAuto)); + /* \todo Move this to the Camera class */ + context.ctrlMap[&controls::AeEnable] = ControlInfo(false, true); context.ctrlMap.merge(controls()); return 0;
Even though the new AeEnable control internally switches on and off the sub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to be declared as available. Report this control as available in the rkisp1 IPA. Support for the control does not need to be added as it is handled by the Camera class. It does not need to be handled in metadata either as the new version of AeEnable is not returned in metadata. Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- New in v6 --- src/ipa/rkisp1/algorithms/agc.cpp | 2 ++ 1 file changed, 2 insertions(+)