| Message ID | 20241212102415.8057-1-david.plowman@raspberrypi.com |
|---|---|
| State | Accepted |
| Commit | 8e15010b7dfa9c2a68dd57f924b5603784be0e09 |
| Headers | show |
| Series |
|
| Related | show |
Quoting David Plowman (2024-12-12 10:24:15) > This is the minimum permitted difference between the frame length and > coarse exposure (both measured in lines). The correct value, taken > from the datasheet, is 48. Thank you, Happy to accept an RB tag from anyone else at Raspberry Pi who might have access to the datasheet, but also I trust you :D - and no one outside of Raspberry Pi (well, ok maybe Sony) could comment on this so simply: Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Will merge later after giving a bit of time for anyone else at RPi to comment, but I'll take no comment as an ack too! -- Kieran > Signed-off-by: David Plowman <david.plowman@raspberrypi.com> > --- > src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp > index ec83d9fd..16a017e9 100644 > --- a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp > @@ -66,7 +66,7 @@ private: > * Smallest difference between the frame length and integration time, > * in units of lines. > */ > - static constexpr int frameIntegrationDiff = 22; > + static constexpr int frameIntegrationDiff = 48; > /* Maximum frame length allowable for long exposure calculations. */ > static constexpr int frameLengthMax = 0xffdc; > /* Largest long exposure scale factor given as a left shift on the frame length. */ > -- > 2.39.5 >
Hi David, Thanks for the fix! On Thu, 12 Dec 2024 at 10:24, David Plowman <david.plowman@raspberrypi.com> wrote: > > This is the minimum permitted difference between the frame length and > coarse exposure (both measured in lines). The correct value, taken > from the datasheet, is 48. > > Signed-off-by: David Plowman <david.plowman@raspberrypi.com> Reviewed-by: Naushir Patuck <naush@raspberrypi.com> > --- > src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp > index ec83d9fd..16a017e9 100644 > --- a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp > @@ -66,7 +66,7 @@ private: > * Smallest difference between the frame length and integration time, > * in units of lines. > */ > - static constexpr int frameIntegrationDiff = 22; > + static constexpr int frameIntegrationDiff = 48; > /* Maximum frame length allowable for long exposure calculations. */ > static constexpr int frameLengthMax = 0xffdc; > /* Largest long exposure scale factor given as a left shift on the frame length. */ > -- > 2.39.5 >
Quoting Naushir Patuck (2024-12-12 10:32:48) > Hi David, > > Thanks for the fix! > > On Thu, 12 Dec 2024 at 10:24, David Plowman > <david.plowman@raspberrypi.com> wrote: > > > > This is the minimum permitted difference between the frame length and > > coarse exposure (both measured in lines). The correct value, taken > > from the datasheet, is 48. > > > > Signed-off-by: David Plowman <david.plowman@raspberrypi.com> > > Reviewed-by: Naushir Patuck <naush@raspberrypi.com> Thanks, Merging. > > > --- > > src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp > > index ec83d9fd..16a017e9 100644 > > --- a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp > > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp > > @@ -66,7 +66,7 @@ private: > > * Smallest difference between the frame length and integration time, > > * in units of lines. > > */ > > - static constexpr int frameIntegrationDiff = 22; > > + static constexpr int frameIntegrationDiff = 48; > > /* Maximum frame length allowable for long exposure calculations. */ > > static constexpr int frameLengthMax = 0xffdc; > > /* Largest long exposure scale factor given as a left shift on the frame length. */ > > -- > > 2.39.5 > >
diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp index ec83d9fd..16a017e9 100644 --- a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp +++ b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp @@ -66,7 +66,7 @@ private: * Smallest difference between the frame length and integration time, * in units of lines. */ - static constexpr int frameIntegrationDiff = 22; + static constexpr int frameIntegrationDiff = 48; /* Maximum frame length allowable for long exposure calculations. */ static constexpr int frameLengthMax = 0xffdc; /* Largest long exposure scale factor given as a left shift on the frame length. */
This is the minimum permitted difference between the frame length and coarse exposure (both measured in lines). The correct value, taken from the datasheet, is 48. Signed-off-by: David Plowman <david.plowman@raspberrypi.com> --- src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)