| Message ID | 20241113131256.3170817-5-paul.elder@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Paul, Thank you for the patch. On Wed, Nov 13, 2024 at 10:12:52PM +0900, Paul Elder wrote: > From: Jacopo Mondi <jacopo@jmondi.org> > > Replace the deprecated AeEnable control with ExposureTimeMode > in ipa_data_serialization test. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > > --- > No change in v3 > --- > test/serialization/ipa_data_serializer_test.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp > index aea63c73187e..1ec8b2b469b4 100644 > --- a/test/serialization/ipa_data_serializer_test.cpp > +++ b/test/serialization/ipa_data_serializer_test.cpp > @@ -29,7 +29,7 @@ using namespace std; > using namespace libcamera; > > static const ControlInfoMap Controls = ControlInfoMap({ > - { &controls::AeEnable, ControlInfo(false, true) }, > + { &controls::ExposureTimeMode, ControlInfo(false, true) }, The ExposureTimeMode control is an enum, not a boolean control. You could use AwbEnable instead, although that may disappear in the future as it gets reworked in a similar way as the AGC controls. DebugMetadataEnable is another option. > { &controls::ExposureTime, ControlInfo(0, 999999) }, > { &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) }, > { &controls::ColourGains, ControlInfo(0.0f, 32.0f) },
diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp index aea63c73187e..1ec8b2b469b4 100644 --- a/test/serialization/ipa_data_serializer_test.cpp +++ b/test/serialization/ipa_data_serializer_test.cpp @@ -29,7 +29,7 @@ using namespace std; using namespace libcamera; static const ControlInfoMap Controls = ControlInfoMap({ - { &controls::AeEnable, ControlInfo(false, true) }, + { &controls::ExposureTimeMode, ControlInfo(false, true) }, { &controls::ExposureTime, ControlInfo(0, 999999) }, { &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) }, { &controls::ColourGains, ControlInfo(0.0f, 32.0f) },