[0/1] Extend V4L2 videodevice to accept media request API
mbox series

Message ID 20241108075039.2116460-1-chenghaoyang@chromium.org
Headers show
Series
  • Extend V4L2 videodevice to accept media request API
Related show

Message

Cheng-Hao Yang Nov. 8, 2024, 7:38 a.m. UTC 
Hi folks,

In order to bind multiple buffers to the same request in ISP, like
mtkisp7, this patch extends V4L2 videodevice to accept media request
API.

This might be reviewed together with patch
`Add request API support for media controller device`. We might also
consider passing `MediaDevice::Request` instead of the file descriptor
integer.

This patch passes gitlab pipeline:
https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1306526

BR,
Harvey

Han-Lin Chen (1):
  libcamera: Extend V4L2 videodevice to accept media request API

 include/libcamera/internal/v4l2_videodevice.h | 2 +-
 src/libcamera/v4l2_videodevice.cpp            | 7 ++++++-
 2 files changed, 7 insertions(+), 2 deletions(-)

Comments

Laurent Pinchart Nov. 11, 2024, 7:15 a.m. UTC | #1 
Hi Harvey,

On Fri, Nov 08, 2024 at 07:38:26AM +0000, Harvey Yang wrote:
> Hi folks,
> 
> In order to bind multiple buffers to the same request in ISP, like
> mtkisp7, this patch extends V4L2 videodevice to accept media request
> API.
> 
> This might be reviewed together with patch
> `Add request API support for media controller device`. We might also
> consider passing `MediaDevice::Request` instead of the file descriptor
> integer.

When patches should be reviewed together, you can submit them as part of
the same series.

> This patch passes gitlab pipeline:
> https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1306526
> 
> BR,
> Harvey
> 
> Han-Lin Chen (1):
>   libcamera: Extend V4L2 videodevice to accept media request API
> 
>  include/libcamera/internal/v4l2_videodevice.h | 2 +-
>  src/libcamera/v4l2_videodevice.cpp            | 7 ++++++-
>  2 files changed, 7 insertions(+), 2 deletions(-)