| Message ID | 20241015082207.640731-2-libcamerabmw+ml@lsmod.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Bernhard, Thank you for the patch. On Tue, Oct 15, 2024 at 10:20:25AM +0200, libcamerabmw+ml@lsmod.de wrote: > From: "Bernhard M. Wiedemann" <bwiedemann@suse.de> > > without this patch, openSUSE's debugsource package would vary over time, > breaking reproducible builds. > Also a copyright of 2025 is factually wrong, > because nobody did anything copyright-worthy in that year. > If updating the year manually is too hard (it is optional anyway), > using the mtime of input file(s) could work as well. > > By moving the year to tracepoints.h.in it can easily be updated > along with the content. > > The diff was: > /usr/src/debug/libcamera-0.3.1/x86_64-suse-linux/include/libcamera/internal/tracepoints.h 2024-08-20 09:37:46.000000000 +0200 > @@ -1,6 +1,6 @@ > /* SPDX-License-Identifier: LGPL-2.1-or-later */ > /* > - * Copyright (C) 2024, Google Inc. > + * Copyright (C) 2025, Google Inc. I'm a bit confused, where does this diff come from ? > > Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de> > --- > include/libcamera/internal/tracepoints.h.in | 2 +- > utils/codegen/gen-tp-header.py | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/include/libcamera/internal/tracepoints.h.in b/include/libcamera/internal/tracepoints.h.in > index f0962091..ff5c581b 100644 > --- a/include/libcamera/internal/tracepoints.h.in > +++ b/include/libcamera/internal/tracepoints.h.in > @@ -1,6 +1,6 @@ > /* SPDX-License-Identifier: LGPL-2.1-or-later */ > /* > - * Copyright (C) {{year}}, Google Inc. > + * Copyright (C) 2024, Google Inc. This should be 2020, the file hasn't received any copyrightable change since then. > * > * Tracepoints with lttng > * > diff --git a/utils/codegen/gen-tp-header.py b/utils/codegen/gen-tp-header.py > index 83606c32..6769c7ce 100755 > --- a/utils/codegen/gen-tp-header.py > +++ b/utils/codegen/gen-tp-header.py > @@ -6,7 +6,6 @@ > # > # Generate header file to contain lttng tracepoints > > -import datetime > import jinja2 > import pathlib > import os > @@ -20,7 +19,6 @@ def main(argv): > output = argv[2] > template = argv[3] > > - year = datetime.datetime.now().year > path = pathlib.Path(output).absolute().relative_to(argv[1]) > > source = '' > @@ -28,7 +26,7 @@ def main(argv): > source += open(fname, 'r', encoding='utf-8').read() + '\n\n' > > template = jinja2.Template(open(template, 'r', encoding='utf-8').read()) > - string = template.render(year=year, path=path, source=source) > + string = template.render(path=path, source=source) Looks good. > > f = open(output, 'w', encoding='utf-8').write(string) >
diff --git a/include/libcamera/internal/tracepoints.h.in b/include/libcamera/internal/tracepoints.h.in index f0962091..ff5c581b 100644 --- a/include/libcamera/internal/tracepoints.h.in +++ b/include/libcamera/internal/tracepoints.h.in @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ /* - * Copyright (C) {{year}}, Google Inc. + * Copyright (C) 2024, Google Inc. * * Tracepoints with lttng * diff --git a/utils/codegen/gen-tp-header.py b/utils/codegen/gen-tp-header.py index 83606c32..6769c7ce 100755 --- a/utils/codegen/gen-tp-header.py +++ b/utils/codegen/gen-tp-header.py @@ -6,7 +6,6 @@ # # Generate header file to contain lttng tracepoints -import datetime import jinja2 import pathlib import os @@ -20,7 +19,6 @@ def main(argv): output = argv[2] template = argv[3] - year = datetime.datetime.now().year path = pathlib.Path(output).absolute().relative_to(argv[1]) source = '' @@ -28,7 +26,7 @@ def main(argv): source += open(fname, 'r', encoding='utf-8').read() + '\n\n' template = jinja2.Template(open(template, 'r', encoding='utf-8').read()) - string = template.render(year=year, path=path, source=source) + string = template.render(path=path, source=source) f = open(output, 'w', encoding='utf-8').write(string)