[libcamera-devel,v2,00/10] libcamera: Fixes found while working on new
mbox series

Message ID 20191120015506.362440-1-niklas.soderlund@ragnatech.se
Headers show
Series
  • libcamera: Fixes found while working on new
Related show

Message

Niklas Söderlund Nov. 20, 2019, 1:54 a.m. UTC
Hi,

This series is a random collection of small fixes I encountered while
working on the new buffer API. They could hopefully be merged without
much controversy opposed to the real buffer API change.

* Changes since v2
- Fixed HAL build which was not consider in v1.
- Replaced 8/10 with a new version taking a new approach to solving the 
  same problem. See v2 8/10 for more info.
- Collected tags.

Niklas Söderlund (10):
  libcamera: buffer: Drop forward declaration of BufferPool
  libcamera: buffer: Plane: Drop friend statement
  libcamera: buffer: Drop friend statement
  libcamera: camera: Remove explicit stream to buffer map in
    requestCompleted signal
  cam: BufferWriter: Use the libcamera namespace
  libcamera: v4l2_videodevice: Simplify error checking for
    requestBuffers()
  libcamera: pipeline_handler: Do not use argument as local variable
  libcamera: pipeline: Rework PipelineHandler::queueRequest()
  cam: Store camera as shared pointer everywhere
  libcamera: pipeline: Drop forward declaration of BufferPool

 include/libcamera/buffer.h               |  4 ---
 include/libcamera/camera.h               |  3 +-
 src/android/camera_device.cpp            |  4 +--
 src/android/camera_device.h              |  3 +-
 src/cam/buffer_writer.cpp                |  8 +++--
 src/cam/capture.cpp                      |  6 ++--
 src/cam/capture.h                        |  7 ++--
 src/cam/main.cpp                         |  2 +-
 src/libcamera/camera.cpp                 |  2 +-
 src/libcamera/include/pipeline_handler.h |  5 +--
 src/libcamera/pipeline/ipu3/ipu3.cpp     |  6 ++--
 src/libcamera/pipeline/rkisp1/rkisp1.cpp |  7 ++--
 src/libcamera/pipeline/uvcvideo.cpp      |  6 ++--
 src/libcamera/pipeline/vimc.cpp          |  6 ++--
 src/libcamera/pipeline_handler.cpp       | 43 ++++++++++++++++--------
 src/libcamera/v4l2_videodevice.cpp       | 31 ++++++-----------
 src/qcam/main_window.cpp                 |  5 +--
 src/qcam/main_window.h                   |  4 +--
 test/camera/capture.cpp                  |  4 ++-
 19 files changed, 76 insertions(+), 80 deletions(-)

Comments

Niklas Söderlund Nov. 20, 2019, 4:25 p.m. UTC | #1
Hi,

I have now pushed all fixes but 8/10.

On 2019-11-20 02:54:56 +0100, Niklas Söderlund wrote:
> Hi,
> 
> This series is a random collection of small fixes I encountered while
> working on the new buffer API. They could hopefully be merged without
> much controversy opposed to the real buffer API change.
> 
> * Changes since v2
> - Fixed HAL build which was not consider in v1.
> - Replaced 8/10 with a new version taking a new approach to solving the 
>   same problem. See v2 8/10 for more info.
> - Collected tags.
> 
> Niklas Söderlund (10):
>   libcamera: buffer: Drop forward declaration of BufferPool
>   libcamera: buffer: Plane: Drop friend statement
>   libcamera: buffer: Drop friend statement
>   libcamera: camera: Remove explicit stream to buffer map in
>     requestCompleted signal
>   cam: BufferWriter: Use the libcamera namespace
>   libcamera: v4l2_videodevice: Simplify error checking for
>     requestBuffers()
>   libcamera: pipeline_handler: Do not use argument as local variable
>   libcamera: pipeline: Rework PipelineHandler::queueRequest()
>   cam: Store camera as shared pointer everywhere
>   libcamera: pipeline: Drop forward declaration of BufferPool
> 
>  include/libcamera/buffer.h               |  4 ---
>  include/libcamera/camera.h               |  3 +-
>  src/android/camera_device.cpp            |  4 +--
>  src/android/camera_device.h              |  3 +-
>  src/cam/buffer_writer.cpp                |  8 +++--
>  src/cam/capture.cpp                      |  6 ++--
>  src/cam/capture.h                        |  7 ++--
>  src/cam/main.cpp                         |  2 +-
>  src/libcamera/camera.cpp                 |  2 +-
>  src/libcamera/include/pipeline_handler.h |  5 +--
>  src/libcamera/pipeline/ipu3/ipu3.cpp     |  6 ++--
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp |  7 ++--
>  src/libcamera/pipeline/uvcvideo.cpp      |  6 ++--
>  src/libcamera/pipeline/vimc.cpp          |  6 ++--
>  src/libcamera/pipeline_handler.cpp       | 43 ++++++++++++++++--------
>  src/libcamera/v4l2_videodevice.cpp       | 31 ++++++-----------
>  src/qcam/main_window.cpp                 |  5 +--
>  src/qcam/main_window.h                   |  4 +--
>  test/camera/capture.cpp                  |  4 ++-
>  19 files changed, 76 insertions(+), 80 deletions(-)
> 
> -- 
> 2.24.0
>