[0/3] qcam: Fix GL renderer on Qt 6
mbox series

Message ID 20240910234649.28591-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • qcam: Fix GL renderer on Qt 6
Related show

Message

Laurent Pinchart Sept. 10, 2024, 11:46 p.m. UTC 
Hello,

This small series fixes the GL render with Qt 6. The fix is actually in
patch 1/3 only, with patches 2/3 and 3/3 bringing additional cleanups
and improvements.

Laurent Pinchart (3):
  qcam: viewfinder_gl: Fix binding of vertex buffer and shader program
  qcam: viewfinder_gl: Drop duplicate glClearColor()
  qcam: viewfinder_gl: Render image centered in letterbox

 src/apps/qcam/assets/shader/bayer_8.vert  |  4 +-
 src/apps/qcam/assets/shader/identity.vert |  3 +-
 src/apps/qcam/viewfinder_gl.cpp           | 54 ++++++++++++++---------
 src/apps/qcam/viewfinder_gl.h             |  2 +-
 4 files changed, 39 insertions(+), 24 deletions(-)


base-commit: f75b8dd26feaca86701704390dea18c71e2f0350

Comments

Kieran Bingham Sept. 11, 2024, 7:58 a.m. UTC | #1 
Quoting Laurent Pinchart (2024-09-11 00:46:46)
> Hello,
> 
> This small series fixes the GL render with Qt 6. The fix is actually in
> patch 1/3 only, with patches 2/3 and 3/3 bringing additional cleanups
> and improvements.
> 

Thanks - just re-tested and can confirm it's working again on my X13s
with qcam -r gles - and now the behaviour of both with and without is
matched for the letter boxing.

Tested-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> Laurent Pinchart (3):
>   qcam: viewfinder_gl: Fix binding of vertex buffer and shader program
>   qcam: viewfinder_gl: Drop duplicate glClearColor()
>   qcam: viewfinder_gl: Render image centered in letterbox
> 
>  src/apps/qcam/assets/shader/bayer_8.vert  |  4 +-
>  src/apps/qcam/assets/shader/identity.vert |  3 +-
>  src/apps/qcam/viewfinder_gl.cpp           | 54 ++++++++++++++---------
>  src/apps/qcam/viewfinder_gl.h             |  2 +-
>  4 files changed, 39 insertions(+), 24 deletions(-)
> 
> 
> base-commit: f75b8dd26feaca86701704390dea18c71e2f0350
> -- 
> Regards,
> 
> Laurent Pinchart
>
Neal Gompa Sept. 12, 2024, 8:45 a.m. UTC | #2 
On Wed, Sep 11, 2024 at 1:47 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hello,
>
> This small series fixes the GL render with Qt 6. The fix is actually in
> patch 1/3 only, with patches 2/3 and 3/3 bringing additional cleanups
> and improvements.
>
> Laurent Pinchart (3):
>   qcam: viewfinder_gl: Fix binding of vertex buffer and shader program
>   qcam: viewfinder_gl: Drop duplicate glClearColor()
>   qcam: viewfinder_gl: Render image centered in letterbox
>
>  src/apps/qcam/assets/shader/bayer_8.vert  |  4 +-
>  src/apps/qcam/assets/shader/identity.vert |  3 +-
>  src/apps/qcam/viewfinder_gl.cpp           | 54 ++++++++++++++---------
>  src/apps/qcam/viewfinder_gl.h             |  2 +-
>  4 files changed, 39 insertions(+), 24 deletions(-)
>
>
> base-commit: f75b8dd26feaca86701704390dea18c71e2f0350
> --

LGTM.

Reviewed-by: Neal Gompa <neal@gompa.dev>