[v2,16/20] libcamera: libcamera: Add missing includes
diff mbox series

Message ID 20240830152721.1420313-17-mzamazal@redhat.com
State Accepted
Headers show
Series
  • Remove unused includes
Related show

Commit Message

Milan Zamazal Aug. 30, 2024, 3:27 p.m. UTC
Let's add direct includes for classes currently included indirectly,
through other header files.

Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
---
 src/libcamera/formats.cpp             | 2 ++
 src/libcamera/ipa_data_serializer.cpp | 2 ++
 2 files changed, 4 insertions(+)

Comments

Laurent Pinchart Aug. 31, 2024, 12:32 a.m. UTC | #1
Hi Milan,

Thank you for the patch.

On Fri, Aug 30, 2024 at 05:27:13PM +0200, Milan Zamazal wrote:
> Let's add direct includes for classes currently included indirectly,
> through other header files.
> 
> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/formats.cpp             | 2 ++
>  src/libcamera/ipa_data_serializer.cpp | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp
> index 3ee89590..dbefb094 100644
> --- a/src/libcamera/formats.cpp
> +++ b/src/libcamera/formats.cpp
> @@ -7,6 +7,8 @@
>  
>  #include "libcamera/internal/formats.h"
>  
> +#include <map>
> +
>  #include <libcamera/base/log.h>
>  #include <libcamera/base/utils.h>
>  
> diff --git a/src/libcamera/ipa_data_serializer.cpp b/src/libcamera/ipa_data_serializer.cpp
> index 3e9bef08..f6dd7e6f 100644
> --- a/src/libcamera/ipa_data_serializer.cpp
> +++ b/src/libcamera/ipa_data_serializer.cpp
> @@ -11,6 +11,8 @@
>  
>  #include <libcamera/base/log.h>
>  
> +#include "libcamera/internal/byte_stream_buffer.h"
> +
>  /**
>   * \file ipa_data_serializer.h
>   * \brief IPA Data Serializer

Patch
diff mbox series

diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp
index 3ee89590..dbefb094 100644
--- a/src/libcamera/formats.cpp
+++ b/src/libcamera/formats.cpp
@@ -7,6 +7,8 @@ 
 
 #include "libcamera/internal/formats.h"
 
+#include <map>
+
 #include <libcamera/base/log.h>
 #include <libcamera/base/utils.h>
 
diff --git a/src/libcamera/ipa_data_serializer.cpp b/src/libcamera/ipa_data_serializer.cpp
index 3e9bef08..f6dd7e6f 100644
--- a/src/libcamera/ipa_data_serializer.cpp
+++ b/src/libcamera/ipa_data_serializer.cpp
@@ -11,6 +11,8 @@ 
 
 #include <libcamera/base/log.h>
 
+#include "libcamera/internal/byte_stream_buffer.h"
+
 /**
  * \file ipa_data_serializer.h
  * \brief IPA Data Serializer