[03/10] libcamera: Drop remaining file names from header comment blocks
diff mbox series

Message ID 20240809005914.20662-4-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • libcamera: Improve code generation for controls
Related show

Commit Message

Laurent Pinchart Aug. 9, 2024, 12:59 a.m. UTC
Commit 829acb3ab0b1 ("libcamera: Drop file name from header comment
blocks in templates") dropped file names from header comment blocks in
templates, but forget the control and property .cpp templates. Fix it.

Fixes: 829acb3ab0b1 ("libcamera: Drop file name from header comment blocks in templates")
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/control_ids.cpp.in  | 2 +-
 src/libcamera/property_ids.cpp.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Daniel Scally Aug. 14, 2024, 9:12 p.m. UTC | #1
Hi Laurent

On 09/08/2024 01:59, Laurent Pinchart wrote:
> Commit 829acb3ab0b1 ("libcamera: Drop file name from header comment
> blocks in templates") dropped file names from header comment blocks in
> templates, but forget the control and property .cpp templates. Fix it.
>
> Fixes: 829acb3ab0b1 ("libcamera: Drop file name from header comment blocks in templates")
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
>   src/libcamera/control_ids.cpp.in  | 2 +-
>   src/libcamera/property_ids.cpp.in | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/libcamera/control_ids.cpp.in b/src/libcamera/control_ids.cpp.in
> index d283c1c1f401..0b028c92d852 100644
> --- a/src/libcamera/control_ids.cpp.in
> +++ b/src/libcamera/control_ids.cpp.in
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2019, Google Inc.
>    *
> - * control_ids.cpp : Control ID list
> + * Control ID list
>    *
>    * This file is auto-generated. Do not edit.
>    */
> diff --git a/src/libcamera/property_ids.cpp.in b/src/libcamera/property_ids.cpp.in
> index 8b274c38c74b..2d3f192eb6ef 100644
> --- a/src/libcamera/property_ids.cpp.in
> +++ b/src/libcamera/property_ids.cpp.in
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2019, Google Inc.
>    *
> - * property_ids.cpp : Property ID list
> + * Property ID list
>    *
>    * This file is auto-generated. Do not edit.
>    */
Paul Elder Aug. 15, 2024, 1:39 a.m. UTC | #2
On Fri, Aug 09, 2024 at 03:59:07AM +0300, Laurent Pinchart wrote:
> Commit 829acb3ab0b1 ("libcamera: Drop file name from header comment
> blocks in templates") dropped file names from header comment blocks in
> templates, but forget the control and property .cpp templates. Fix it.

s/forget/forgot/

> 
> Fixes: 829acb3ab0b1 ("libcamera: Drop file name from header comment blocks in templates")
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/libcamera/control_ids.cpp.in  | 2 +-
>  src/libcamera/property_ids.cpp.in | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/control_ids.cpp.in b/src/libcamera/control_ids.cpp.in
> index d283c1c1f401..0b028c92d852 100644
> --- a/src/libcamera/control_ids.cpp.in
> +++ b/src/libcamera/control_ids.cpp.in
> @@ -2,7 +2,7 @@
>  /*
>   * Copyright (C) 2019, Google Inc.
>   *
> - * control_ids.cpp : Control ID list
> + * Control ID list
>   *
>   * This file is auto-generated. Do not edit.
>   */
> diff --git a/src/libcamera/property_ids.cpp.in b/src/libcamera/property_ids.cpp.in
> index 8b274c38c74b..2d3f192eb6ef 100644
> --- a/src/libcamera/property_ids.cpp.in
> +++ b/src/libcamera/property_ids.cpp.in
> @@ -2,7 +2,7 @@
>  /*
>   * Copyright (C) 2019, Google Inc.
>   *
> - * property_ids.cpp : Property ID list
> + * Property ID list
>   *
>   * This file is auto-generated. Do not edit.
>   */

Patch
diff mbox series

diff --git a/src/libcamera/control_ids.cpp.in b/src/libcamera/control_ids.cpp.in
index d283c1c1f401..0b028c92d852 100644
--- a/src/libcamera/control_ids.cpp.in
+++ b/src/libcamera/control_ids.cpp.in
@@ -2,7 +2,7 @@ 
 /*
  * Copyright (C) 2019, Google Inc.
  *
- * control_ids.cpp : Control ID list
+ * Control ID list
  *
  * This file is auto-generated. Do not edit.
  */
diff --git a/src/libcamera/property_ids.cpp.in b/src/libcamera/property_ids.cpp.in
index 8b274c38c74b..2d3f192eb6ef 100644
--- a/src/libcamera/property_ids.cpp.in
+++ b/src/libcamera/property_ids.cpp.in
@@ -2,7 +2,7 @@ 
 /*
  * Copyright (C) 2019, Google Inc.
  *
- * property_ids.cpp : Property ID list
+ * Property ID list
  *
  * This file is auto-generated. Do not edit.
  */