| Message ID | 20240813141429.2042369-1-kieran.bingham@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Kieran Bingham <kieran.bingham@ideasonboard.com> writes: > Fix a small typo in the comment regarding the default routing > table configuration. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/pipeline/simple/simple.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp > index 1e7ec7d97255..49f9137b9363 100644 > --- a/src/libcamera/pipeline/simple/simple.cpp > +++ b/src/libcamera/pipeline/simple/simple.cpp > @@ -1617,7 +1617,7 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator) > /* > * Reset the routing table to its default state > * to make sure entities are enumerate according enumerated ? > - * to the defaul routing configuration. > + * to the default routing configuration. > */ > ret = resetRoutingTable(subdev.get()); > if (ret) { Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
Quoting Milan Zamazal (2024-08-13 15:40:51) > Kieran Bingham <kieran.bingham@ideasonboard.com> writes: > > > Fix a small typo in the comment regarding the default routing > > table configuration. > > > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > --- > > src/libcamera/pipeline/simple/simple.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp > > index 1e7ec7d97255..49f9137b9363 100644 > > --- a/src/libcamera/pipeline/simple/simple.cpp > > +++ b/src/libcamera/pipeline/simple/simple.cpp > > @@ -1617,7 +1617,7 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator) > > /* > > * Reset the routing table to its default state > > * to make sure entities are enumerate according > > enumerated ? Indeed, I'll change both in the same patch and update the commit message. > > > - * to the defaul routing configuration. > > + * to the default routing configuration. > > */ > > ret = resetRoutingTable(subdev.get()); > > if (ret) { > > Reviewed-by: Milan Zamazal <mzamazal@redhat.com> >
On Tue, Aug 13, 2024 at 04:12:18PM +0100, Kieran Bingham wrote: > Quoting Milan Zamazal (2024-08-13 15:40:51) > > Kieran Bingham <kieran.bingham@ideasonboard.com> writes: > > > > > Fix a small typo in the comment regarding the default routing > > > table configuration. > > > > > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > --- > > > src/libcamera/pipeline/simple/simple.cpp | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp > > > index 1e7ec7d97255..49f9137b9363 100644 > > > --- a/src/libcamera/pipeline/simple/simple.cpp > > > +++ b/src/libcamera/pipeline/simple/simple.cpp > > > @@ -1617,7 +1617,7 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator) > > > /* > > > * Reset the routing table to its default state > > > * to make sure entities are enumerate according > > > > enumerated ? > > Indeed, I'll change both in the same patch and update the commit > message. And you can then push with my Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > - * to the defaul routing configuration. > > > + * to the default routing configuration. > > > */ > > > ret = resetRoutingTable(subdev.get()); > > > if (ret) { > > > > Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index 1e7ec7d97255..49f9137b9363 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -1617,7 +1617,7 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator) /* * Reset the routing table to its default state * to make sure entities are enumerate according - * to the defaul routing configuration. + * to the default routing configuration. */ ret = resetRoutingTable(subdev.get()); if (ret) {
Fix a small typo in the comment regarding the default routing table configuration. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- src/libcamera/pipeline/simple/simple.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)