[v3,02/23] libcamera: ipa: ipu3: Drop ipa_interface.h header
diff mbox series

Message ID 20240717085444.289997-3-mzamazal@redhat.com
State Superseded
Headers show
Series
  • Software ISP refactoring
Related show

Commit Message

Milan Zamazal July 17, 2024, 8:54 a.m. UTC 
From: Umang Jain <umang.jain@ideasonboard.com>

The ipa_interface.h header is already included in ipu3_ipa_interface.h
generated from module_ipa_interface.h.tmpl. Drop it as deemed redundant.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
 src/ipa/ipu3/ipu3.cpp | 1 -
 1 file changed, 1 deletion(-)

Comments

Laurent Pinchart Aug. 12, 2024, 12:26 p.m. UTC | #1 
On Wed, Jul 17, 2024 at 10:54:23AM +0200, Milan Zamazal wrote:
> From: Umang Jain <umang.jain@ideasonboard.com>
> 
> The ipa_interface.h header is already included in ipu3_ipa_interface.h
> generated from module_ipa_interface.h.tmpl. Drop it as deemed redundant.

For the reason explained in the review of 01/23, this patch should be
dropped.

> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>  src/ipa/ipu3/ipu3.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> index cdcdf1fb..dca07970 100644
> --- a/src/ipa/ipu3/ipu3.cpp
> +++ b/src/ipa/ipu3/ipu3.cpp
> @@ -24,7 +24,6 @@
>  
>  #include <libcamera/control_ids.h>
>  #include <libcamera/framebuffer.h>
> -#include <libcamera/ipa/ipa_interface.h>
>  #include <libcamera/ipa/ipa_module_info.h>
>  #include <libcamera/ipa/ipu3_ipa_interface.h>
>  #include <libcamera/request.h>

Patch
diff mbox series 

diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
index cdcdf1fb..dca07970 100644
--- a/src/ipa/ipu3/ipu3.cpp
+++ b/src/ipa/ipu3/ipu3.cpp
@@ -24,7 +24,6 @@ 
 
 #include <libcamera/control_ids.h>
 #include <libcamera/framebuffer.h>
-#include <libcamera/ipa/ipa_interface.h>
 #include <libcamera/ipa/ipa_module_info.h>
 #include <libcamera/ipa/ipu3_ipa_interface.h>
 #include <libcamera/request.h>