| Message ID | 20240810005840.20841-3-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 2d5cea862dbc369d848fb1b745e61a34658c3a0f |
| Headers | show |
| Series |
|
| Related | show |
Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes: > When debugging issues with the Commit class, a __repr__ method proved to > be useful to quickly print all the parsed information about a commit. To > avoid reimplementing the method over and over again in the future, add > it to the class, even if it is not actually used. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Milan Zamazal <mzamazal@redhat.com> > --- > utils/checkstyle.py | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/utils/checkstyle.py b/utils/checkstyle.py > index 2b1e1f6c1b9e..c9e41d4149f7 100755 > --- a/utils/checkstyle.py > +++ b/utils/checkstyle.py > @@ -248,6 +248,17 @@ class Commit: > stdout=subprocess.PIPE).stdout.decode('utf-8') > self._files = [CommitFile(f) for f in ret.splitlines()] > > + def __repr__(self): > + return '\n'.join([ > + f'commit {self.commit}', > + f'Author: {self.author}', > + f'', > + f' {self.title}', > + '', > + '\n'.join([line and f' {line}' or '' for line in self._body]), > + 'Trailers:', > + ] + self.trailers) > + > def files(self, filter='AMR'): > return [f.filename for f in self._files if f.status in filter]
Hi Laurent On 10/08/2024 01:58, Laurent Pinchart wrote: > When debugging issues with the Commit class, a __repr__ method proved to > be useful to quickly print all the parsed information about a commit. To > avoid reimplementing the method over and over again in the future, add > it to the class, even if it is not actually used. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> > utils/checkstyle.py | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/utils/checkstyle.py b/utils/checkstyle.py > index 2b1e1f6c1b9e..c9e41d4149f7 100755 > --- a/utils/checkstyle.py > +++ b/utils/checkstyle.py > @@ -248,6 +248,17 @@ class Commit: > stdout=subprocess.PIPE).stdout.decode('utf-8') > self._files = [CommitFile(f) for f in ret.splitlines()] > > + def __repr__(self): > + return '\n'.join([ > + f'commit {self.commit}', > + f'Author: {self.author}', > + f'', > + f' {self.title}', > + '', > + '\n'.join([line and f' {line}' or '' for line in self._body]), > + 'Trailers:', > + ] + self.trailers) > + > def files(self, filter='AMR'): > return [f.filename for f in self._files if f.status in filter] >
diff --git a/utils/checkstyle.py b/utils/checkstyle.py index 2b1e1f6c1b9e..c9e41d4149f7 100755 --- a/utils/checkstyle.py +++ b/utils/checkstyle.py @@ -248,6 +248,17 @@ class Commit: stdout=subprocess.PIPE).stdout.decode('utf-8') self._files = [CommitFile(f) for f in ret.splitlines()] + def __repr__(self): + return '\n'.join([ + f'commit {self.commit}', + f'Author: {self.author}', + f'', + f' {self.title}', + '', + '\n'.join([line and f' {line}' or '' for line in self._body]), + 'Trailers:', + ] + self.trailers) + def files(self, filter='AMR'): return [f.filename for f in self._files if f.status in filter]
When debugging issues with the Commit class, a __repr__ method proved to be useful to quickly print all the parsed information about a commit. To avoid reimplementing the method over and over again in the future, add it to the class, even if it is not actually used. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- utils/checkstyle.py | 11 +++++++++++ 1 file changed, 11 insertions(+)