[v5,13/18] libcamera: Don't add libcamera_public_headers to libcamera_public_sources

20799 diff mbox series

Now that libcamera_internal_sources is separate from
libcamera_internal_headers, perform the same split for
libcamera_public_sources and libcamera_public_headers to ensure
consistency of the build system variables.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/meson.build | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

On 05/08/2024 15:36, Laurent Pinchart wrote:
> Now that libcamera_internal_sources is separate from
> libcamera_internal_headers, perform the same split for
> libcamera_public_sources and libcamera_public_headers to ensure
> consistency of the build system variables.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
Also makes sense to me: Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
>   src/libcamera/meson.build | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> index 6a7c9d77dfd8..c3efc5278ec8 100644
> --- a/src/libcamera/meson.build
> +++ b/src/libcamera/meson.build
> @@ -54,8 +54,6 @@ libcamera_internal_sources = files([
>       'yaml_parser.cpp',
>   ])
>   
> -libcamera_public_sources += libcamera_public_headers
> -
>   includes = [
>       libcamera_includes,
>   ]
> @@ -193,6 +191,7 @@ libcamera_deps += [
>   
>   libcamera = shared_library('libcamera',
>                              [
> +                               libcamera_public_headers,
>                                  libcamera_public_sources,
>                                  libcamera_ipa_headers,
>                                  libcamera_internal_headers,

Quoting Laurent Pinchart (2024-08-05 15:36:49)
> Now that libcamera_internal_sources is separate from
> libcamera_internal_headers, perform the same split for
> libcamera_public_sources and libcamera_public_headers to ensure
> consistency of the build system variables.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/libcamera/meson.build | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> index 6a7c9d77dfd8..c3efc5278ec8 100644
> --- a/src/libcamera/meson.build
> +++ b/src/libcamera/meson.build
> @@ -54,8 +54,6 @@ libcamera_internal_sources = files([
>      'yaml_parser.cpp',
>  ])
>  
> -libcamera_public_sources += libcamera_public_headers
> -
>  includes = [
>      libcamera_includes,
>  ]
> @@ -193,6 +191,7 @@ libcamera_deps += [
>  
>  libcamera = shared_library('libcamera',
>                             [
> +                               libcamera_public_headers,
>                                 libcamera_public_sources,
>                                 libcamera_ipa_headers,
>                                 libcamera_internal_headers,
> -- 
> Regards,
> 
> Laurent Pinchart
>