| Message ID | 20240805143654.20870-10-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
On 05/08/2024 15:36, Laurent Pinchart wrote: > The IPA headers are listed in the libcamera_public and libcamera_private > dependency objects, with the generated headers part of the private > dependency object and the non-generated headers part of the public > dependency object. As neither set of IPA headers are part of the public > API, list them both in the libcamera_private dependency object. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> > src/libcamera/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build > index deffff356091..61a97c738ae8 100644 > --- a/src/libcamera/meson.build > +++ b/src/libcamera/meson.build > @@ -207,7 +207,6 @@ libcamera = shared_library('libcamera', > dependencies : libcamera_deps) > > libcamera_public = declare_dependency(sources : [ > - libcamera_ipa_headers, > libcamera_public_headers, > ], > include_directories : libcamera_includes, > @@ -216,6 +215,7 @@ libcamera_public = declare_dependency(sources : [ > > # Internal dependency for components and plugins which can use private APIs > libcamera_private = declare_dependency(sources : [ > + libcamera_ipa_headers, > libcamera_generated_ipa_headers, > ], > dependencies : [
Quoting Laurent Pinchart (2024-08-05 15:36:45) > The IPA headers are listed in the libcamera_public and libcamera_private > dependency objects, with the generated headers part of the private > dependency object and the non-generated headers part of the public > dependency object. As neither set of IPA headers are part of the public > API, list them both in the libcamera_private dependency object. > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build > index deffff356091..61a97c738ae8 100644 > --- a/src/libcamera/meson.build > +++ b/src/libcamera/meson.build > @@ -207,7 +207,6 @@ libcamera = shared_library('libcamera', > dependencies : libcamera_deps) > > libcamera_public = declare_dependency(sources : [ > - libcamera_ipa_headers, > libcamera_public_headers, > ], > include_directories : libcamera_includes, > @@ -216,6 +215,7 @@ libcamera_public = declare_dependency(sources : [ > > # Internal dependency for components and plugins which can use private APIs > libcamera_private = declare_dependency(sources : [ > + libcamera_ipa_headers, > libcamera_generated_ipa_headers, > ], > dependencies : [ > -- > Regards, > > Laurent Pinchart >
diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build index deffff356091..61a97c738ae8 100644 --- a/src/libcamera/meson.build +++ b/src/libcamera/meson.build @@ -207,7 +207,6 @@ libcamera = shared_library('libcamera', dependencies : libcamera_deps) libcamera_public = declare_dependency(sources : [ - libcamera_ipa_headers, libcamera_public_headers, ], include_directories : libcamera_includes, @@ -216,6 +215,7 @@ libcamera_public = declare_dependency(sources : [ # Internal dependency for components and plugins which can use private APIs libcamera_private = declare_dependency(sources : [ + libcamera_ipa_headers, libcamera_generated_ipa_headers, ], dependencies : [
The IPA headers are listed in the libcamera_public and libcamera_private dependency objects, with the generated headers part of the private dependency object and the non-generated headers part of the public dependency object. As neither set of IPA headers are part of the public API, list them both in the libcamera_private dependency object. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/libcamera/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)