| Message ID | 20240807080344.12780-1-naush@raspberrypi.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi Naush, On Wed, Aug 07, 2024 at 09:03:42AM +0100, Naushir Patuck wrote: > Hi, > > This patch series, authored by Will Wang at https://github.com/raspberrypi/libcamera/pull/161, > adds support for the IMX585 sensor. > > I've made some minor formatting edits to the patches and commit messages, and > added the relevant sensor properties on top of his original patches. > > The accompanying Pi 5 support for this sensor will be added to our downstream > tree for now, and will be merged upstream together with the rest of the Pi 5 > changes. libcamera requires support for new devices in the ernel to be reasonably on its way to upstream. This usually means that patches must be posted to appropriate public lists for review, in a state deemed fit for upstreaming. > will whang (2): > libcamera: formats: Adding Support for Y12P > ipa: rpi: Adding IMX585 + IMX585-mono support > > src/ipa/rpi/cam_helper/cam_helper_imx585.cpp | 75 ++++ > src/ipa/rpi/cam_helper/meson.build | 1 + > src/ipa/rpi/vc4/data/imx585.json | 320 ++++++++++++++++++ > src/ipa/rpi/vc4/data/imx585_mono.json | 180 ++++++++++ > src/ipa/rpi/vc4/data/meson.build | 2 + > src/libcamera/bayer_format.cpp | 2 + > src/libcamera/formats.cpp | 10 + > src/libcamera/formats.yaml | 3 + > .../sensor/camera_sensor_properties.cpp | 4 + > src/libcamera/v4l2_pixelformat.cpp | 2 + > 10 files changed, 599 insertions(+) > create mode 100644 src/ipa/rpi/cam_helper/cam_helper_imx585.cpp > create mode 100644 src/ipa/rpi/vc4/data/imx585.json > create mode 100644 src/ipa/rpi/vc4/data/imx585_mono.json
Hi Laurent, On Wed, 7 Aug 2024 at 09:51, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Naush, > > On Wed, Aug 07, 2024 at 09:03:42AM +0100, Naushir Patuck wrote: > > Hi, > > > > This patch series, authored by Will Wang at https://github.com/raspberrypi/libcamera/pull/161, > > adds support for the IMX585 sensor. > > > > I've made some minor formatting edits to the patches and commit messages, and > > added the relevant sensor properties on top of his original patches. > > > > The accompanying Pi 5 support for this sensor will be added to our downstream > > tree for now, and will be merged upstream together with the rest of the Pi 5 > > changes. > > libcamera requires support for new devices in the ernel to be reasonably > on its way to upstream. This usually means that patches must be posted > to appropriate public lists for review, in a state deemed fit for > upstreaming. Apologies, this is my mistake/confusion. Kieran did point this out in the above PR. We needed to push IMX283 which is already available upstream, not IMX585! I will prepare a new series shortly. Regards, Naush > > > will whang (2): > > libcamera: formats: Adding Support for Y12P > > ipa: rpi: Adding IMX585 + IMX585-mono support > > > > src/ipa/rpi/cam_helper/cam_helper_imx585.cpp | 75 ++++ > > src/ipa/rpi/cam_helper/meson.build | 1 + > > src/ipa/rpi/vc4/data/imx585.json | 320 ++++++++++++++++++ > > src/ipa/rpi/vc4/data/imx585_mono.json | 180 ++++++++++ > > src/ipa/rpi/vc4/data/meson.build | 2 + > > src/libcamera/bayer_format.cpp | 2 + > > src/libcamera/formats.cpp | 10 + > > src/libcamera/formats.yaml | 3 + > > .../sensor/camera_sensor_properties.cpp | 4 + > > src/libcamera/v4l2_pixelformat.cpp | 2 + > > 10 files changed, 599 insertions(+) > > create mode 100644 src/ipa/rpi/cam_helper/cam_helper_imx585.cpp > > create mode 100644 src/ipa/rpi/vc4/data/imx585.json > > create mode 100644 src/ipa/rpi/vc4/data/imx585_mono.json > > -- > Regards, > > Laurent Pinchart