| Message ID | 20240805143654.20870-12-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent On 05/08/2024 15:36, Laurent Pinchart wrote: > The ipa_data_serializer.h and ipc_pipe.h headers are missing from > libcamera_internal_headers. Add them. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> > include/libcamera/internal/meson.build | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build > index 9713ea1cc27e..f96cc5e37c23 100644 > --- a/include/libcamera/internal/meson.build > +++ b/include/libcamera/internal/meson.build > @@ -28,9 +28,11 @@ libcamera_internal_headers = files([ > 'dma_buf_allocator.h', > 'formats.h', > 'framebuffer.h', > + 'ipa_data_serializer.h', > 'ipa_manager.h', > 'ipa_module.h', > 'ipa_proxy.h', > + 'ipc_pipe.h', > 'ipc_unixsocket.h', > 'mapped_framebuffer.h', > 'media_device.h',
Quoting Laurent Pinchart (2024-08-05 15:36:47) > The ipa_data_serializer.h and ipc_pipe.h headers are missing from > libcamera_internal_headers. Add them. I guess we've been fine so far as these won't have been modified so much so no dependency chain, but indeed. Lets fix.. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > include/libcamera/internal/meson.build | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build > index 9713ea1cc27e..f96cc5e37c23 100644 > --- a/include/libcamera/internal/meson.build > +++ b/include/libcamera/internal/meson.build > @@ -28,9 +28,11 @@ libcamera_internal_headers = files([ > 'dma_buf_allocator.h', > 'formats.h', > 'framebuffer.h', > + 'ipa_data_serializer.h', > 'ipa_manager.h', > 'ipa_module.h', > 'ipa_proxy.h', > + 'ipc_pipe.h', > 'ipc_unixsocket.h', > 'mapped_framebuffer.h', > 'media_device.h', > -- > Regards, > > Laurent Pinchart >
On Wed, Aug 07, 2024 at 12:15:43PM +0100, Kieran Bingham wrote: > Quoting Laurent Pinchart (2024-08-05 15:36:47) > > The ipa_data_serializer.h and ipc_pipe.h headers are missing from > > libcamera_internal_headers. Add them. > > I guess we've been fine so far as these won't have been modified so much > so no dependency chain, but indeed. Lets fix.. meson handles dependencies on static header files automatically. It's only the generated files that need to be handled manually. That's why we haven't had build issues. > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > include/libcamera/internal/meson.build | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build > > index 9713ea1cc27e..f96cc5e37c23 100644 > > --- a/include/libcamera/internal/meson.build > > +++ b/include/libcamera/internal/meson.build > > @@ -28,9 +28,11 @@ libcamera_internal_headers = files([ > > 'dma_buf_allocator.h', > > 'formats.h', > > 'framebuffer.h', > > + 'ipa_data_serializer.h', > > 'ipa_manager.h', > > 'ipa_module.h', > > 'ipa_proxy.h', > > + 'ipc_pipe.h', > > 'ipc_unixsocket.h', > > 'mapped_framebuffer.h', > > 'media_device.h',
diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build index 9713ea1cc27e..f96cc5e37c23 100644 --- a/include/libcamera/internal/meson.build +++ b/include/libcamera/internal/meson.build @@ -28,9 +28,11 @@ libcamera_internal_headers = files([ 'dma_buf_allocator.h', 'formats.h', 'framebuffer.h', + 'ipa_data_serializer.h', 'ipa_manager.h', 'ipa_module.h', 'ipa_proxy.h', + 'ipc_pipe.h', 'ipc_unixsocket.h', 'mapped_framebuffer.h', 'media_device.h',
The ipa_data_serializer.h and ipc_pipe.h headers are missing from libcamera_internal_headers. Add them. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- include/libcamera/internal/meson.build | 2 ++ 1 file changed, 2 insertions(+)