[v3,0/3] Fix misleading error messages
mbox series

Message ID 20240731183616.1977348-1-mzamazal@redhat.com
Headers show
Series
  • Fix misleading error messages
Related show

Message

Milan Zamazal July 31, 2024, 6:36 p.m. UTC 
At least with software ISP, "errors" that have actually no influence on
regular libcamera operation may be reported.  This is confusing for
users, especially in cases when there are other, real errors.  Let's improve the given log messages a bit.

Changes in v3:
- Formatting changes requested by Laurent.

Changes in v2:
- The order of the patches swapped, to put the easier change first.
- An empty line, as requested by Laurent, added.
- Added a trivial patch to unify the IPAProxy::configurationFile argument
  name in the declaration and definition.
- Added a new optional argument to IPAProxy::configurationFile for a
  fallback file, which solves the error/warning problem there.

Milan Zamazal (3):
  libcamera: simple: Log a missing sensor in a better way
  libcamera: ipa_proxy: Unify configurationFile argument name
  libcamera: ipa_proxy: Report a missing configuration as a warning

 include/libcamera/internal/ipa_proxy.h      |  3 ++-
 src/libcamera/ipa_proxy.cpp                 | 22 ++++++++++++++++-----
 src/libcamera/pipeline/ipu3/ipu3.cpp        |  5 ++---
 src/libcamera/pipeline/rkisp1/rkisp1.cpp    |  9 ++-------
 src/libcamera/pipeline/simple/simple.cpp    |  4 +++-
 src/libcamera/software_isp/software_isp.cpp |  5 ++---
 6 files changed, 28 insertions(+), 20 deletions(-)

Comments

Kieran Bingham Aug. 1, 2024, 2:09 p.m. UTC | #1 
Hello, this is a notification that patchwork/4471 has been merged.
Kieran Bingham Aug. 1, 2024, 3:09 p.m. UTC | #2 
Hello, this is a notification that patchwork/4471 has been merged.