[v2,4/4] libcamera: software_isp: Remove file seal TODO item
diff mbox series

Message ID 20240731135936.2105-5-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • libcamera: Address soft ISP file seal TODO item
Related show

Commit Message

Laurent Pinchart July 31, 2024, 1:59 p.m. UTC 
The file seal TODO item has been addressed. Remove it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 src/libcamera/software_isp/TODO | 19 -------------------
 1 file changed, 19 deletions(-)

Comments

Hans de Goede July 31, 2024, 7:01 p.m. UTC | #1 
Hi,

On 7/31/24 3:59 PM, Laurent Pinchart wrote:
> The file seal TODO item has been addressed. Remove it.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>  src/libcamera/software_isp/TODO | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO
> index 6bdc590531ca..9978afc0317b 100644
> --- a/src/libcamera/software_isp/TODO
> +++ b/src/libcamera/software_isp/TODO
> @@ -1,22 +1,3 @@
> -1. Setting F_SEAL_SHRINK and F_SEAL_GROW after ftruncate()
> -
> ->> SharedMem::SharedMem(const std::string &name, std::size_t size)
> ->> 	: name_(name), size_(size), mem_(nullptr)
> ->>
> ->> ...
> ->>
> ->> 	if (ftruncate(fd_.get(), size_) < 0)
> ->> 		return;
> ->
> -> Should we set the GROW and SHRINK seals (in a separate patch) ?
> -
> -Yes, this can be done.
> -Setting F_SEAL_SHRINK and F_SEAL_GROW after the ftruncate() call above could catch
> -some potential errors related to improper access to the shared memory allocated by
> -the SharedMemObject.
> -
> ----
> -
>  2. Reconsider stats sharing
>  
>  >>> +void SwStatsCpu::finishFrame(void)

Patch
diff mbox series 

diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO
index 6bdc590531ca..9978afc0317b 100644
--- a/src/libcamera/software_isp/TODO
+++ b/src/libcamera/software_isp/TODO
@@ -1,22 +1,3 @@ 
-1. Setting F_SEAL_SHRINK and F_SEAL_GROW after ftruncate()
-
->> SharedMem::SharedMem(const std::string &name, std::size_t size)
->> 	: name_(name), size_(size), mem_(nullptr)
->>
->> ...
->>
->> 	if (ftruncate(fd_.get(), size_) < 0)
->> 		return;
->
-> Should we set the GROW and SHRINK seals (in a separate patch) ?
-
-Yes, this can be done.
-Setting F_SEAL_SHRINK and F_SEAL_GROW after the ftruncate() call above could catch
-some potential errors related to improper access to the shared memory allocated by
-the SharedMemObject.
-
----
-
 2. Reconsider stats sharing
 
 >>> +void SwStatsCpu::finishFrame(void)