| Message ID | 20240730220253.646-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 98b01768397f982bd177b55e9bc67002b645b4d0 |
| Headers | show |
| Series |
|
| Related | show |
Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes: Hello Laurent, > The simple pipeline handler is enabled by default on arm platforms only, > as it used to support arm SoCs only. Now that support for the IPU6 has > been added to the pipeline handler, it should be enabled on x86 > platforms as well. Fix it. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- Indeed. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
On Wed, Jul 31, 2024 at 12:10:59AM +0200, Javier Martinez Canillas wrote: > Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes: > > Hello Laurent, > > > The simple pipeline handler is enabled by default on arm platforms only, > > as it used to support arm SoCs only. Now that support for the IPU6 has > > been added to the pipeline handler, it should be enabled on x86 > > platforms as well. Fix it. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > Indeed. > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> I will also add Fixes: 06e0d8508e5c ("libcamera: pipeline: simple: Enable intel-ipu6 with Soft ISP")
Quoting Laurent Pinchart (2024-07-30 23:17:49) > On Wed, Jul 31, 2024 at 12:10:59AM +0200, Javier Martinez Canillas wrote: > > Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes: > > > > Hello Laurent, > > > > > The simple pipeline handler is enabled by default on arm platforms only, > > > as it used to support arm SoCs only. Now that support for the IPU6 has > > > been added to the pipeline handler, it should be enabled on x86 > > > platforms as well. Fix it. > > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > --- > > > > Indeed. > > > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> > > I will also add > > Fixes: 06e0d8508e5c ("libcamera: pipeline: simple: Enable intel-ipu6 with Soft ISP") Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > -- > Regards, > > Laurent Pinchart
Hi, On 7/31/24 12:17 AM, Laurent Pinchart wrote: > On Wed, Jul 31, 2024 at 12:10:59AM +0200, Javier Martinez Canillas wrote: >> Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes: >> >> Hello Laurent, >> >>> The simple pipeline handler is enabled by default on arm platforms only, >>> as it used to support arm SoCs only. Now that support for the IPU6 has >>> been added to the pipeline handler, it should be enabled on x86 >>> platforms as well. Fix it. >>> >>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>> --- >> >> Indeed. >> >> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> > > I will also add > > Fixes: 06e0d8508e5c ("libcamera: pipeline: simple: Enable intel-ipu6 with Soft ISP") Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans
diff --git a/meson.build b/meson.build index f946eba94fc2..316abdb84e92 100644 --- a/meson.build +++ b/meson.build @@ -219,7 +219,7 @@ pipelines_support = { 'mali-c55': arch_arm, 'rkisp1': arch_arm, 'rpi/vc4': arch_arm, - 'simple': arch_arm, + 'simple': ['any'], 'uvcvideo': ['any'], 'vimc': ['test'], }
The simple pipeline handler is enabled by default on arm platforms only, as it used to support arm SoCs only. Now that support for the IPU6 has been added to the pipeline handler, it should be enabled on x86 platforms as well. Fix it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: c9152bad5ce905f5a31dbd05b40195f02c0cc2a9