[v3,7/9] include: media-bus-formats: Add Mali-C55 mbus codes
diff mbox series

Message ID 20240626140309.50052-8-jacopo.mondi@ideasonboard.com
State Superseded
Headers show
Series
  • Miscellaneous Mali-C55 Pipeline Fixes
Related show

Commit Message

Jacopo Mondi June 26, 2024, 2:03 p.m. UTC 
Add media bus codes introduced by the Mali C55 ISP support to describe
the 20-bit input formats supported by the ISP.

Add the following formats

- MEDIA_BUS_FMT_RGB202020_1X60

  for processed input formats
  https://lore.kernel.org/linux-media/20240529152858.183799-2-dan.scally@ideasonboard.com/

- MEDIA_BUS_FMT_SBGGR20_1X20
  MEDIA_BUS_FMT_SGBRG20_1X20
  MEDIA_BUS_FMT_SGRBG20_1X20
  MEDIA_BUS_FMT_SRGGB20_1X20

  for the RAW bayer input format
  https://lore.kernel.org/linux-media/20240529152858.183799-3-dan.scally@ideasonboard.com/

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 include/linux/media-bus-format.h | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Comments

Umang Jain June 29, 2024, 6:55 a.m. UTC | #1 
Hi Jacopo,

Thank you for the patch.

On 26/06/24 7:33 pm, Jacopo Mondi wrote:
> Add media bus codes introduced by the Mali C55 ISP support to describe
> the 20-bit input formats supported by the ISP.
>
> Add the following formats
>
> - MEDIA_BUS_FMT_RGB202020_1X60
>
>    for processed input formats
>    https://lore.kernel.org/linux-media/20240529152858.183799-2-dan.scally@ideasonboard.com/
>
> - MEDIA_BUS_FMT_SBGGR20_1X20
>    MEDIA_BUS_FMT_SGBRG20_1X20
>    MEDIA_BUS_FMT_SGRBG20_1X20
>    MEDIA_BUS_FMT_SRGGB20_1X20
>
>    for the RAW bayer input format
>    https://lore.kernel.org/linux-media/20240529152858.183799-3-dan.scally@ideasonboard.com/
>
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>   include/linux/media-bus-format.h | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/media-bus-format.h b/include/linux/media-bus-format.h
> index d4c1d991014b..b6acf8c8e383 100644
> --- a/include/linux/media-bus-format.h
> +++ b/include/linux/media-bus-format.h
> @@ -34,7 +34,7 @@
>   
>   #define MEDIA_BUS_FMT_FIXED			0x0001
>   
> -/* RGB - next is	0x1026 */
> +/* RGB - next is	0x1027 */
>   #define MEDIA_BUS_FMT_RGB444_1X12		0x1016
>   #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE	0x1001
>   #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE	0x1002
> @@ -72,6 +72,7 @@
>   #define MEDIA_BUS_FMT_RGB888_1X36_CPADLO	0x1021
>   #define MEDIA_BUS_FMT_RGB121212_1X36		0x1019
>   #define MEDIA_BUS_FMT_RGB161616_1X48		0x101a
> +#define MEDIA_BUS_FMT_RGB202020_1X60		0x1026
>   
>   /* YUV (including grey) - next is	0x202f */
>   #define MEDIA_BUS_FMT_Y8_1X8			0x2001
> @@ -121,7 +122,7 @@
>   #define MEDIA_BUS_FMT_YUV16_1X48		0x202a
>   #define MEDIA_BUS_FMT_UYYVYY16_0_5X48		0x202b
>   
> -/* Bayer - next is	0x3021 */
> +/* Bayer - next is	0x3025 */
>   #define MEDIA_BUS_FMT_SBGGR8_1X8		0x3001
>   #define MEDIA_BUS_FMT_SGBRG8_1X8		0x3013
>   #define MEDIA_BUS_FMT_SGRBG8_1X8		0x3002
> @@ -154,6 +155,10 @@
>   #define MEDIA_BUS_FMT_SGBRG16_1X16		0x301e
>   #define MEDIA_BUS_FMT_SGRBG16_1X16		0x301f
>   #define MEDIA_BUS_FMT_SRGGB16_1X16		0x3020
> +#define MEDIA_BUS_FMT_SBGGR20_1X20		0x3021
> +#define MEDIA_BUS_FMT_SGBRG20_1X20		0x3022
> +#define MEDIA_BUS_FMT_SGRBG20_1X20		0x3023
> +#define MEDIA_BUS_FMT_SRGGB20_1X20		0x3024
>   
>   /* JPEG compressed formats - next is	0x4002 */
>   #define MEDIA_BUS_FMT_JPEG_1X8			0x4001
Dan Scally July 8, 2024, 10:56 a.m. UTC | #2 
Hi Jacopo - thanks for the patch

On 26/06/2024 15:03, Jacopo Mondi wrote:
> Add media bus codes introduced by the Mali C55 ISP support to describe
> the 20-bit input formats supported by the ISP.
>
> Add the following formats
>
> - MEDIA_BUS_FMT_RGB202020_1X60
>
>    for processed input formats
>    https://lore.kernel.org/linux-media/20240529152858.183799-2-dan.scally@ideasonboard.com/
>
> - MEDIA_BUS_FMT_SBGGR20_1X20
>    MEDIA_BUS_FMT_SGBRG20_1X20
>    MEDIA_BUS_FMT_SGRBG20_1X20
>    MEDIA_BUS_FMT_SRGGB20_1X20
>
>    for the RAW bayer input format
>    https://lore.kernel.org/linux-media/20240529152858.183799-3-dan.scally@ideasonboard.com/
>
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
>   include/linux/media-bus-format.h | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/media-bus-format.h b/include/linux/media-bus-format.h
> index d4c1d991014b..b6acf8c8e383 100644
> --- a/include/linux/media-bus-format.h
> +++ b/include/linux/media-bus-format.h
> @@ -34,7 +34,7 @@
>   
>   #define MEDIA_BUS_FMT_FIXED			0x0001
>   
> -/* RGB - next is	0x1026 */
> +/* RGB - next is	0x1027 */
>   #define MEDIA_BUS_FMT_RGB444_1X12		0x1016
>   #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE	0x1001
>   #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE	0x1002
> @@ -72,6 +72,7 @@
>   #define MEDIA_BUS_FMT_RGB888_1X36_CPADLO	0x1021
>   #define MEDIA_BUS_FMT_RGB121212_1X36		0x1019
>   #define MEDIA_BUS_FMT_RGB161616_1X48		0x101a
> +#define MEDIA_BUS_FMT_RGB202020_1X60		0x1026
>   
>   /* YUV (including grey) - next is	0x202f */
>   #define MEDIA_BUS_FMT_Y8_1X8			0x2001
> @@ -121,7 +122,7 @@
>   #define MEDIA_BUS_FMT_YUV16_1X48		0x202a
>   #define MEDIA_BUS_FMT_UYYVYY16_0_5X48		0x202b
>   
> -/* Bayer - next is	0x3021 */
> +/* Bayer - next is	0x3025 */
>   #define MEDIA_BUS_FMT_SBGGR8_1X8		0x3001
>   #define MEDIA_BUS_FMT_SGBRG8_1X8		0x3013
>   #define MEDIA_BUS_FMT_SGRBG8_1X8		0x3002
> @@ -154,6 +155,10 @@
>   #define MEDIA_BUS_FMT_SGBRG16_1X16		0x301e
>   #define MEDIA_BUS_FMT_SGRBG16_1X16		0x301f
>   #define MEDIA_BUS_FMT_SRGGB16_1X16		0x3020
> +#define MEDIA_BUS_FMT_SBGGR20_1X20		0x3021
> +#define MEDIA_BUS_FMT_SGBRG20_1X20		0x3022
> +#define MEDIA_BUS_FMT_SGRBG20_1X20		0x3023
> +#define MEDIA_BUS_FMT_SRGGB20_1X20		0x3024
>   
>   /* JPEG compressed formats - next is	0x4002 */
>   #define MEDIA_BUS_FMT_JPEG_1X8			0x4001

Patch
diff mbox series 

diff --git a/include/linux/media-bus-format.h b/include/linux/media-bus-format.h
index d4c1d991014b..b6acf8c8e383 100644
--- a/include/linux/media-bus-format.h
+++ b/include/linux/media-bus-format.h
@@ -34,7 +34,7 @@ 
 
 #define MEDIA_BUS_FMT_FIXED			0x0001
 
-/* RGB - next is	0x1026 */
+/* RGB - next is	0x1027 */
 #define MEDIA_BUS_FMT_RGB444_1X12		0x1016
 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE	0x1001
 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE	0x1002
@@ -72,6 +72,7 @@ 
 #define MEDIA_BUS_FMT_RGB888_1X36_CPADLO	0x1021
 #define MEDIA_BUS_FMT_RGB121212_1X36		0x1019
 #define MEDIA_BUS_FMT_RGB161616_1X48		0x101a
+#define MEDIA_BUS_FMT_RGB202020_1X60		0x1026
 
 /* YUV (including grey) - next is	0x202f */
 #define MEDIA_BUS_FMT_Y8_1X8			0x2001
@@ -121,7 +122,7 @@ 
 #define MEDIA_BUS_FMT_YUV16_1X48		0x202a
 #define MEDIA_BUS_FMT_UYYVYY16_0_5X48		0x202b
 
-/* Bayer - next is	0x3021 */
+/* Bayer - next is	0x3025 */
 #define MEDIA_BUS_FMT_SBGGR8_1X8		0x3001
 #define MEDIA_BUS_FMT_SGBRG8_1X8		0x3013
 #define MEDIA_BUS_FMT_SGRBG8_1X8		0x3002
@@ -154,6 +155,10 @@ 
 #define MEDIA_BUS_FMT_SGBRG16_1X16		0x301e
 #define MEDIA_BUS_FMT_SGRBG16_1X16		0x301f
 #define MEDIA_BUS_FMT_SRGGB16_1X16		0x3020
+#define MEDIA_BUS_FMT_SBGGR20_1X20		0x3021
+#define MEDIA_BUS_FMT_SGBRG20_1X20		0x3022
+#define MEDIA_BUS_FMT_SGRBG20_1X20		0x3023
+#define MEDIA_BUS_FMT_SRGGB20_1X20		0x3024
 
 /* JPEG compressed formats - next is	0x4002 */
 #define MEDIA_BUS_FMT_JPEG_1X8			0x4001