| Message ID | 20240611212101.14313-6-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 5c08b179e425a8995462618a967229507293150b |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, thanks for the patch. Out if curiosity: Why __u16 and not uint16_t? In C++ code I would have expected the latter. On Wed, Jun 12, 2024 at 12:21:00AM +0300, Laurent Pinchart wrote: > Replace one occurrence of the auto type qualifier with the explicit type > it represents to increase readability. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com> Cheers, Stefan > --- > src/ipa/rkisp1/algorithms/goc.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp > index e98c9526722f..a82cee3bbf61 100644 > --- a/src/ipa/rkisp1/algorithms/goc.cpp > +++ b/src/ipa/rkisp1/algorithms/goc.cpp > @@ -112,7 +112,7 @@ void GammaOutCorrection::prepare(IPAContext &context, > 64, 64, 64, 64, 128, 128, 128, 128, 256, > 256, 256, 512, 512, 512, 512, 512, 0 > }; > - auto gamma_y = params->others.goc_config.gamma_y; > + __u16 *gamma_y = params->others.goc_config.gamma_y; > > if (!frameContext.goc.update) > return; > -- > Regards, > > Laurent Pinchart >
On Wed, Jun 12, 2024 at 09:45:24AM +0200, Stefan Klug wrote: > Hi Laurent, > > thanks for the patch. Out if curiosity: Why __u16 and not uint16_t? In > C++ code I would have expected the latter. I picked __u16 as it directly matches the type of params->others.goc_config.gamma_y. I would be fine with uint16_t too. > On Wed, Jun 12, 2024 at 12:21:00AM +0300, Laurent Pinchart wrote: > > Replace one occurrence of the auto type qualifier with the explicit type > > it represents to increase readability. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com> > > > --- > > src/ipa/rkisp1/algorithms/goc.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp > > index e98c9526722f..a82cee3bbf61 100644 > > --- a/src/ipa/rkisp1/algorithms/goc.cpp > > +++ b/src/ipa/rkisp1/algorithms/goc.cpp > > @@ -112,7 +112,7 @@ void GammaOutCorrection::prepare(IPAContext &context, > > 64, 64, 64, 64, 128, 128, 128, 128, 256, > > 256, 256, 512, 512, 512, 512, 512, 0 > > }; > > - auto gamma_y = params->others.goc_config.gamma_y; > > + __u16 *gamma_y = params->others.goc_config.gamma_y; > > > > if (!frameContext.goc.update) > > return;
diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp index e98c9526722f..a82cee3bbf61 100644 --- a/src/ipa/rkisp1/algorithms/goc.cpp +++ b/src/ipa/rkisp1/algorithms/goc.cpp @@ -112,7 +112,7 @@ void GammaOutCorrection::prepare(IPAContext &context, 64, 64, 64, 64, 128, 128, 128, 128, 256, 256, 256, 512, 512, 512, 512, 512, 0 }; - auto gamma_y = params->others.goc_config.gamma_y; + __u16 *gamma_y = params->others.goc_config.gamma_y; if (!frameContext.goc.update) return;
Replace one occurrence of the auto type qualifier with the explicit type it represents to increase readability. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/ipa/rkisp1/algorithms/goc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)